From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 070BA1DF243; Tue, 29 Oct 2024 06:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730183212; cv=none; b=Zp6C5IBdxOV5MevOgUObHec0qrLrb7IHS8ZVav8q0gYs1mrJeaL3B2024YSn3611uhEWhTd1JJvdrYOto+TplY1hL8Ct51ck/Znu9WokkF1R5svYN3gBeUT6n4c5tSfkNAoKZMJPGfFZMZm4vmZpZRgqtFYIHnkzZwYOiPPB6hQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730183212; c=relaxed/simple; bh=IfNNGE41sAXqehyuYoE/cEw3HG+DgkTj+GhJu0Wj7gw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U0cu82XlhUWKivCkliIc+t6eiC1aTCP9AUsaPP6NrUowbS7tPt22mFwWD0sV7rl/a6M57OqsaZciVOHKquHiI6iFHNlZCBMey3Rw2LCksZkLoaCm+KzowFGIbWisSE7vjOebkdU063dX8W55n8moLz6gpFhjIq+Y34PHyb1uPEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I1wsk7ho; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I1wsk7ho" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C7A4C4CECD; Tue, 29 Oct 2024 06:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730183211; bh=IfNNGE41sAXqehyuYoE/cEw3HG+DgkTj+GhJu0Wj7gw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=I1wsk7hofiKEX3lmeXbG/Ml53ueyliw3uXt0HwTKekAoKM/pdshMmz+7/1/7XgGA0 JkTOYJwoainHiCoQXXUofe7sGmjSEuZJ+xHeH8MpuD5v8p6qH4tmsyEO1O6hnj+H1+ 28emFmOis+9BY7SASlv6ivNU9ZRuwbIwIuHzavfg/cQesrnd8S9YaBBEn4RT5essU2 btHSECArULcVC/sbznvmn2K0VPEB8aK3UWCLmlQOQjID9IZPOmAImeHKgxQmEWHiG1 PGCelYQE2E3OzudL2TYZPGFyQl1ni1GK2roHz5mHbDinG2aXLKZsL+wax0F7Cvi4Ch B89d9igmVq13g== Message-ID: <913df216-d031-4681-957e-c9354da337ea@kernel.org> Date: Tue, 29 Oct 2024 07:26:44 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] ASoC: dt-bindings: mediatek,mt8188-mt6359: Update DAI link node pattern To: Fei Shao Cc: Mark Brown , AngeloGioacchino Del Regno , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Matthias Brugger , Rob Herring , Trevor Wu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sound@vger.kernel.org References: <20241025104548.1220076-1-fshao@chromium.org> <20241025104548.1220076-3-fshao@chromium.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 28/10/2024 12:12, Fei Shao wrote: > On Mon, Oct 28, 2024 at 4:56 AM Krzysztof Kozlowski wrote: >> >> On Fri, Oct 25, 2024 at 06:44:42PM +0800, Fei Shao wrote: >>> The associated machine driver is not dependent on the format of DAI link >>> node names. This means we are allowed to use more descriptive names >>> instead of indices without impacting functionality. >>> >>> Update the binding to accept arbitrary DAI link names with a "-dai-link" >>> suffix. This is the common pattern used by the target (MT8188) and other >>> (MT8195, MT8186 etc.) MediaTek-based Chromebooks. >> >> We do not want arbitrary names. Why for example green-batman-dai-link >> should be correct? The existing pattern looks wrong. Please read DT spec >> and chapter about recommended names. > > At first I was thinking about regex like > `^[a-z-]+(-[a-z]+)*-dai-link$` based on the DTS coding style guide, > but your example is not suggesting that. > and the name like "hs-capture-dai-link" was rejected, so it's not just > about enumerating the names either. > Or "^dai-link@[0-9a-f]+$"? But they don't tie to particular register > addresses... or just for some pseudo indices? > I could miss something about DAI links under the sound documentation. > Still trying to figure it out. You did not provide any reasoning why this has to be changed and why usually preferred generic dai-link is not correct. Names are not descriptive. > >> >>> >>> Signed-off-by: Fei Shao >>> --- >>> >>> .../devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml >>> index 701cedfa38d2..2da34b66818f 100644 >>> --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml >>> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml >>> @@ -40,7 +40,7 @@ properties: >>> name defined in the machine driver. >>> >>> patternProperties: >>> - "^dai-link-[0-9]+$": >>> + ".*-dai-link$": >> >> This breaks existing users. > > There's no existing users in upstream, and the only downstream user is > the MT8188 Chromebook DT that I'm trying to upstream, which I can fix. > This binding was upstreamed exclusively for that DT. So you have entire commit msg to explain impact. Best regards, Krzysztof