Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>
Cc: "Elgin Perumbilly" <elgin.perumbilly@siliconsignals.io>,
	"Vladimir Zapolskiy" <vladimir.zapolskiy@linaro.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Hans Verkuil" <hverkuil@kernel.org>,
	"Hans de Goede" <hansg@kernel.org>,
	"Mehdi Djait" <mehdi.djait@linux.intel.com>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Dongcheng Yan" <dongcheng.yan@intel.com>,
	"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
	"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
	"Hardevsinh Palaniya" <hardevsinh.palaniya@siliconsignals.io>,
	"Svyatoslav Ryhel" <clamor95@gmail.com>,
	"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
	"Jingjing Xiong" <jingjing.xiong@intel.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add os05b10 sensor
Date: Sat, 20 Dec 2025 09:21:03 +0100	[thread overview]
Message-ID: <91523e97-95df-464a-9658-d29cdc54f3ae@kernel.org> (raw)
In-Reply-To: <PN0P287MB2019D9CDB7D2E29A933CDE529AB6A@PN0P287MB2019.INDP287.PROD.OUTLOOK.COM>

On 20/12/2025 07:37, Himanshu Bhavani wrote:
> Hi Krzysztof,
>  
>> On 19/12/2025 09:45, Himanshu Bhavani wrote:
>>> From: Elgin Perumbilly <elgin.perumbilly@siliconsignals.io>
>>>
>>> Add bindings for Omnivision OS05B10 sensor.
>>>
>>> Add MAINTAINERS entry for Omnivision OS05B10 binding documentation
>>>
>>> Signed-off-by: Elgin Perumbilly <elgin.perumbilly@siliconsignals.io>
>>> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
>>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>> ---
>>
>>
>> Nothing improved and you did not bother to respond to my comment.
>  
>  
> In v5, you pointed out that the driver and bindings were mismatched with 
> respect to the reset GPIO.
>  
> Based on that feedback, I corrected the driver by making the reset GPIO 
> optional. I also reviewed a previous patch series discussion, as suggested 
> here:
> https://lore.kernel.org/linux-media/20250710210532.GE22436@pendragon.ideasonboard.com/
>  
> In that thread, Laurent suggested that GPIOs should be made optional in the 
> driver, which is what I followed in this version.
>  
> If I have still missed something or misunderstood the feedback, please let me
> know and I will address it.

I expected reply or change in the binding. None was there, so that's why
you got questions.

Best regards,
Krzysztof

  reply	other threads:[~2025-12-20  8:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  8:45 [PATCH v6 0/2] media: i2c: Add os05b10 camera sensor driver Himanshu Bhavani
2025-12-19  8:45 ` [PATCH v6 1/2] dt-bindings: media: i2c: Add os05b10 sensor Himanshu Bhavani
2025-12-19 14:43   ` Krzysztof Kozlowski
2025-12-20  6:37     ` Himanshu Bhavani
2025-12-20  8:21       ` Krzysztof Kozlowski [this message]
2025-12-20  8:59         ` Himanshu Bhavani
2025-12-20  8:21   ` Krzysztof Kozlowski
2025-12-19  8:45 ` [PATCH v6 2/2] media: i2c: add os05b10 image sensor driver Himanshu Bhavani
2025-12-19 14:07   ` Mehdi Djait
2025-12-20  6:01     ` Tarang Raval
2025-12-22 16:08       ` Mehdi Djait
2025-12-30 12:24   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91523e97-95df-464a-9658-d29cdc54f3ae@kernel.org \
    --to=krzk@kernel.org \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dongcheng.yan@intel.com \
    --cc=elgin.perumbilly@siliconsignals.io \
    --cc=git@apitzsch.eu \
    --cc=hansg@kernel.org \
    --cc=hardevsinh.palaniya@siliconsignals.io \
    --cc=heimir.sverrisson@gmail.com \
    --cc=himanshu.bhavani@siliconsignals.io \
    --cc=hverkuil@kernel.org \
    --cc=jingjing.xiong@intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox