From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg Date: Fri, 8 Sep 2017 11:23:13 -0700 Message-ID: <9153f30c-adf5-8563-8333-3ff2e2e46dc9@gmail.com> References: <1504125721-4760-1-git-send-email-loic.poulain@gmail.com> <19D1F3B6-A05B-425B-A06D-AD44EEE39BFE@holtmann.org> <874lsdnkk5.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marcel Holtmann , Eric Anholt Cc: Loic Poulain , f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ray Jui , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, devicetree , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/08/2017 11:04 AM, Marcel Holtmann wrote: > Hi Eric, > >>>> Add the serial port config to "chosen/stdout-path". >>>> Create serial0/1 aliases referring to uart0 ant uart1 paths. >>>> Remove unneeded earlyprintk. >>>> >>>> Acked-by: Rob Herring >>>> Signed-off-by: Loic Poulain >>>> --- >>>> arch/arm/boot/dts/bcm283x.dtsi | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> v2: dt-bindings as separate patch >>>> rebase on upcoming pi3 dts changes >>>> v3: changes in bcm serdev drivers: >>>> name refactoring and additional comments >>>> Add generic host_set_baudrate method >>>> Use agnostic device_property_read >>>> v4: changes in doc and dts: >>>> Add additional params to broadcom bt dt-bindings >>>> Set the max baudrate to 2000000 instead of 921600 >>>> use chosen/stdout-path instead of console= >>>> remove useless earlyprintk >>>> same changes in bcm283x.dtsi >>>> v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support >>>> 1/4 and 4/4 merged in bluetooth-next tree >>>> >>>> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi >>>> index 431dcfc..013431e 100644 >>>> --- a/arch/arm/boot/dts/bcm283x.dtsi >>>> +++ b/arch/arm/boot/dts/bcm283x.dtsi >>>> @@ -20,8 +20,13 @@ >>>> #address-cells = <1>; >>>> #size-cells = <1>; >>>> >>>> + aliases { >>>> + serial0 = &uart0; >>>> + serial1 = &uart1; >>>> + }; >>>> + >>>> chosen { >>>> - bootargs = "earlyprintk console=ttyAMA0"; >>>> + stdout-path = "serial0:115200n8"; >>>> }; >>> >>> is anybody taking care of these two patches. I do not see them in Linus’ tree yet? >> >> arm-soc process unfortunately doesn't accept PRs between rc5 or 6 and >> the next rc1, so they're still in my TODO pile for when we get -rc1 >> again. > > the aliases change is actually fixing a real issue. The RPI 3 has the Bluetooth controller where the older models had the console. Leave the bluetooth { } section out of it, but at least fix the bootargs bug and use stdout-path with the correct aliases. Postponing real fixes like this until next -rc1 is a stupid process. Since this is a real fix, what's the proper Fixes: tag for that so it can also be backported to -stable trees? Fixes can be submitted pretty much at any time, and having a Fixes: tag helps everyone maintaining -stable trees to get that backported where appropriate. Thanks -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html