* [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg @ 2017-08-30 20:42 Loic Poulain [not found] ` <1504125721-4760-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Loic Poulain @ 2017-08-30 20:42 UTC (permalink / raw) To: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, eric-WhKQ6XTQaPysTnJN9+BGXg, rjui-dY08KVG/lbpWk0Htik3J/w Cc: bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, marcel-kz+m5ild9QBg9hUCZPvPmw, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, Loic Poulain Add the serial port config to "chosen/stdout-path". Create serial0/1 aliases referring to uart0 ant uart1 paths. Remove unneeded earlyprintk. Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/bcm283x.dtsi | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) v2: dt-bindings as separate patch rebase on upcoming pi3 dts changes v3: changes in bcm serdev drivers: name refactoring and additional comments Add generic host_set_baudrate method Use agnostic device_property_read v4: changes in doc and dts: Add additional params to broadcom bt dt-bindings Set the max baudrate to 2000000 instead of 921600 use chosen/stdout-path instead of console= remove useless earlyprintk same changes in bcm283x.dtsi v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support 1/4 and 4/4 merged in bluetooth-next tree diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi index 431dcfc..013431e 100644 --- a/arch/arm/boot/dts/bcm283x.dtsi +++ b/arch/arm/boot/dts/bcm283x.dtsi @@ -20,8 +20,13 @@ #address-cells = <1>; #size-cells = <1>; + aliases { + serial0 = &uart0; + serial1 = &uart1; + }; + chosen { - bootargs = "earlyprintk console=ttyAMA0"; + stdout-path = "serial0:115200n8"; }; thermal-zones { -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <1504125721-4760-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH v5 2/2] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 serial slave [not found] ` <1504125721-4760-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-08-30 20:42 ` Loic Poulain [not found] ` <1504125721-4760-2-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-09-08 12:52 ` [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg Marcel Holtmann 1 sibling, 1 reply; 9+ messages in thread From: Loic Poulain @ 2017-08-30 20:42 UTC (permalink / raw) To: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, eric-WhKQ6XTQaPysTnJN9+BGXg, rjui-dY08KVG/lbpWk0Htik3J/w Cc: bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, marcel-kz+m5ild9QBg9hUCZPvPmw, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, Loic Poulain Add BCM43438 (bluetooth) as a slave device of uart0 (pl011/ttyAMA0). This allows to automatically insert the bcm43438 to the bluetooth subsystem instead of relying on userspace helpers (hciattach). Overwrite chosen/stdout-path to use 8250 aux uart as console. Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 10 ++++++++++ 1 file changed, 10 insertions(+) v2: dt-bindings as separate patch rebase on upcoming pi3 dts changes v3: changes in bcm serdev drivers: name refactoring and additional comments Add generic host_set_baudrate method Use agnostic device_property_read v4: changes in doc and dts: Add additional params to broadcom bt dt-bindings Set the max baudrate to 2000000 instead of 921600 use chosen/stdout-path instead of console= remove useless earlyprintk same changes in bcm283x.dtsi v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support 1/4 and 4/4 merged in bluetooth-next tree diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts index 20725ca..e4488cb 100644 --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts @@ -8,6 +8,11 @@ compatible = "raspberrypi,3-model-b", "brcm,bcm2837"; model = "Raspberry Pi 3 Model B"; + chosen { + /* 8250 auxiliar UART instead of pl011 */ + stdout-path = "serial1:115200n8"; + }; + memory { reg = <0 0x40000000>; }; @@ -24,6 +29,11 @@ pinctrl-names = "default"; pinctrl-0 = <&uart0_gpio32 &gpclk2_gpio43>; status = "okay"; + + bluetooth { + compatible = "brcm,bcm43438-bt"; + max-speed = <2000000>; + }; }; /* uart1 is mapped to the pin header */ -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <1504125721-4760-2-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v5 2/2] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 serial slave [not found] ` <1504125721-4760-2-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-09-08 12:53 ` Marcel Holtmann [not found] ` <C1D28787-A7C3-4A7A-8EAC-7E7994E54B29-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Marcel Holtmann @ 2017-09-08 12:53 UTC (permalink / raw) To: Loic Poulain Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, eric-WhKQ6XTQaPysTnJN9+BGXg, rjui-dY08KVG/lbpWk0Htik3J/w, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A Hi, > Add BCM43438 (bluetooth) as a slave device of uart0 (pl011/ttyAMA0). > This allows to automatically insert the bcm43438 to the bluetooth > subsystem instead of relying on userspace helpers (hciattach). > > Overwrite chosen/stdout-path to use 8250 aux uart as console. > > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > v2: dt-bindings as separate patch > rebase on upcoming pi3 dts changes > v3: changes in bcm serdev drivers: > name refactoring and additional comments > Add generic host_set_baudrate method > Use agnostic device_property_read > v4: changes in doc and dts: > Add additional params to broadcom bt dt-bindings > Set the max baudrate to 2000000 instead of 921600 > use chosen/stdout-path instead of console= > remove useless earlyprintk > same changes in bcm283x.dtsi > v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support > 1/4 and 4/4 merged in bluetooth-next tree > > diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts > index 20725ca..e4488cb 100644 > --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts > +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts > @@ -8,6 +8,11 @@ > compatible = "raspberrypi,3-model-b", "brcm,bcm2837"; > model = "Raspberry Pi 3 Model B"; > > + chosen { > + /* 8250 auxiliar UART instead of pl011 */ > + stdout-path = "serial1:115200n8"; > + }; > + > memory { > reg = <0 0x40000000>; > }; > @@ -24,6 +29,11 @@ > pinctrl-names = "default"; > pinctrl-0 = <&uart0_gpio32 &gpclk2_gpio43>; > status = "okay"; > + > + bluetooth { > + compatible = "brcm,bcm43438-bt"; > + max-speed = <2000000>; > + }; > }; > the driver for this is already in Linus’ tree. And I would really prefer that we get the DT changes merged in as well. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <C1D28787-A7C3-4A7A-8EAC-7E7994E54B29-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCH v5 2/2] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 serial slave [not found] ` <C1D28787-A7C3-4A7A-8EAC-7E7994E54B29-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> @ 2017-10-06 22:03 ` Eric Anholt 0 siblings, 0 replies; 9+ messages in thread From: Eric Anholt @ 2017-10-06 22:03 UTC (permalink / raw) To: Marcel Holtmann, Loic Poulain Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, rjui-dY08KVG/lbpWk0Htik3J/w, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A [-- Attachment #1: Type: text/plain, Size: 2353 bytes --] Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> writes: > Hi, > >> Add BCM43438 (bluetooth) as a slave device of uart0 (pl011/ttyAMA0). >> This allows to automatically insert the bcm43438 to the bluetooth >> subsystem instead of relying on userspace helpers (hciattach). >> >> Overwrite chosen/stdout-path to use 8250 aux uart as console. >> >> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> v2: dt-bindings as separate patch >> rebase on upcoming pi3 dts changes >> v3: changes in bcm serdev drivers: >> name refactoring and additional comments >> Add generic host_set_baudrate method >> Use agnostic device_property_read >> v4: changes in doc and dts: >> Add additional params to broadcom bt dt-bindings >> Set the max baudrate to 2000000 instead of 921600 >> use chosen/stdout-path instead of console= >> remove useless earlyprintk >> same changes in bcm283x.dtsi >> v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support >> 1/4 and 4/4 merged in bluetooth-next tree >> >> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts >> index 20725ca..e4488cb 100644 >> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts >> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts >> @@ -8,6 +8,11 @@ >> compatible = "raspberrypi,3-model-b", "brcm,bcm2837"; >> model = "Raspberry Pi 3 Model B"; >> >> + chosen { >> + /* 8250 auxiliar UART instead of pl011 */ >> + stdout-path = "serial1:115200n8"; >> + }; >> + >> memory { >> reg = <0 0x40000000>; >> }; >> @@ -24,6 +29,11 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&uart0_gpio32 &gpclk2_gpio43>; >> status = "okay"; >> + >> + bluetooth { >> + compatible = "brcm,bcm43438-bt"; >> + max-speed = <2000000>; >> + }; >> }; >> > > the driver for this is already in Linus’ tree. And I would really prefer that we get the DT changes merged in as well. Now that the separated stdout patch is ready to go, I've applied this for -next (dropping the chosen node) and I'm sending the PR for both. Thanks so much for working on this! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg [not found] ` <1504125721-4760-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-08-30 20:42 ` [PATCH v5 2/2] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 serial slave Loic Poulain @ 2017-09-08 12:52 ` Marcel Holtmann [not found] ` <19D1F3B6-A05B-425B-A06D-AD44EEE39BFE-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 1 sibling, 1 reply; 9+ messages in thread From: Marcel Holtmann @ 2017-09-08 12:52 UTC (permalink / raw) To: Loic Poulain Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, Eric Anholt, Ray Jui, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A Hi, > Add the serial port config to "chosen/stdout-path". > Create serial0/1 aliases referring to uart0 ant uart1 paths. > Remove unneeded earlyprintk. > > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/bcm283x.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > v2: dt-bindings as separate patch > rebase on upcoming pi3 dts changes > v3: changes in bcm serdev drivers: > name refactoring and additional comments > Add generic host_set_baudrate method > Use agnostic device_property_read > v4: changes in doc and dts: > Add additional params to broadcom bt dt-bindings > Set the max baudrate to 2000000 instead of 921600 > use chosen/stdout-path instead of console= > remove useless earlyprintk > same changes in bcm283x.dtsi > v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support > 1/4 and 4/4 merged in bluetooth-next tree > > diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi > index 431dcfc..013431e 100644 > --- a/arch/arm/boot/dts/bcm283x.dtsi > +++ b/arch/arm/boot/dts/bcm283x.dtsi > @@ -20,8 +20,13 @@ > #address-cells = <1>; > #size-cells = <1>; > > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; > + }; > + > chosen { > - bootargs = "earlyprintk console=ttyAMA0"; > + stdout-path = "serial0:115200n8"; > }; is anybody taking care of these two patches. I do not see them in Linus’ tree yet? Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <19D1F3B6-A05B-425B-A06D-AD44EEE39BFE-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg [not found] ` <19D1F3B6-A05B-425B-A06D-AD44EEE39BFE-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> @ 2017-09-08 17:53 ` Eric Anholt [not found] ` <874lsdnkk5.fsf-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Eric Anholt @ 2017-09-08 17:53 UTC (permalink / raw) To: Marcel Holtmann, Loic Poulain Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, Ray Jui, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A [-- Attachment #1: Type: text/plain, Size: 1869 bytes --] Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> writes: > Hi, > >> Add the serial port config to "chosen/stdout-path". >> Create serial0/1 aliases referring to uart0 ant uart1 paths. >> Remove unneeded earlyprintk. >> >> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> arch/arm/boot/dts/bcm283x.dtsi | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> v2: dt-bindings as separate patch >> rebase on upcoming pi3 dts changes >> v3: changes in bcm serdev drivers: >> name refactoring and additional comments >> Add generic host_set_baudrate method >> Use agnostic device_property_read >> v4: changes in doc and dts: >> Add additional params to broadcom bt dt-bindings >> Set the max baudrate to 2000000 instead of 921600 >> use chosen/stdout-path instead of console= >> remove useless earlyprintk >> same changes in bcm283x.dtsi >> v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support >> 1/4 and 4/4 merged in bluetooth-next tree >> >> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi >> index 431dcfc..013431e 100644 >> --- a/arch/arm/boot/dts/bcm283x.dtsi >> +++ b/arch/arm/boot/dts/bcm283x.dtsi >> @@ -20,8 +20,13 @@ >> #address-cells = <1>; >> #size-cells = <1>; >> >> + aliases { >> + serial0 = &uart0; >> + serial1 = &uart1; >> + }; >> + >> chosen { >> - bootargs = "earlyprintk console=ttyAMA0"; >> + stdout-path = "serial0:115200n8"; >> }; > > is anybody taking care of these two patches. I do not see them in Linus’ tree yet? arm-soc process unfortunately doesn't accept PRs between rc5 or 6 and the next rc1, so they're still in my TODO pile for when we get -rc1 again. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <874lsdnkk5.fsf-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>]
* Re: [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg [not found] ` <874lsdnkk5.fsf-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> @ 2017-09-08 18:04 ` Marcel Holtmann [not found] ` <C7897D52-34DE-4EAD-BA79-67ED91929D85-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Marcel Holtmann @ 2017-09-08 18:04 UTC (permalink / raw) To: Eric Anholt Cc: Loic Poulain, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, Ray Jui, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree, robh+dt-DgEjT+Ai2ygdnm+yROfE0A Hi Eric, >>> Add the serial port config to "chosen/stdout-path". >>> Create serial0/1 aliases referring to uart0 ant uart1 paths. >>> Remove unneeded earlyprintk. >>> >>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >>> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>> --- >>> arch/arm/boot/dts/bcm283x.dtsi | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> v2: dt-bindings as separate patch >>> rebase on upcoming pi3 dts changes >>> v3: changes in bcm serdev drivers: >>> name refactoring and additional comments >>> Add generic host_set_baudrate method >>> Use agnostic device_property_read >>> v4: changes in doc and dts: >>> Add additional params to broadcom bt dt-bindings >>> Set the max baudrate to 2000000 instead of 921600 >>> use chosen/stdout-path instead of console= >>> remove useless earlyprintk >>> same changes in bcm283x.dtsi >>> v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support >>> 1/4 and 4/4 merged in bluetooth-next tree >>> >>> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi >>> index 431dcfc..013431e 100644 >>> --- a/arch/arm/boot/dts/bcm283x.dtsi >>> +++ b/arch/arm/boot/dts/bcm283x.dtsi >>> @@ -20,8 +20,13 @@ >>> #address-cells = <1>; >>> #size-cells = <1>; >>> >>> + aliases { >>> + serial0 = &uart0; >>> + serial1 = &uart1; >>> + }; >>> + >>> chosen { >>> - bootargs = "earlyprintk console=ttyAMA0"; >>> + stdout-path = "serial0:115200n8"; >>> }; >> >> is anybody taking care of these two patches. I do not see them in Linus’ tree yet? > > arm-soc process unfortunately doesn't accept PRs between rc5 or 6 and > the next rc1, so they're still in my TODO pile for when we get -rc1 > again. the aliases change is actually fixing a real issue. The RPI 3 has the Bluetooth controller where the older models had the console. Leave the bluetooth { } section out of it, but at least fix the bootargs bug and use stdout-path with the correct aliases. Postponing real fixes like this until next -rc1 is a stupid process. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <C7897D52-34DE-4EAD-BA79-67ED91929D85-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg [not found] ` <C7897D52-34DE-4EAD-BA79-67ED91929D85-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> @ 2017-09-08 18:23 ` Florian Fainelli [not found] ` <9153f30c-adf5-8563-8333-3ff2e2e46dc9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Florian Fainelli @ 2017-09-08 18:23 UTC (permalink / raw) To: Marcel Holtmann, Eric Anholt Cc: Loic Poulain, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, Ray Jui, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree, robh+dt-DgEjT+Ai2ygdnm+yROfE0A On 09/08/2017 11:04 AM, Marcel Holtmann wrote: > Hi Eric, > >>>> Add the serial port config to "chosen/stdout-path". >>>> Create serial0/1 aliases referring to uart0 ant uart1 paths. >>>> Remove unneeded earlyprintk. >>>> >>>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >>>> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>>> --- >>>> arch/arm/boot/dts/bcm283x.dtsi | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> v2: dt-bindings as separate patch >>>> rebase on upcoming pi3 dts changes >>>> v3: changes in bcm serdev drivers: >>>> name refactoring and additional comments >>>> Add generic host_set_baudrate method >>>> Use agnostic device_property_read >>>> v4: changes in doc and dts: >>>> Add additional params to broadcom bt dt-bindings >>>> Set the max baudrate to 2000000 instead of 921600 >>>> use chosen/stdout-path instead of console= >>>> remove useless earlyprintk >>>> same changes in bcm283x.dtsi >>>> v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support >>>> 1/4 and 4/4 merged in bluetooth-next tree >>>> >>>> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi >>>> index 431dcfc..013431e 100644 >>>> --- a/arch/arm/boot/dts/bcm283x.dtsi >>>> +++ b/arch/arm/boot/dts/bcm283x.dtsi >>>> @@ -20,8 +20,13 @@ >>>> #address-cells = <1>; >>>> #size-cells = <1>; >>>> >>>> + aliases { >>>> + serial0 = &uart0; >>>> + serial1 = &uart1; >>>> + }; >>>> + >>>> chosen { >>>> - bootargs = "earlyprintk console=ttyAMA0"; >>>> + stdout-path = "serial0:115200n8"; >>>> }; >>> >>> is anybody taking care of these two patches. I do not see them in Linus’ tree yet? >> >> arm-soc process unfortunately doesn't accept PRs between rc5 or 6 and >> the next rc1, so they're still in my TODO pile for when we get -rc1 >> again. > > the aliases change is actually fixing a real issue. The RPI 3 has the Bluetooth controller where the older models had the console. Leave the bluetooth { } section out of it, but at least fix the bootargs bug and use stdout-path with the correct aliases. Postponing real fixes like this until next -rc1 is a stupid process. Since this is a real fix, what's the proper Fixes: tag for that so it can also be backported to -stable trees? Fixes can be submitted pretty much at any time, and having a Fixes: tag helps everyone maintaining -stable trees to get that backported where appropriate. Thanks -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <9153f30c-adf5-8563-8333-3ff2e2e46dc9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg [not found] ` <9153f30c-adf5-8563-8333-3ff2e2e46dc9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-09-08 18:35 ` Marcel Holtmann 0 siblings, 0 replies; 9+ messages in thread From: Marcel Holtmann @ 2017-09-08 18:35 UTC (permalink / raw) To: Florian Fainelli Cc: Eric Anholt, Loic Poulain, Ray Jui, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, devicetree, robh+dt-DgEjT+Ai2ygdnm+yROfE0A Hi Florian, >>>>> Add the serial port config to "chosen/stdout-path". >>>>> Create serial0/1 aliases referring to uart0 ant uart1 paths. >>>>> Remove unneeded earlyprintk. >>>>> >>>>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >>>>> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>>>> --- >>>>> arch/arm/boot/dts/bcm283x.dtsi | 7 ++++++- >>>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>>> >>>>> v2: dt-bindings as separate patch >>>>> rebase on upcoming pi3 dts changes >>>>> v3: changes in bcm serdev drivers: >>>>> name refactoring and additional comments >>>>> Add generic host_set_baudrate method >>>>> Use agnostic device_property_read >>>>> v4: changes in doc and dts: >>>>> Add additional params to broadcom bt dt-bindings >>>>> Set the max baudrate to 2000000 instead of 921600 >>>>> use chosen/stdout-path instead of console= >>>>> remove useless earlyprintk >>>>> same changes in bcm283x.dtsi >>>>> v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support >>>>> 1/4 and 4/4 merged in bluetooth-next tree >>>>> >>>>> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi >>>>> index 431dcfc..013431e 100644 >>>>> --- a/arch/arm/boot/dts/bcm283x.dtsi >>>>> +++ b/arch/arm/boot/dts/bcm283x.dtsi >>>>> @@ -20,8 +20,13 @@ >>>>> #address-cells = <1>; >>>>> #size-cells = <1>; >>>>> >>>>> + aliases { >>>>> + serial0 = &uart0; >>>>> + serial1 = &uart1; >>>>> + }; >>>>> + >>>>> chosen { >>>>> - bootargs = "earlyprintk console=ttyAMA0"; >>>>> + stdout-path = "serial0:115200n8"; >>>>> }; >>>> >>>> is anybody taking care of these two patches. I do not see them in Linus’ tree yet? >>> >>> arm-soc process unfortunately doesn't accept PRs between rc5 or 6 and >>> the next rc1, so they're still in my TODO pile for when we get -rc1 >>> again. >> >> the aliases change is actually fixing a real issue. The RPI 3 has the Bluetooth controller where the older models had the console. Leave the bluetooth { } section out of it, but at least fix the bootargs bug and use stdout-path with the correct aliases. Postponing real fixes like this until next -rc1 is a stupid process. > > Since this is a real fix, what's the proper Fixes: tag for that so it > can also be backported to -stable trees? > > Fixes can be submitted pretty much at any time, and having a Fixes: tag > helps everyone maintaining -stable trees to get that backported where > appropriate. backporting will be hard since these patches depend on changes that will only be available in 4.14-rc1. I don’t really know how invasive the patch that introduces uart0 for RPI 3 is. However I am pretty sure that Loic can combine these two patches (and leaving the bluetooth { } section out) and send it with a proper annotation as fix. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-10-06 22:03 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-08-30 20:42 [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg Loic Poulain [not found] ` <1504125721-4760-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-08-30 20:42 ` [PATCH v5 2/2] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 serial slave Loic Poulain [not found] ` <1504125721-4760-2-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-09-08 12:53 ` Marcel Holtmann [not found] ` <C1D28787-A7C3-4A7A-8EAC-7E7994E54B29-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 2017-10-06 22:03 ` Eric Anholt 2017-09-08 12:52 ` [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg Marcel Holtmann [not found] ` <19D1F3B6-A05B-425B-A06D-AD44EEE39BFE-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 2017-09-08 17:53 ` Eric Anholt [not found] ` <874lsdnkk5.fsf-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2017-09-08 18:04 ` Marcel Holtmann [not found] ` <C7897D52-34DE-4EAD-BA79-67ED91929D85-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 2017-09-08 18:23 ` Florian Fainelli [not found] ` <9153f30c-adf5-8563-8333-3ff2e2e46dc9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-09-08 18:35 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).