From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.214 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793626249; b=FLqNuaEZPeZCmbc404jI2TtKh4uFaOGZfdJPFQRIh4QTB6KfPw/mLLX9ZoFnzSU4AM3/ u91swDhxDrf42fqxHkpkS0lo1KAGqfuHE6f7vVAUetmQrk3+wQpW2FwcQssBimHhoLJnb ezXwM+bcNF0K8t4oNq0YRQVdskajggUuXpzlgC7j57/y5ijadPUicoxoag1b+iG7T+m4P 4zYJnSNJLB/np09lzbMSMDuF/y28KUkoWS0MSa89cewMxGs1MnOfyFO+NQTKt/GJj6Zd5 mwSNrk1fxaqdocM/ScsFwe4N0vsljTivKvAD4jxIuTRg/4xr+Re33f4p582/thppx3A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793626249; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=Celi/Jf23dDYxiVlznjq1HrYLFzw7DtXkyqXcvMwU1o=; b=Ywn9QhgLs9a6/w4SoOWbaqpNgCFr/9lCaUwtYOx1NdD5PhBJhzg0sTBpJCP4riE8ZgDA fRuVUqZ0UY2SM+0LGO3bnKcK4ie25+xZKaWTeQwkSzhlBTxAjA+nqa20srkJ0BSVOxQgK Tvk9pusECDHQ3ypIWlv7Woo1Rq2gk2QCgiqZjyYqBCi/V8/1Li8JV3bUFS0bQhjJsOBsi 8Fio2YkeLFOYodxHGE3KqU25mNXR/ADpNfY4Mqf/7PA4L0CC47qQFSbqMr9amKq5DzbPI RadvlZ0pJsJAU2EZmHoT9S5+WHbHkpgSPA6IQFXM3ey14oHSM0z6AOraT39UehXg9eQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b="AS1MX/tH"; arc=none smtp.remote-ip=95.215.58.214 Received: from mta1.migadu.com (out-214.mta1.migadu.com [95.215.58.214]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEABC606A324 for ; Mon, 2 Nov 2026 13:30:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EEABC606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=AS1MX/tH X-Envelope-To: devicetree@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=QSwhozA28ShgXnO4vo/Y2h8mkgH1EmGlGFODbd6mOaU=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793626247; v=1; x=1794231047; b=AS1MX/tHy1Xh6hT5A3J7vHbxVLGdWvY/MRqsGKJmnUEkfiTxxJTch/2EYtLURPsRGTS2gsf+ MPcb78rGN+UfaEtv7174ACh5as6ehZa2cLAtxNCaEs/yBeLKup94iH1/CqLvKnb0oPL7eMw8B6Q coGHnPnpsvuhGHnr9t8NbJk0= X-Envelope-To: devicetree@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 83255ff9d38ebe22; Mon, 02 Nov 2026 13:30:44 +0000 X-Mizu-Trace-ID: 83255ff9d38ebe22 X-Migadu-Flow: FLOW_OUT Message-ID: <91573b8c-d5e3-40ab-9e9b-be55e93425c5@linux.dev> Date: Mon, 2 Nov 2026 13:30:42 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/14] drm/tidss: oldi: Fix cleanup on a failed init To: Tomi Valkeinen Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Nishanth Menon , Vignesh Raghavendra , Swamil Jain , Devarsh Thakkar , Louis Chauvet References: <20261029-beagley-ai-display-v4-0-dc7f2b532478@ideasonboard.com> <20261029-beagley-ai-display-v4-9-dc7f2b532478@ideasonboard.com> <15b7bfd9-8da4-4cd0-9f8b-634c03f46c5e@ideasonboard.com> Content-Language: en-US From: Aradhya Bhatia In-Reply-To: <15b7bfd9-8da4-4cd0-9f8b-634c03f46c5e@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02/11/26 11:46, Tomi Valkeinen wrote: > Hi, > > On 01/11/2026 16:14, Aradhya Bhatia wrote: >> Hi Tomi, >> >> On 29/10/26 10:18, Tomi Valkeinen wrote: >>> tidss_oldi_init() registers a bridge for each OLDI TX in turn. If a >>> later >>> OLDI TX fails, the bridges registered for the earlier ones are not >>> removed. >>> >>> Fix this by calling tidss_oldi_deinit() in the error path. >>> >>> Fixes: 7246e0929945 ("drm/tidss: Add OLDI bridge support") >>> Signed-off-by: Tomi Valkeinen >>> --- >>>   drivers/gpu/drm/tidss/tidss_oldi.c | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/tidss/tidss_oldi.c b/drivers/gpu/drm/ >>> tidss/tidss_oldi.c >>> index 506507e83112..7344d86e1f13 100644 >>> --- a/drivers/gpu/drm/tidss/tidss_oldi.c >>> +++ b/drivers/gpu/drm/tidss/tidss_oldi.c >>> @@ -638,5 +638,6 @@ int tidss_oldi_init(struct tidss_device *tidss) >>>   err_put_node: >>>       of_node_put(child); >>>       of_node_put(oldi_parent); >>> +    tidss_oldi_deinit(tidss); >>>       return ret; >>>   } >>> >> >> Since tidss_probe() (in tidss_drv.c) calls tidss_oldi_init(), it also >> calls tidss_oldi_deinit() in its error exit path. > Yes, but not if tidss_oldi_init() itself fails. > > If we have two OLDI TXes, and the loop in tidss_oldi_init() inits the > first one, then the second one's init fails, the code jumps to > err_put_node. If we don't call tidss_oldi_deinit() there, the first OLDI > TX will not be "deinited". Thanks, I see what you mean. Reviewed-by: Aradhya Bhatia -- Regards Aradhya