From: Nikita Travkin <nikita@trvn.ru>
To: Doug Anderson <dianders@chromium.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
cros-qcom-dts-watchers@chromium.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: acer-aspire1: Enable RTC
Date: Tue, 31 Oct 2023 12:18:08 +0500 [thread overview]
Message-ID: <9157b1f2ffc28f00da4d40b1baedb4b9@trvn.ru> (raw)
In-Reply-To: <CAD=FV=UigovpD_s89j6V7MhCXOVHVVXLRtH3XGEHtcHKbwVgBA@mail.gmail.com>
Doug Anderson писал(а) 31.10.2023 02:55:
> Hi,
>
> On Mon, Oct 30, 2023 at 2:47 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> On 27.10.2023 16:42, Nikita Travkin wrote:
>> > pm6150 has a read-only RTC that can be used to keep the time with some
>> > extra userspace tools. Enable it.
>> >
>> > Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> > ---
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> kinda unsure why it'd ever be disabled
>>
>> Konrad
>
> FWIW we don't use the PMIC RTC in Chrome boards. I can't quite
> remember why, but I _think_ that the power lines aren't hooked up to
> the PMIC to keep power on for the board's lowest power states.
> Instead we use the RTC that's on the EC (Embedded Controller).
>
When it was submitted, I suggested to keep it disabled by default
because of the firmware mess qcom has - the rtc is set to
read-only and if one enables it on cros without allow-set-time;
and validating that qtiseclib doesn't block it too, it would
likely cause issues by taking devices back to 1970s :D
Nikita
> -Doug
next prev parent reply other threads:[~2023-10-31 7:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 14:42 [PATCH 0/3] sc7180-acer-aspire1: Add sound Nikita Travkin
2023-10-27 14:42 ` [PATCH 1/3] arm64: dts: qcom: acer-aspire1: Enable RTC Nikita Travkin
2023-10-30 21:47 ` Konrad Dybcio
2023-10-30 21:55 ` Doug Anderson
2023-10-31 7:18 ` Nikita Travkin [this message]
2023-10-27 14:42 ` [PATCH 2/3] arm64: dts: qcom: acer-aspire1: Correct audio codec definition Nikita Travkin
2023-10-30 21:48 ` Konrad Dybcio
2023-10-31 7:20 ` Nikita Travkin
2023-10-31 10:06 ` Konrad Dybcio
2023-10-31 10:48 ` Nikita Travkin
2023-10-31 10:58 ` Konrad Dybcio
2023-10-27 14:42 ` [PATCH 3/3] arm64: dts: qcom: acer-aspire1: Add sound Nikita Travkin
2023-10-30 21:50 ` Konrad Dybcio
2023-10-30 21:51 ` Konrad Dybcio
2023-10-31 7:26 ` Nikita Travkin
2023-10-31 10:07 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9157b1f2ffc28f00da4d40b1baedb4b9@trvn.ru \
--to=nikita@trvn.ru \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox