From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-108-mta232.mxroute.com (mail-108-mta232.mxroute.com [136.175.108.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62109125C1 for ; Sat, 6 Apr 2024 06:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712385419; cv=none; b=IHxBTtWRKWuYjU05g0PaPBT/mSGWo7Gj8D/rDvEJNgQJoMPeoZuu3NeI5s7ONOtTCHMjgDaZ7kIVJzRQoJJrtEvyM6ephW0Q8bwdtk674SYU6HaisN3w7buGUa3fRS3eAP7wGFxalAjueXxAMiJ1L7BavVC1QLxbILVMJPHYVwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712385419; c=relaxed/simple; bh=OxraREhf6GRED2LQephjdnm0ObJkCkvoK147D6T36ys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ukmN6OvAlVga0/3Yw0/FX8iTEGfQXZdoMgVKKswGQXEc8WTrf49+VkxEilpVVKRhh3KSTJaZqKrVS0xrGAMG4sj4u37rbRzZtmQE3ii7PspG98bgOhWVS0+udKfRIW9HiNml7k2kd12vV2K6k9ewcgXgpGBIjDkSaOAs8U9G0KM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=WPhbq6ZE; arc=none smtp.client-ip=136.175.108.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="WPhbq6ZE" Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta232.mxroute.com (ZoneMTA) with ESMTPSA id 18eb21fcaf10003bea.00f for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 06 Apr 2024 06:36:51 +0000 X-Zone-Loop: bb7656ab1762260b00005043299ae72ae540e35357f8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P6oz8jLcfNyvGaOUeOoCwlqC8Ij6mtZ6/gKuz1gexug=; b=WPhbq6ZEa+mQTnijWaBY6xxs/H cfHYUnpSRs8fOhOb/O4yJffkApW8GbdCsZ9fgpCJBUMa3pysrcREVULO1R/UkyRqIiPc9mObnfXPv YmP7o/tAqB0ayOqkRLxs5fQtXrUia6yJroEUCCB+ckUFpQp8RHDB0YyE7tXXD9rJenqQZDa30Cqkj soLpFl0b5rnHDmjMNbaU+mvK6HOXuMsdAhCIuIT3xhAYVnT6i+9TrIfSP7p+3tjqrOm0eD3oFmOvb FE0z2dqpWXi9w++3zacDwlhzLX9akXx4T0C5yl6+Qkahp/SWJ/+9Q9RvAIcOuf71zbchDNERWMcas kIvWVcdg==; Message-ID: <91621b30-dc6f-49cb-878c-96d39e38d994@luigi311.com> Date: Sat, 6 Apr 2024 00:36:47 -0600 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information To: Pavel Machek Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-12-git@luigi311.com> Content-Language: en-US From: Luis Garcia In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authenticated-Id: git@luigi311.com On 4/3/24 12:46, Pavel Machek wrote: > Hi! > >> Libcamera requires the cropping information for each mode, so >> add this information to the driver. > >> @@ -116,6 +124,9 @@ struct imx258_mode { >> u32 link_freq_index; >> /* Default register values */ >> struct imx258_reg_list reg_list; >> + >> + /* Analog crop rectangle. */ > > No need for "." at the end, as it is not above. > Done >> + struct v4l2_rect crop; >> }; > > If the crop is same in all modes, should we have it in common place? > > Best regards, > Pavel I see the imx219 made a similar change where it was changed from using that .crop format to just setting it in the set_pad_format function so we can do something similar here.