Re: [PATCH 2/3] soc: qcom: stats: Add stats compatible and config for Shikra

[Sneh Mankad <sneh.mankad@oss.qualcomm.com>]

On 06-Jul-26 2:42 PM, Maulik Shah (mkshah) wrote:
> 
> 
> On 7/3/2026 4:43 PM, Sneh Mankad wrote:
>> SoC sleep stats are present in RPM message RAM and subsystem sleep
>> stats are present in SMEM for Shikra.
> 
> minor nit: use RPM MSGRAM term in above line as well.
> 
>>
>> For earlier targets using RPM processor like msm8974, rpm_master_stat.c
>> was used for subsystem sleep stats since those stats were populated in
>> RPM MSGRAM.
>>
> 
> [...]
> 
>> +---------------|----------------------------|---------------------------+
>> | SoC           | subsystem sleep stats      | SoC sleep stats           |
>> |---------------|----------------------------|---------------------------|
>> | msm8974,      | RPM processor MSGRAM       | RPM processor MSGRAM      |
>> | msm8226       | (rpm_master_stat.c)        | (qcom_stats.c)            |
>> |---------------|----------------------------|---------------------------|
>> | sm6350,       | SMEM (DDR)                 | AOP processor MSGRAM      |
>> | sdm845, etc.  | (qcom_stats.c)             | (qcom_stats.c)            |
>> |---------------|----------------------------|---------------------------|
>> | Shikra        | SMEM (DDR)                 | RPM processor MSGRAM      |
>> |               | (qcom_stats.c)             | (qcom_stats.c)            |
>> +---------------|----------------------------|---------------------------+
>>
> 
> [...]
> 
>>
>> Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
> 
> other than minor nit:, looks good,

Sure, will update.

Thanks,
Sneh

> 
> Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> 
> Thanks,
> Maulik