From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FC1C46467 for ; Sun, 15 Jan 2023 14:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231167AbjAOOb7 (ORCPT ); Sun, 15 Jan 2023 09:31:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230501AbjAOOb5 (ORCPT ); Sun, 15 Jan 2023 09:31:57 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D00D0113E8 for ; Sun, 15 Jan 2023 06:31:56 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id ud5so62609968ejc.4 for ; Sun, 15 Jan 2023 06:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ka7RsGQ4vY+og58IhboXaj+SShDOCjiWCr/xxnDLPMk=; b=bVppNKG2N5/nBD4Oj/iy4LGZE8V9y9i2K6RWx7k+vphMDkcXflrAeHP6/ig5syiAaw PeE1M6XZIfFyulr7NEfQGB5V8p1j2clsUae/m+k2lZ27I/qW8jB04m62MMZu1+fGzs4m daoR9ZnEMDSPHzko2DM3VU/VTpQQWjCck90eNclhf86QJjgOgQXkCmTU+GEaoj6KJR0y YnCJM/52pGwqCfRZ4ib2b3NQPsA/cjwzG9SCAZDPT4VvqOfICQJKXvDneZscfkzXzVLv sjTtrAjxK65mtdcrQuCrzsYgQw/ItBGGulk8En/gb1xex+Xng4kNFXNr7+hbpMb0bcqJ WfTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ka7RsGQ4vY+og58IhboXaj+SShDOCjiWCr/xxnDLPMk=; b=GXXEG0AwSyMnMgA8yYH0OATbe16fEWc6AY7OIkJDjRh71p1L2mqQjwxoVi43SOXHp5 Y8Jc7P2icVSY/9XjUOl2ODEuC/NmkOBchZ5b8VVG+D+NoVMl0pBn7cz6tH68bs3JgwGl uE6y1nySd8IHwbLluq8OQfffqPZuFCYOWKZX8l5Mc1EUnSSZojKZqD5qcpI4LeM7bvmd wyM53223gDpPW84Ov9I+Y/QMSCRqmb9KIm/7XwYg4i8P/fBlAiCb1rjNIpXtLc2hMBo4 Imimp61utRfKxb3EgWx1ITBtbjkcnSs93Ri5/qOaHC9onI8sBkt4n9qbUMSTVcb1u3vn Uxdw== X-Gm-Message-State: AFqh2kp+rNoE0RNH/Kjgvbl8ffao8e5HZoi9GhHcKHbVzEXezdo8y6Nu 6NAb2cVal3jloyfsU7a2RUbrRw== X-Google-Smtp-Source: AMrXdXtcYn7Ys87GJP7CGaLmrovhaHQrVYKw4ENs4h80qYIv73jg2OMm+fHdPu2HqrC1CdKIEdORSw== X-Received: by 2002:a17:907:2c61:b0:86e:fccc:bc19 with SMTP id ib1-20020a1709072c6100b0086efcccbc19mr3597731ejc.43.1673793115401; Sun, 15 Jan 2023 06:31:55 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l18-20020a1709060cd200b0084c723a626csm10654904ejh.209.2023.01.15.06.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 06:31:54 -0800 (PST) Message-ID: <91737ee5-f751-9f5e-34fd-0eeae29d7077@linaro.org> Date: Sun, 15 Jan 2023 15:31:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 02/16] dt-bindings: spi: Add bcmbca-hsspi controller support Content-Language: en-US To: William Zhang , Florian Fainelli , Linux SPI List , Broadcom Kernel List Cc: anand.gore@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, joel.peshkin@broadcom.com, jonas.gorski@gmail.com, kursad.oney@broadcom.com, dregan@mail.com, Krzysztof Kozlowski , Mark Brown , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230106200809.330769-1-william.zhang@broadcom.com> <20230106200809.330769-3-william.zhang@broadcom.com> <5dfac2d7-3b4b-9ded-0dde-26b289c604d0@broadcom.com> <99b01e96-3b96-6692-c5e1-87db49295e6d@linaro.org> <49925933-aacc-4f0d-a1ca-e1bd45b05eee@broadcom.com> <32a464f8-6a4b-6777-9775-f17e990e0c6a@gmail.com> <71c2e796-f0fb-90cd-4599-13c9718f41d5@linaro.org> <31644849-dc69-ddfc-a6b6-6ffd37d64d2b@broadcom.com> <0cc43891-405e-418f-01ee-845d680b3a24@linaro.org> <14a48b44-962e-1839-4fbb-1739ba8dbc35@broadcom.com> <3c3955da-6b9f-c994-e345-03bcffa91473@broadcom.com> From: Krzysztof Kozlowski In-Reply-To: <3c3955da-6b9f-c994-e345-03bcffa91473@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/01/2023 04:17, William Zhang wrote: >>> I >>> know there are usage like that but when we have clear knowledge of the >>> IP block with rev info, I think it is much better to have a precise SoC >> >> No, it's not particularly better and you were questioning it just before... >> > Better than using the very old specific chip model number to bind all > other new chips while I have a chance to update the doc now. It will be used to bind them anyway, it's already an ABI. > I guess we > have to agree to disagree. Enough discussion and I will send out v2 next > week. Thanks for the review. > >>> model number and a general revision info in the compatible. As you know >>> they are many usage of IP rev info in the compatible too. >>> brcm,bcm6328-hsspi will stay so it does not break any existing dts >>> reference to that. >> >> Anyway your ship sailed - you already have bindings using SoC versions... As I said here... Best regards, Krzysztof