From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 636D6C77B60 for ; Fri, 31 Mar 2023 20:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231902AbjCaUJt (ORCPT ); Fri, 31 Mar 2023 16:09:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232792AbjCaUJo (ORCPT ); Fri, 31 Mar 2023 16:09:44 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B5AA21AA8 for ; Fri, 31 Mar 2023 13:09:41 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id c29so30410766lfv.3 for ; Fri, 31 Mar 2023 13:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680293379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xw1N8c4NwTk3qWvVTPNQOhGdEVWqHVyp5Ieb2s7Nvq4=; b=w/7NOVgTcl9X9jBc2UOGQaQRJ9osCEI9IGgP/jcTr0DoRie/kKsR/Ck8H5W8on02+3 YalQVrSdXbWyReX8wqMByleypEO9uuCFBpj/75cJO8GW7f4Ih8aqzeTyyE/8ZNl6oQRj cB8WovAhdLXFtITD7oZyHq+goJWAT6vFlXtqmtEHMUXLtsGNk5IIUL8u0VX66Rf2vMrE C6lWRAfBvszRuila67dLFSKHnbIc0NCv8ozDcYXQP678STS4oDwoL8zhivdljT4RQGkL nXPDDon0wTDqHumCcjnwRoEGbmYItGrGBd8UuEY4lKmihzQ3NEmjuhiEc0Cmd+3ThmJ/ AzZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680293379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xw1N8c4NwTk3qWvVTPNQOhGdEVWqHVyp5Ieb2s7Nvq4=; b=w2lH6E7Xsh3+Hx1WUo1mgLI/qWPxfQpXJTI2+nOrL8BYze19UmEVzcGsuc23ZtpaHy vtxB4DpVOubISQj53jK2q5CNKEbwZO5wj9ZgR1xh9DEHK07eR+mIHao4t0qRXAaZeSdQ XRzN7aczca/H5Vx67MnUubeNmsyLE/K7Io2G9jK99IZ4+Tu4NEzEBtbrg31ugwFVmrnV Q697IzPhc3HogUlRZ3MIsQMi20BYEE+upjVaJQAR9Gz7FW3dlOTNFQH2lIjZxF6h7DY/ 4rEQZ1o7QukbQaO2Rv9lGx+WzcLSozQX43L6cY/K10M8TwTOeqlKVTyYKU92AlxcwmwS Iwsg== X-Gm-Message-State: AAQBX9eePIxsRdMHllV2O20fMs3JKE155J5nzP6Dm/9aRDQevFjzmxpg zcxGWOI4yI4FWTMUz78X6pATmg== X-Google-Smtp-Source: AKy350bylfF6KhOVFpj5VtEzS0A2hRudKCGcRrM6eTpMIQbSHzLZ0ojtju+5tmOdPRFro4hPdY7bYQ== X-Received: by 2002:a19:ac09:0:b0:4dd:a025:d8e with SMTP id g9-20020a19ac09000000b004dda0250d8emr7668551lfc.47.1680293379631; Fri, 31 Mar 2023 13:09:39 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id c25-20020ac244b9000000b004e9c983a007sm502364lfm.289.2023.03.31.13.09.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 13:09:39 -0700 (PDT) Message-ID: <91874e63-553f-ced5-ce32-309ac2ebf6e5@linaro.org> Date: Fri, 31 Mar 2023 22:09:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 1/9] media: dt-bindings: Add bindings for JH7110 Camera Subsystem Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Maxime Ripard , Rob Herring , Krzysztof Kozlowski , Robert Foss , Todor Tomov , Philipp Zabel , Laurent Pinchart , Ezequiel Garcia , Hans Verkuil , Eugen Hristev Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230331121826.96973-1-jack.zhu@starfivetech.com> <20230331121826.96973-2-jack.zhu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230331121826.96973-2-jack.zhu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2023 14:18, Jack Zhu wrote: > Add the bindings documentation for Starfive JH7110 Camera Subsystem > which is used for handing image sensor data. > > Signed-off-by: Jack Zhu > --- > .../bindings/media/starfive,jh7110-camss.yaml | 159 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 166 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > new file mode 100644 > index 000000000000..0235c70e7793 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > @@ -0,0 +1,159 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive SoC CAMSS ISP > + > +maintainers: > + - Jack Zhu > + - Changhuang Liang > + > +description: > + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It > + consists of a VIN controller (Video In Controller, a top-level control until) > + and an ISP. > + > +properties: > + compatible: > + const: starfive,jh7110-camss > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: syscon > + - const: isp > + > + clocks: > + maxItems: 7 > + > + clock-names: > + items: > + - const: apb_func > + - const: wrapper_clk_c > + - const: dvp_inv > + - const: axiwr > + - const: mipi_rx0_pxl > + - const: ispcore_2x > + - const: isp_axi > + > + resets: > + maxItems: 6 > + > + reset-names: > + items: > + - const: wrapper_p > + - const: wrapper_c > + - const: axird > + - const: axiwr > + - const: isp_top_n > + - const: isp_top_axi > + > + power-domains: > + items: > + - description: JH7110 ISP Power Domain Switch Controller. > + > + interrupts: > + maxItems: 4 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false > + description: > + Input port for receiving DVP data. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# I don't think we use video-interfaces with port. Are you sure this works fine? Please extend the example with appropriate properties to check... > + unevaluatedProperties: false > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false Same concerns here. Best regards, Krzysztof