From: Florian Fainelli <f.fainelli@gmail.com>
To: George McCollister <george.mccollister@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] dsa: add support for Arrow XRS700x tag trailer
Date: Mon, 23 Nov 2020 14:18:09 -0800 [thread overview]
Message-ID: <919273d3-6aa6-33b3-a8fe-d59ace9b1342@gmail.com> (raw)
In-Reply-To: <20201120181627.21382-2-george.mccollister@gmail.com>
On 11/20/2020 10:16 AM, George McCollister wrote:
> Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
> is modeled on tag_trailer.c which works in a similar way.
>
> Signed-off-by: George McCollister <george.mccollister@gmail.com>
One question below:
[snip]
> + if (pskb_trim_rcsum(skb, skb->len - 1))
> + return NULL;
> +
> + /* Frame is forwarded by hardware, don't forward in software. */
> + skb->offload_fwd_mark = 1;
Given the switch does not give you a forwarding reason, I suppose this
is fine, but do you possibly have to qualify this against different
source MAC addresses?
--
Florian
next prev parent reply other threads:[~2020-11-23 22:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 18:16 [PATCH net-next 0/3] Arrow SpeedChips XRS700x DSA Driver George McCollister
2020-11-20 18:16 ` [PATCH net-next 1/3] dsa: add support for Arrow XRS700x tag trailer George McCollister
2020-11-20 18:58 ` Andrew Lunn
2020-11-20 20:14 ` George McCollister
2020-11-23 22:18 ` Florian Fainelli [this message]
2020-11-24 20:26 ` George McCollister
2020-11-20 18:16 ` [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver George McCollister
2020-11-20 19:33 ` Andrew Lunn
2020-11-20 22:55 ` George McCollister
2020-11-20 23:24 ` Andrew Lunn
2020-11-23 20:43 ` George McCollister
2020-11-23 21:55 ` Andrew Lunn
2020-11-23 22:09 ` Andrew Lunn
2020-11-23 22:23 ` George McCollister
2020-11-22 23:39 ` Vladimir Oltean
2020-11-23 21:22 ` George McCollister
2020-11-20 18:16 ` [PATCH net-next 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches George McCollister
2020-11-23 22:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=919273d3-6aa6-33b3-a8fe-d59ace9b1342@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=george.mccollister@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).