From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, jun.li@nxp.com,
alexander.stein@ew.tq-group.com, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: imx8mq-usb: improve some tuning properties
Date: Tue, 29 Apr 2025 09:33:02 +0200 [thread overview]
Message-ID: <91d5c505-3fa6-42e3-be24-3b35c366d007@kernel.org> (raw)
In-Reply-To: <20250428082002.gd275e2rqollatcj@hippo>
On 28/04/2025 10:20, Xu Yang wrote:
>>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + enum:
>>> + - fsl,imx8mq-usb-phy
>>> + - fsl,imx8mp-usb-phy
>>> + then:
>>> + properties:
>>> + fsl,phy-tx-vref-tune-percent:
>>> + minimum: -6
>>> + maximum: 24
>>
>> That's ABI break with vague reason "some pain".
>
> For these four properties, no DTS files use them now. So that's why I'm
> going to improve them. I think no ABI break here.
And which out of tree users did you investigate? Read what is ABI before
you keep insisting that it is not an ABI break.
You change already approved and released interface, right? Or not?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-29 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 9:46 [PATCH 1/2] dt-bindings: phy: imx8mq-usb: improve some tuning properties Xu Yang
2025-04-23 9:46 ` [PATCH 2/2] phy: fsl-imx8mq-usb: improve some tuning parameters and support i.MX95 tuning Xu Yang
2025-04-28 7:59 ` [PATCH 1/2] dt-bindings: phy: imx8mq-usb: improve some tuning properties Krzysztof Kozlowski
2025-04-28 8:20 ` Xu Yang
2025-04-29 7:33 ` Krzysztof Kozlowski [this message]
2025-04-29 9:27 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91d5c505-3fa6-42e3-be24-3b35c366d007@kernel.org \
--to=krzk@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox