From: rojay@codeaurora.org
To: Matthias Kaehlcke <mka@chromium.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
akashast@codeaurora.org, msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V2 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes
Date: Mon, 22 Mar 2021 16:32:27 +0530 [thread overview]
Message-ID: <91db2ee226ceb15a255bf7312a7216c1@codeaurora.org> (raw)
In-Reply-To: <YFOKQKlI3MjMouEA@google.com>
On 2021-03-18 22:43, Matthias Kaehlcke wrote:
> On Thu, Mar 18, 2021 at 04:40:08PM +0530, Roja Rani Yarubandi wrote:
>> ICC core and platforms drivers supports sync_state feature, which
>> ensures that the default ICC BW votes from the bootloader is not
>> removed until all it's consumers are probes.
>>
>> The proxy votes were needed in case other QUP child drivers
>> I2C, SPI probes before UART, they can turn off the QUP-CORE clock
>> which is shared resources for all QUP driver, this causes unclocked
>> access to HW from earlycon.
>>
>> Given above support from ICC there is no longer need to maintain
>> proxy votes on QUP-CORE ICC node from QUP wrapper driver for early
>> console usecase, the default votes won't be removed until real
>> console is probed.
>>
>> Signed-off-by: Roja Rani Yarubandi <rojay@codeaurora.org>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>
> I suggest to mention that this is essentially a revert of commit
> 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix
> earlycon crash"). This makes the life of reviewers easier and it's
> also good to have the reference in the git history.
>
Ok.
> You could also mention commit 7d3b0b0d8184 ("interconnect: qcom:
> Use icc_sync_state") in the intro.
>
Ok.
> I tried to test by first reproducing the original issue without
> 'sync_state' in the ICC, but wasn't successful, probably something
> changed in the boot/ICC timing in the meantime ¯\_(ツ)_/¯.
>
Need to remove runtime auto suspend support from SPI/I2C as well, as it
was
masking the issue by delaying to turn off the resources by 250ms.
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2021-03-22 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 11:10 [PATCH V2 0/2] Separate out earlycon Roja Rani Yarubandi
2021-03-18 11:10 ` [PATCH V2 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes Roja Rani Yarubandi
2021-03-18 17:13 ` Matthias Kaehlcke
2021-03-22 11:02 ` rojay [this message]
2021-03-18 11:10 ` [PATCH V2 2/2] arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path Roja Rani Yarubandi
2021-03-18 17:17 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91db2ee226ceb15a255bf7312a7216c1@codeaurora.org \
--to=rojay@codeaurora.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).