From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 11/11] dt-bindings: sound: cirrus: cs530x: Add additional cs530x family variants
Date: Thu, 16 Oct 2025 21:15:13 +0200 [thread overview]
Message-ID: <9226bc99-13a6-44af-937f-b85f8c26da2c@kernel.org> (raw)
In-Reply-To: <20251016165835.143832-12-vitalyr@opensource.cirrus.com>
On 16/10/2025 18:58, Vitaly Rodionov wrote:
> This patch adds additional cs530x family variants - DAC and CODEC parts.
>
> Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
No improvements in the subject. Please read carefully my comments again.
> ---
> Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> index 9582eb8eb418..90a5cea0632d 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> @@ -22,6 +22,10 @@ properties:
> - cirrus,cs5302
> - cirrus,cs5304
> - cirrus,cs5308
> + - cirrus,cs4282
> + - cirrus,cs4302
> + - cirrus,cs4304
> + - cirrus,cs4308
No improvements here, either.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-16 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 16:58 [PATCH v3 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 01/11] ASoC: cs530x: Correct log message with expected variable Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 02/11] ASoC: cs530x: Update the copyright headers Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 03/11] ASoC: cs530x: Sort #include directives and tidy up whitespaces Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 04/11] ASoC: cs530x: Remove unused struct members and constants Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 05/11] ASoC: cs530x: Correct constant naming Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 06/11] ASoC: cs530x: Add CODEC and DAC support Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 07/11] ASoC: cs530x: Check the DEVID matches the devtype Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 08/11] ASoC: cs530x: Correct MCLK reference frequency values Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 09/11] ASoC: cs530x: Rename i2c related structures Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 10/11] ASoC: cs530x: Add SPI bus support for cs530x parts Vitaly Rodionov
2025-10-16 16:58 ` [PATCH v3 11/11] dt-bindings: sound: cirrus: cs530x: Add additional cs530x family variants Vitaly Rodionov
2025-10-16 19:15 ` Krzysztof Kozlowski [this message]
2025-10-16 19:16 ` [PATCH v3 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9226bc99-13a6-44af-937f-b85f8c26da2c@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=vitalyr@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).