From: Tomasz Figa <tomasz.figa@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: kgene.kim@samsung.com, t.figa@samsung.com,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk
Subject: Re: [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq
Date: Sun, 10 Nov 2013 19:12:18 +0100 [thread overview]
Message-ID: <9228109.fILkd0ZUhT@flatron> (raw)
In-Reply-To: <1383530161-24080-2-git-send-email-cw00.choi@samsung.com>
Hi Chanwoo,
Please add a patch description. Even if trivial, it is good to have one.
On Monday 04 of November 2013 10:55:59 Chanwoo Choi wrote:
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4212.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 6f34d7f..3081bae 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -56,4 +56,10 @@
> <0x5 0 &gic 1 12 0>;
> };
> };
> +
> + pmu {
> + compatible = "arm,cortex-a9-pmu";
> + interrupt-parent = <&combiner>;
> + interrupts = <2 2>, <3 2>;
> + };
I believe it would be better to put this in exynos4x12.dtsi, specifying
all four interrupts for possible four cores in Exynos4412. It would be
fine, since the interrupt layout is the same on all Exynos4x12 SoCs, just
some interrupts are not used.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-11-10 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 1:55 [PATCHv3 0/3] ARM: dts: exynos: Add missing dt data to bring up kernel featurea Chanwoo Choi
2013-11-04 1:55 ` [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq Chanwoo Choi
2013-11-10 18:12 ` Tomasz Figa [this message]
2013-11-04 1:56 ` [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer Chanwoo Choi
[not found] ` <1383530161-24080-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-10 18:15 ` Tomasz Figa
2013-11-04 1:56 ` [PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12 Chanwoo Choi
2013-11-10 18:16 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9228109.fILkd0ZUhT@flatron \
--to=tomasz.figa@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).