From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq Date: Sun, 10 Nov 2013 19:12:18 +0100 Message-ID: <9228109.fILkd0ZUhT@flatron> References: <1383530161-24080-1-git-send-email-cw00.choi@samsung.com> <1383530161-24080-2-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1383530161-24080-2-git-send-email-cw00.choi@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Chanwoo Choi Cc: kgene.kim@samsung.com, t.figa@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk List-Id: devicetree@vger.kernel.org Hi Chanwoo, Please add a patch description. Even if trivial, it is good to have one. On Monday 04 of November 2013 10:55:59 Chanwoo Choi wrote: > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4212.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi > index 6f34d7f..3081bae 100644 > --- a/arch/arm/boot/dts/exynos4212.dtsi > +++ b/arch/arm/boot/dts/exynos4212.dtsi > @@ -56,4 +56,10 @@ > <0x5 0 &gic 1 12 0>; > }; > }; > + > + pmu { > + compatible = "arm,cortex-a9-pmu"; > + interrupt-parent = <&combiner>; > + interrupts = <2 2>, <3 2>; > + }; I believe it would be better to put this in exynos4x12.dtsi, specifying all four interrupts for possible four cores in Exynos4412. It would be fine, since the interrupt layout is the same on all Exynos4x12 SoCs, just some interrupts are not used. Best regards, Tomasz