From: Krzysztof Kozlowski <krzk@kernel.org>
To: James Hilliard <james.hilliard1@gmail.com>, linux-gpio@vger.kernel.org
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Stein <linux@ew.tq-group.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: gpio: add gpio-aggregator binding
Date: Wed, 11 Feb 2026 09:19:49 +0100 [thread overview]
Message-ID: <92359c6d-06ac-4f8d-baa5-6fa45a536455@kernel.org> (raw)
In-Reply-To: <338e6575-ec44-4179-94af-9086a7ca79ac@kernel.org>
On 11/02/2026 09:17, Krzysztof Kozlowski wrote:
> On 11/02/2026 09:13, James Hilliard wrote:
>> Document the gpio-aggregator virtual GPIO controller with a dedicated
>> schema and compatible string.
>>
>> Also extend the GPIO AGGREGATOR MAINTAINERS entry to cover the new
>> binding file.
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
> </form letter>
>
First thing which was missing (I did not even check the rest in such
case): missing rationale for this patch, missing hardware description.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-11 8:19 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 8:13 [PATCH v2 1/2] dt-bindings: gpio: add gpio-aggregator binding James Hilliard
2026-02-11 8:13 ` [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible James Hilliard
2026-02-11 9:47 ` Bartosz Golaszewski
2026-02-11 9:50 ` Geert Uytterhoeven
2026-02-11 10:38 ` Bartosz Golaszewski
2026-02-11 10:48 ` Krzysztof Kozlowski
2026-02-11 11:00 ` Bartosz Golaszewski
2026-02-11 10:13 ` Krzysztof Kozlowski
2026-02-11 10:36 ` Bartosz Golaszewski
2026-02-11 10:42 ` Krzysztof Kozlowski
2026-02-11 10:44 ` Krzysztof Kozlowski
2026-02-11 21:47 ` Rob Herring
2026-02-11 21:49 ` James Hilliard
2026-02-12 7:18 ` Krzysztof Kozlowski
2026-02-12 19:16 ` James Hilliard
2026-02-13 7:31 ` Krzysztof Kozlowski
2026-02-13 8:02 ` James Hilliard
2026-02-13 8:21 ` Krzysztof Kozlowski
2026-02-13 8:29 ` Herve Codina
2026-02-13 8:49 ` Krzysztof Kozlowski
2026-02-13 23:03 ` James Hilliard
2026-02-11 8:17 ` [PATCH v2 1/2] dt-bindings: gpio: add gpio-aggregator binding Krzysztof Kozlowski
2026-02-11 8:19 ` Krzysztof Kozlowski [this message]
2026-02-11 8:28 ` James Hilliard
2026-02-11 8:44 ` Krzysztof Kozlowski
2026-02-11 17:01 ` James Hilliard
2026-02-12 14:49 ` Geert Uytterhoeven
2026-02-12 16:53 ` James Hilliard
2026-02-12 19:54 ` Rob Herring
2026-02-12 21:22 ` James Hilliard
2026-02-13 8:24 ` Geert Uytterhoeven
2026-02-13 18:34 ` James Hilliard
2026-02-16 9:05 ` Geert Uytterhoeven
2026-02-19 18:00 ` Linus Walleij
2026-02-19 18:29 ` Rob Herring
2026-02-19 22:14 ` Linus Walleij
2026-02-19 22:28 ` James Hilliard
2026-02-19 23:00 ` Linus Walleij
2026-02-19 23:06 ` James Hilliard
2026-02-19 23:12 ` Rob Herring
2026-02-20 4:57 ` James Hilliard
2026-02-20 8:24 ` Linus Walleij
2026-02-20 11:33 ` Bartosz Golaszewski
2026-02-13 14:34 ` Rob Herring
2026-02-13 22:49 ` James Hilliard
2026-02-16 9:10 ` Geert Uytterhoeven
2026-02-19 17:57 ` Linus Walleij
2026-02-20 8:17 ` Herve Codina
2026-02-20 8:35 ` Linus Walleij
2026-02-20 9:15 ` Geert Uytterhoeven
2026-02-20 13:07 ` Herve Codina
2026-02-20 13:28 ` Geert Uytterhoeven
2026-02-11 8:25 ` Geert Uytterhoeven
2026-02-11 8:34 ` James Hilliard
2026-02-11 9:47 ` Geert Uytterhoeven
2026-02-11 9:57 ` Herve Codina
2026-02-11 10:01 ` Geert Uytterhoeven
2026-02-11 10:58 ` Herve Codina
2026-02-11 13:30 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92359c6d-06ac-4f8d-baa5-6fa45a536455@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=james.hilliard1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox