From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jisheng Zhang <jszhang@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add T-HEAD TH1520 USB controller
Date: Sat, 30 Sep 2023 17:52:18 +0200 [thread overview]
Message-ID: <924f8334-f4d3-4c41-b8c2-08f1a15c7fa0@linaro.org> (raw)
In-Reply-To: <08760c32-fee0-4681-92f2-56003cadad0a@linaro.org>
On 28/09/2023 07:21, Krzysztof Kozlowski wrote:
> Drop stray blank line
>
>> + usb {
>> + compatible = "thead,th1520-usb";
>
> Use 4 spaces for example indentation.
>
>> + reg = <0xec03f000 0x1000>;
>> + clocks = <&clk 1>,
>> + <&clk 2>,
>> + <&clk 3>,
>> + <&clk 4>;
>> + clock-names = "ref", "bus_early", "phy", "suspend";
>> + ranges;
>
> Are you sure you do not have W=1 warnings in DTS?
Ah, as we can see from bot's report, you have warnings. Please test your
DTS with dtbs_check W=1 and fix all (*ALL*) warnings.
This looks like missing proper addresses in the ranges.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-30 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 16:42 [PATCH 0/2] usb: dwc3: add driver for T-HEAD TH1520 SoC Jisheng Zhang
2023-09-27 16:42 ` [PATCH 1/2] dt-bindings: usb: Add T-HEAD TH1520 USB controller Jisheng Zhang
2023-09-27 20:00 ` Samuel Holland
2023-10-04 16:32 ` Jisheng Zhang
2023-09-28 5:21 ` Krzysztof Kozlowski
2023-09-30 15:52 ` Krzysztof Kozlowski [this message]
2023-09-28 14:47 ` Rob Herring
2023-09-27 16:42 ` [PATCH 2/2] usb: dwc3: add T-HEAD TH1520 usb driver Jisheng Zhang
2023-09-27 20:06 ` Samuel Holland
2023-09-28 5:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=924f8334-f4d3-4c41-b8c2-08f1a15c7fa0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).