From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: dt-bindings: qcom,sdm845-refgen-regulator: Document IPQ9650
Date: Fri, 5 Jun 2026 10:03:00 +0200 [thread overview]
Message-ID: <926487d1-d949-4516-b906-892d46cb956c@kernel.org> (raw)
In-Reply-To: <d24238d5-7b71-40e6-b6dd-c2f1aa150d77@oss.qualcomm.com>
On 05/06/2026 08:51, Kathiravan Thirumoorthy wrote:
>>>
>>> + clocks:
>>> + items:
>>> + - description: Core reference clock
>>> + - description: AHB interface clock
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: core
>>> + - const: hclk
>> You just added clocks to each variant, which is not explained in commit
>> msg. And it would be a separate commit anyway. Probably you wanted to
>> add proper constraints (:false).
>
> Ack, will make the change to define the clock and clock-names only for
> IPQ9650 compatible under the allOf block.
No, That;s not what I said. That definition is fine, but you miss
constraints. See example-schema.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-05 8:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 9:21 [PATCH 0/2] Add support for the REFGEN in the IPQ9650 SoC Kathiravan Thirumoorthy
2026-06-02 9:21 ` [PATCH 1/2] regulator: dt-bindings: qcom,sdm845-refgen-regulator: Document IPQ9650 Kathiravan Thirumoorthy
2026-06-02 9:29 ` sashiko-bot
2026-06-04 15:12 ` Krzysztof Kozlowski
2026-06-05 6:51 ` Kathiravan Thirumoorthy
2026-06-05 8:03 ` Krzysztof Kozlowski [this message]
2026-06-05 8:13 ` Kathiravan Thirumoorthy
2026-06-02 9:22 ` [PATCH 2/2] regulator: qcom-refgen: add support for the IPQ9650 SoC Kathiravan Thirumoorthy
2026-06-02 9:38 ` sashiko-bot
2026-06-03 9:12 ` Kathiravan Thirumoorthy
2026-06-03 13:17 ` Dmitry Baryshkov
2026-06-04 11:37 ` Kathiravan Thirumoorthy
2026-06-07 19:42 ` Dmitry Baryshkov
2026-06-09 13:48 ` Konrad Dybcio
2026-06-10 9:49 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=926487d1-d949-4516-b906-892d46cb956c@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox