From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
rafael@kernel.org, daniel.lezcano@linaro.org, nm@ti.com,
sboyd@kernel.org, mka@chromium.org, dianders@chromium.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 4/4] Documentation: EM: Describe new registration method using DT
Date: Thu, 24 Feb 2022 09:39:52 +0000 [thread overview]
Message-ID: <927bb145-abf8-a15a-506f-0f060384d096@arm.com> (raw)
In-Reply-To: <20220224093717.3vsi4t26zcmoh2ra@vireshk-i7>
On 2/24/22 09:37, Viresh Kumar wrote:
> On 24-02-22, 09:25, Lukasz Luba wrote:
>> Our partners had a lot of issues with EM+EAS, because they were not
>> aware of the internals of EM and limitations.
>>
>> We've started to name two types of EM: 'advanced' and 'simple'.
>> The 'simple' is the one which causes issues. Now when we contact with
>> partners we ask if they use 'simple' EM and see some issues in EAS.
>> This is a needed clarification and naming convention that we use.
>>
>> Here the paragraph name is stressing the fact explicitly that
>> from today we have the option to provide real power measurements using
>> DT and it will be the 'advanced' EM.
>
> I understand the background now, and since I am part of the same
> community I can appreciate that. But being a maintainer, I have to say
> that when we look at something from Upstream's point of view, we may
> have to neglect/ignore the terminology used in downstream.
I understand your upstream point of view.
>
> From what I can see, there is no advancement here, as of now. This is
> a very small change where we are getting pre-evaluated power values
> from DT, instead of calculating them at runtime. The data may be more
> correct, but the EM doesn't get advanced because of that. And so using
> such terminology is only going to harm further. If EM gets a
> "advanced" algorithm later on, which can improve things, then yes we
> can call it advanced, but for now there is nothing.
>
Fair enough, I'll drop this word from the paragraph name.
prev parent reply other threads:[~2022-02-24 9:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 8:11 [PATCH v3 0/4] Introduce "opp-microwatt" and 'advanced' Energy Model from DT Lukasz Luba
2022-02-24 8:11 ` [PATCH v3 1/4] dt-bindings: opp: Add "opp-microwatt" entry in the OPP Lukasz Luba
2022-02-24 9:01 ` Viresh Kumar
2022-02-24 9:14 ` Lukasz Luba
2022-02-24 8:11 ` [PATCH v3 2/4] OPP: Add "opp-microwatt" supporting code Lukasz Luba
2022-02-24 9:03 ` Viresh Kumar
2022-02-24 9:34 ` Lukasz Luba
2022-02-24 9:14 ` Viresh Kumar
2022-02-24 9:33 ` Lukasz Luba
2022-02-24 8:11 ` [PATCH v3 3/4] OPP: Add support of "opp-microwatt" for advanced EM registration Lukasz Luba
2022-02-24 9:13 ` Viresh Kumar
2022-02-24 9:33 ` Lukasz Luba
2022-02-24 9:42 ` Viresh Kumar
2022-02-24 9:43 ` Lukasz Luba
2022-02-24 8:11 ` [PATCH v3 4/4] Documentation: EM: Describe new registration method using DT Lukasz Luba
2022-02-24 9:15 ` Viresh Kumar
2022-02-24 9:25 ` Lukasz Luba
2022-02-24 9:37 ` Viresh Kumar
2022-02-24 9:39 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927bb145-abf8-a15a-506f-0f060384d096@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).