* [PATCH 0/2] Add common RDP dtsi file for ipq5018 @ 2023-07-20 7:29 Hariharan K 2023-07-20 7:29 ` [PATCH 1/2] dt-bindings: arm: qcom: Update the compatible Hariharan K 2023-07-20 7:29 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: Add common RDP dtsi file Hariharan K 0 siblings, 2 replies; 5+ messages in thread From: Hariharan K @ 2023-07-20 7:29 UTC (permalink / raw) To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel Cc: quic_srichara, quic_sjaganat, quic_kathirav, quic_arajkuma, quic_anusha Some interfaces are common across RDPs. Move the common nodes to ipq5018-rdp-common.dtsi. Also update the compatible in device tree binding to use model names instead of rdp numbers. This series is based on the below series, https://lore.kernel.org/lkml/20230616101749.2083 974-1-quic_srichara@quicinc.com/ Hariharan K (2): dt-bindings: arm: qcom: Update the compatible arm64: dts: qcom: ipq5018: Add common RDP dtsi file .../devicetree/bindings/arm/qcom.yaml | 4 +-- .../boot/dts/qcom/ipq5018-rdp-common.dtsi | 35 +++++++++++++++++++ .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 30 +++------------- 3 files changed, 41 insertions(+), 28 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp-common.dtsi -- 2.17.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] dt-bindings: arm: qcom: Update the compatible 2023-07-20 7:29 [PATCH 0/2] Add common RDP dtsi file for ipq5018 Hariharan K @ 2023-07-20 7:29 ` Hariharan K 2023-07-20 8:42 ` Krzysztof Kozlowski 2023-07-20 7:29 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: Add common RDP dtsi file Hariharan K 1 sibling, 1 reply; 5+ messages in thread From: Hariharan K @ 2023-07-20 7:29 UTC (permalink / raw) To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel Cc: quic_srichara, quic_sjaganat, quic_kathirav, quic_arajkuma, quic_anusha Update the compatible in device tree binding to use model names instead of rdp numbers for IPQ5018 platform. Signed-off-by: Hariharan K <quic_harihk@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index e94ce1e26fbf..922feb912594 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -97,6 +97,7 @@ description: | ap-mi01.3 ap-mi01.6 ap-mi01.9 + ap-mp03.5-c2 cdp cp01-c1 dragonboard @@ -105,7 +106,6 @@ description: | hk10-c2 idp liquid - rdp432-c2 mtp qrd rb2 @@ -343,7 +343,7 @@ properties: - items: - enum: - - qcom,ipq5018-rdp432-c2 + - qcom,ipq5018-ap-mp03.5-c2 - const: qcom,ipq5018 - items: -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: Update the compatible 2023-07-20 7:29 ` [PATCH 1/2] dt-bindings: arm: qcom: Update the compatible Hariharan K @ 2023-07-20 8:42 ` Krzysztof Kozlowski 2023-07-20 11:04 ` Hariharan K 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2023-07-20 8:42 UTC (permalink / raw) To: Hariharan K, agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel Cc: quic_srichara, quic_sjaganat, quic_kathirav, quic_arajkuma, quic_anusha On 20/07/2023 09:29, Hariharan K wrote: > Update the compatible in device tree binding to > use model names instead of rdp numbers for IPQ5018 > platform. > > Signed-off-by: Hariharan K <quic_harihk@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index e94ce1e26fbf..922feb912594 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -97,6 +97,7 @@ description: | > ap-mi01.3 > ap-mi01.6 > ap-mi01.9 > + ap-mp03.5-c2 > cdp > cp01-c1 > dragonboard > @@ -105,7 +106,6 @@ description: | > hk10-c2 > idp > liquid > - rdp432-c2 > mtp > qrd > rb2 > @@ -343,7 +343,7 @@ properties: > > - items: > - enum: > - - qcom,ipq5018-rdp432-c2 There is no such compatible. Don't send patches with wrong names and before they got merged send a follow up. Fix the original submission. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: Update the compatible 2023-07-20 8:42 ` Krzysztof Kozlowski @ 2023-07-20 11:04 ` Hariharan K 0 siblings, 0 replies; 5+ messages in thread From: Hariharan K @ 2023-07-20 11:04 UTC (permalink / raw) To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel Cc: quic_srichara, quic_sjaganat, quic_kathirav, quic_arajkuma, quic_anusha On 7/20/2023 2:12 PM, Krzysztof Kozlowski wrote: > On 20/07/2023 09:29, Hariharan K wrote: >> Update the compatible in device tree binding to >> use model names instead of rdp numbers for IPQ5018 >> platform. >> >> Signed-off-by: Hariharan K <quic_harihk@quicinc.com> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index e94ce1e26fbf..922feb912594 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -97,6 +97,7 @@ description: | >> ap-mi01.3 >> ap-mi01.6 >> ap-mi01.9 >> + ap-mp03.5-c2 >> cdp >> cp01-c1 >> dragonboard >> @@ -105,7 +106,6 @@ description: | >> hk10-c2 >> idp >> liquid >> - rdp432-c2 >> mtp >> qrd >> rb2 >> @@ -343,7 +343,7 @@ properties: >> >> - items: >> - enum: >> - - qcom,ipq5018-rdp432-c2 > > > There is no such compatible. Don't send patches with wrong names and > before they got merged send a follow up. > > Fix the original submission. Sorry, this patch is in-correct. Names used in the original submission are the right ones. Will drop this patch and also fix it in other patches that i have posted. Best regards, Hariharan K > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: ipq5018: Add common RDP dtsi file 2023-07-20 7:29 [PATCH 0/2] Add common RDP dtsi file for ipq5018 Hariharan K 2023-07-20 7:29 ` [PATCH 1/2] dt-bindings: arm: qcom: Update the compatible Hariharan K @ 2023-07-20 7:29 ` Hariharan K 1 sibling, 0 replies; 5+ messages in thread From: Hariharan K @ 2023-07-20 7:29 UTC (permalink / raw) To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel Cc: quic_srichara, quic_sjaganat, quic_kathirav, quic_arajkuma, quic_anusha Add a dtsi file to include interfaces that are common across RDPs. Signed-off-by: Hariharan K <quic_harihk@quicinc.com> --- .../boot/dts/qcom/ipq5018-rdp-common.dtsi | 35 +++++++++++++++++++ .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 30 +++------------- 2 files changed, 39 insertions(+), 26 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp-common.dtsi diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5018-rdp-common.dtsi new file mode 100644 index 000000000000..c288e508c8f6 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp-common.dtsi @@ -0,0 +1,35 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) +/* + * IPQ5018 RDP board common device tree source + * + * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved. + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. + */ + +/dts-v1/; + +#include "ipq5018.dtsi" + +/ { + aliases { + serial0 = &blsp1_uart1; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +&blsp1_uart1 { + pinctrl-0 = <&uart1_pins>; + pinctrl-names = "default"; + status = "okay"; +}; + +&sleep_clk { + clock-frequency = <32000>; +}; + +&xo_board_clk { + clock-frequency = <24000000>; +}; diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts index e636a1cb9b77..90b6a98471f5 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts @@ -1,31 +1,17 @@ // SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause /* - * IPQ5018 MP03.1-C2 board device tree source + * IPQ5018 MP03.5-C2 board device tree source * * Copyright (c) 2023 The Linux Foundation. All rights reserved. */ /dts-v1/; -#include "ipq5018.dtsi" +#include "ipq5018-rdp-common.dtsi" / { - model = "Qualcomm Technologies, Inc. IPQ5018/AP-RDP432.1-C2"; - compatible = "qcom,ipq5018-rdp432-c2", "qcom,ipq5018"; - - aliases { - serial0 = &blsp1_uart1; - }; - - chosen { - stdout-path = "serial0:115200n8"; - }; -}; - -&blsp1_uart1 { - pinctrl-0 = <&uart1_pins>; - pinctrl-names = "default"; - status = "okay"; + model = "Qualcomm Technologies, Inc. IPQ5018/AP-MP03.5-C2"; + compatible = "qcom,ipq5018-ap-mp03.5-c2", "qcom,ipq5018"; }; &sdhc_1 { @@ -38,10 +24,6 @@ status = "okay"; }; -&sleep_clk { - clock-frequency = <32000>; -}; - &tlmm { sdc_default_state: sdc-default-state { clk-pins { @@ -66,7 +48,3 @@ }; }; }; - -&xo_board_clk { - clock-frequency = <24000000>; -}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-20 11:05 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-20 7:29 [PATCH 0/2] Add common RDP dtsi file for ipq5018 Hariharan K 2023-07-20 7:29 ` [PATCH 1/2] dt-bindings: arm: qcom: Update the compatible Hariharan K 2023-07-20 8:42 ` Krzysztof Kozlowski 2023-07-20 11:04 ` Hariharan K 2023-07-20 7:29 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: Add common RDP dtsi file Hariharan K
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).