From: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>
To: Marek Vasut <marex@denx.de>, Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lionel Debieve" <lionel.debieve@foss.st.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Yang Yingliang" <yangyingliang@huawei.com>
Subject: Re: [PATCH 2/4] hwrng: stm32 - implement support for STM32MP25x platforms
Date: Fri, 11 Oct 2024 11:55:59 +0200 [thread overview]
Message-ID: <9283caeb-1b84-43c2-a8a4-6b43a6962f34@foss.st.com> (raw)
In-Reply-To: <2fad1566-49f9-4586-b0d4-8a4a12f9e69e@denx.de>
On 10/7/24 15:54, Marek Vasut wrote:
> On 10/7/24 3:27 PM, Gatien Chevallier wrote:
>> Implement the support for STM32MP25x platforms. On this platform, a
>> security clock is shared between some hardware blocks. For the RNG,
>> it is the RNG kernel clock. Therefore, the gate is no more shared
>> between the RNG bus and kernel clocks as on STM32MP1x platforms and
>> the bus clock has to be managed on its own.
>>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
> A bit of a higher-level design question -- can you use
> drivers/clk/clk-bulk.c clk_bulk_*() to handle all these disparate count
> of clock easily ?
Hi, I'd like to make sure that we enable the core clock before the bus
clock so that the RNG hardware block can start its internal tests while
we ungate the bus clock. It's not a strong opinion but it feels better.
Cheers,
Gatien
next prev parent reply other threads:[~2024-10-11 10:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 13:27 [PATCH 0/4] Add support for stm32mp25x RNG Gatien Chevallier
2024-10-07 13:27 ` [PATCH 1/4] dt-bindings: rng: add st,stm32mp25-rng support Gatien Chevallier
2024-10-07 13:53 ` Marek Vasut
2024-10-07 14:57 ` Gatien CHEVALLIER
2024-10-07 15:00 ` Krzysztof Kozlowski
2024-10-07 16:22 ` Gatien CHEVALLIER
2024-10-07 17:55 ` Krzysztof Kozlowski
2024-10-07 13:27 ` [PATCH 2/4] hwrng: stm32 - implement support for STM32MP25x platforms Gatien Chevallier
2024-10-07 13:54 ` Marek Vasut
2024-10-11 9:55 ` Gatien CHEVALLIER [this message]
2024-10-11 11:24 ` Marek Vasut
2024-10-11 12:07 ` Gatien CHEVALLIER
2024-10-11 12:38 ` Marek Vasut
2024-10-11 15:51 ` Gatien CHEVALLIER
2024-10-11 16:18 ` Marek Vasut
2024-10-07 13:27 ` [PATCH 3/4] hwrng: stm32 - update STM32MP15 RNG max clock frequency Gatien Chevallier
2024-10-07 13:55 ` Marek Vasut
2024-10-07 14:58 ` Gatien CHEVALLIER
2024-10-07 13:27 ` [PATCH 4/4] arm64: dts: st: add RNG node on stm32mp251 Gatien Chevallier
2024-10-07 13:55 ` Marek Vasut
2024-10-07 14:59 ` Gatien CHEVALLIER
2024-10-07 15:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9283caeb-1b84-43c2-a8a4-6b43a6962f34@foss.st.com \
--to=gatien.chevallier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lionel.debieve@foss.st.com \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivia@selenic.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).