devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
	andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org, manivannan.sadhasivam@linaro.org,
	robin.murphy@arm.com
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	konrad.dybcio@somainline.org, amit.pundir@linaro.org,
	regressions@leemhuis.info, sumit.semwal@linaro.org,
	will@kernel.org, catalin.marinas@arm.com
Subject: Re: [PATCH V2 02/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region
Date: Tue, 10 Jan 2023 10:35:13 +0100	[thread overview]
Message-ID: <92955e76-807f-3a8f-8cbd-3fafdd8f2054@linaro.org> (raw)
In-Reply-To: <20230109034843.23759-3-quic_sibis@quicinc.com>

On 09/01/2023 04:48, Sibi Sankar wrote:
> The dynamic memory region used for metadata authentication would still
> be a part of the kernel mapping and any access to this region  by the

Just one space before "by"

> application processor after assigning it to the remote Q6 will result
> in a XPU violation. This is fixed by using a no-map carveout instead.
> Update the bindings to reflect the addition of the new modem metadata
> carveout on MSM8996 (and similar) SoCs.
> 
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>  .../bindings/remoteproc/qcom,msm8996-mss-pil.yaml  | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> index d3d3fb2fe91d..ad1a51c23949 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> @@ -123,6 +123,7 @@ properties:
>      items:
>        - description: MBA reserved region
>        - description: Modem reserved region
> +      - description: Metadata reserved region
>  
>    firmware-name:
>      $ref: /schemas/types.yaml#/definitions/string-array
> @@ -165,6 +166,16 @@ properties:
>        - memory-region
>      deprecated: true
>  
> +  metadata:
> +    type: object

addutionalProperties: false

> +    description:
> +      Metadata reserved region

Blank line

> +    properties:
> +      memory-region: true

Blank line

> +    required:
> +      - memory-region
> +    deprecated: true


Best regards,
Krzysztof


  reply	other threads:[~2023-01-10  9:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09  3:48 [PATCH V2 00/11] Fix XPU violation during modem metadata authentication Sibi Sankar
2023-01-09  3:48 ` [PATCH V2 01/11] dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema Sibi Sankar
2023-01-10  9:33   ` Krzysztof Kozlowski
2023-01-09  3:48 ` [PATCH V2 02/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region Sibi Sankar
2023-01-10  9:35   ` Krzysztof Kozlowski [this message]
2023-01-09  3:48 ` [PATCH V2 03/11] dt-bindings: remoteproc: qcom,sc7180-mss-pil: Update memory-region Sibi Sankar
2023-01-09 14:30   ` Rob Herring
2023-01-10  9:36   ` Krzysztof Kozlowski
2023-01-09  3:48 ` [PATCH V2 04/11] dt-bindings: remoteproc: qcom,sc7280-mss-pil: " Sibi Sankar
2023-01-10  9:36   ` Krzysztof Kozlowski
2023-01-09  3:48 ` [PATCH V2 05/11] remoteproc: qcom_q6v5_mss: revert "map/unmap metadata region before/after use" Sibi Sankar
2023-01-09  8:18   ` Manivannan Sadhasivam
2023-01-09 10:00     ` Sibi Sankar
2023-01-11 11:24       ` Manivannan Sadhasivam
2023-01-09  3:48 ` [PATCH V2 06/11] remoteproc: qcom_q6v5_mss: Use a carveout to authenticate modem headers Sibi Sankar
2023-01-09  8:32   ` Manivannan Sadhasivam
2023-01-09 10:05     ` Sibi Sankar
2023-01-11 11:23       ` Manivannan Sadhasivam
2023-01-09  3:48 ` [PATCH V2 07/11] arm64: dts: qcom: msm8996: Add a carveout for modem metadata Sibi Sankar
2023-01-09  3:48 ` [PATCH V2 08/11] arm64: dts: qcom: msm8998: " Sibi Sankar
2023-01-09  3:48 ` [PATCH V2 09/11] arm64: dts: qcom: sdm845: " Sibi Sankar
2023-01-09  3:48 ` [PATCH V2 10/11] arm64: dts: qcom: sc7180: " Sibi Sankar
2023-01-09  3:48 ` [PATCH V2 11/11] arm64: dts: qcom: sc7280: " Sibi Sankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92955e76-807f-3a8f-8cbd-3fafdd8f2054@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=amit.pundir@linaro.org \
    --cc=andersson@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_sibis@quicinc.com \
    --cc=regressions@leemhuis.info \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sumit.semwal@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).