Devicetree
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v5 07/13] arm64: dts: qcom: x1e80100-crd: Add ov08x40 RGB sensor on CSIPHY4
Date: Fri, 4 Sep 2026 17:13:07 +0100	[thread overview]
Message-ID: <92afc051-3960-43c7-9104-159640a363cd@kernel.org> (raw)
In-Reply-To: <65c956d1-eadf-4bdb-bd66-0530421fda0f@oss.qualcomm.com>

On 04/09/2026 17:03, Nihal Kumar Gupta wrote:
> 
> On 04-09-2026 16:26, Bryan O'Donoghue wrote:
>> +		port@3 {
>> +			camss_csiphy4_inep: endpoint {
>> +				data-lanes = <0 1 2 3>;
>> +				remote-endpoint = <&csiphy4_out_ep>;
>> +			};
> Hi Bryan,
> 
> camss_csiphy4_inep has data-lanes = <0 1 2 3> and csiphy4_in_ep on the
> same physical link has data-lanes = <1 2 3 4>.

Yes I'm aware of that and choose not to churn this.

This is what the controller has always done - it only cares about the 
number of lanes in this mode not their value - in the old method it 
cares about the values too.

...

Sigh, I can write a patch to count the number of lanes instead of what 
the code currently does.

That way the old method and a new method based on +1 will not collide.

One thing to note is that if the PHY mapped lanes <2 3> the camss side 
would not care if we represented that as <0 1> <1 2> or <2 3> since all 
it cares about after this series is the _number_ of lanes.

That said it is less confusing to have a uniform numbering scheme at 
both ends.

---
bod

  reply	other threads:[~2026-09-04 16:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 10:56 [PATCH v5 00/13] arm64: dts: qcom: Add x1e/Hamoa camera DTSI Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 01/13] dt-bindings: media: qcom,x1e80100-camss: Describe iommu entries Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 02/13] dt-bindings: media: qcom,x1e80100-camss: Make vdd-csiphy supplies optional Bryan O'Donoghue
2026-09-04 19:55   ` Loic Poulain
2026-09-04 10:56 ` [PATCH v5 03/13] arm64: dts: qcom: x1e80100: Add CAMCC block definition Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 04/13] arm64: dts: qcom: x1e80100: Add CCI definitions Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 05/13] arm64: dts: qcom: x1e80100: Add CAMSS block definition Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 06/13] arm64: dts: qcom: x1e80100-crd: Add pm8010 CRD pmic,id=m regulators Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 07/13] arm64: dts: qcom: x1e80100-crd: Add ov08x40 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-09-04 16:03   ` Nihal Kumar Gupta
2026-09-04 16:13     ` Bryan O'Donoghue [this message]
2026-09-04 16:50       ` Nihal Kumar Gupta
2026-09-04 10:56 ` [PATCH v5 08/13] arm64: dts: qcom: x1e80100-t14s: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 09/13] arm64: dts: qcom: x1e80100-t14s: Add on ov02c10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 10/13] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 11/13] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add l7b_2p8 voltage regulator for " Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 12/13] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add ov02c10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-09-04 10:56 ` [PATCH v5 13/13] arm64: dts: qcom: x1e80100-dell-inspiron14-7441: Switch on CAMSS RGB sensor Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92afc051-3960-43c7-9104-159640a363cd@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=nihal.gupta@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox