* [PATCH] arm64: dts: ipq8074: disable USB phy by default
@ 2021-05-26 15:01 Robert Marko
2021-05-31 12:12 ` Kathiravan T
0 siblings, 1 reply; 2+ messages in thread
From: Robert Marko @ 2021-05-26 15:01 UTC (permalink / raw)
To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: Robert Marko
One of the QUSB USB PHY-s has been left enabled by
default, this is probably just a mistake as other
USB PHY-s are disabled by default.
It makes no sense to have it enabled by default as
not all board implement USB ports, so disable it.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 555a107959831..20059d0f7d714 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -286,6 +286,7 @@ qusb_phy_0: phy@79000 {
clock-names = "cfg_ahb", "ref";
resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
+ status = "disabled";
};
qmp_pcie_phy0: phy@84000 {
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: ipq8074: disable USB phy by default
2021-05-26 15:01 [PATCH] arm64: dts: ipq8074: disable USB phy by default Robert Marko
@ 2021-05-31 12:12 ` Kathiravan T
0 siblings, 0 replies; 2+ messages in thread
From: Kathiravan T @ 2021-05-31 12:12 UTC (permalink / raw)
To: Robert Marko
Cc: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
linux-kernel
On 2021-05-26 20:31, Robert Marko wrote:
> One of the QUSB USB PHY-s has been left enabled by
> default, this is probably just a mistake as other
> USB PHY-s are disabled by default.
>
> It makes no sense to have it enabled by default as
> not all board implement USB ports, so disable it.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
Always, it is better to disable in SOC DTS and enable only in the board
DTS files.
Reviewed-by: Kathiravan T <kathirav@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 555a107959831..20059d0f7d714 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -286,6 +286,7 @@ qusb_phy_0: phy@79000 {
> clock-names = "cfg_ahb", "ref";
>
> resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> + status = "disabled";
> };
>
> qmp_pcie_phy0: phy@84000 {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-31 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-26 15:01 [PATCH] arm64: dts: ipq8074: disable USB phy by default Robert Marko
2021-05-31 12:12 ` Kathiravan T
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).