From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42C5C433DF for ; Thu, 14 May 2020 10:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE1852065D for ; Thu, 14 May 2020 10:05:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="l3JU6WsA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726010AbgENKFe (ORCPT ); Thu, 14 May 2020 06:05:34 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:60988 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgENKFe (ORCPT ); Thu, 14 May 2020 06:05:34 -0400 Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E2ECC9A8; Thu, 14 May 2020 12:05:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1589450732; bh=HIFwH/zOaG31nesCn5CYtH8UsMJVPfM9hl/t5q8ugGw=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=l3JU6WsAtFYJQ0oW0AMxTQpL7yuv2VFOn2B78j+H5oRrMUCN8EywMz11LKmckgDGQ WTQ5EKNg372EPCC1DFcy161FEDQCIdL/LANgmeGPK/THbUe9E5ZqT1QOeM2RRW3lIu ygToiBIb6KqYFH8FtHADBrUwhlK2rA8kU+2RTeM4= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH v9 2/4] media: i2c: Add MAX9286 driver To: Manivannan Sadhasivam Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Kieran Bingham , Laurent Pinchart , Jacopo Mondi , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , sakari.ailus@iki.fi, Hans Verkuil , Hyun Kwon , Rob Herring , Jacopo Mondi , Laurent Pinchart , =?UTF-8?Q?Niklas_S=c3=b6derlund?= References: <20200512155105.1068064-1-kieran.bingham+renesas@ideasonboard.com> <20200512155105.1068064-3-kieran.bingham+renesas@ideasonboard.com> <20200512174056.GH5526@Mani-XPS-13-9360> <20200514095948.GE2877@Mani-XPS-13-9360> From: Kieran Bingham Organization: Ideas on Board Message-ID: <92d53749-4ba4-503c-f7c2-386d32d2876d@ideasonboard.com> Date: Thu, 14 May 2020 11:05:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200514095948.GE2877@Mani-XPS-13-9360> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Mani, On 14/05/2020 10:59, Manivannan Sadhasivam wrote: > On Thu, May 14, 2020 at 10:53:00AM +0100, Kieran Bingham wrote: >> Hi Mani, >>>> +static int max9286_set_fmt(struct v4l2_subdev *sd, >>>> + struct v4l2_subdev_pad_config *cfg, >>>> + struct v4l2_subdev_format *format) >>>> +{ >>>> + struct max9286_priv *priv = sd_to_max9286(sd); >>>> + struct v4l2_mbus_framefmt *cfg_fmt; >>>> + >>>> + if (format->pad >= MAX9286_SRC_PAD) >>>> + return -EINVAL; >>>> + >>>> + /* Refuse non YUV422 formats as we hardcode DT to 8 bit YUV422 */ >>>> + switch (format->format.code) { >>>> + case MEDIA_BUS_FMT_UYVY8_2X8: >>>> + case MEDIA_BUS_FMT_VYUY8_2X8: >>>> + case MEDIA_BUS_FMT_YUYV8_2X8: >>>> + case MEDIA_BUS_FMT_YVYU8_2X8: >>>> + break; >>>> + default: >>>> + format->format.code = MEDIA_BUS_FMT_YUYV8_2X8; >>> >>> Is there any reason for not setting default format to MEDIA_BUS_FMT_UYVY8_2X8? >>> >> >> >> No good reason no, and I see that in max9286_enum_mbus_code(), we >> currently code to MEDIA_BUS_FMT_YUYV8_2X8, and that's the value that we >> init to, so that would be a better default indeed. >> > > max9286_enum_mbus_code() returns MEDIA_BUS_FMT_UYVY8_2X8, no? Argh, sorry - yet anther typo or copy/paste error. Indeed, I have changed this locally to ... MEDIA_BUS_FMT_UYVY8_2X8 as suggested. ;-) > > Thanks, > Mani