From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-binding: convert amlogic,g12a-tohdmitx to dt-schema
Date: Thu, 6 Jun 2024 09:59:01 +0200 [thread overview]
Message-ID: <92f96ac7-d36b-4c3c-862e-90e939c367a4@linaro.org> (raw)
In-Reply-To: <4d9d7cff-1a00-459d-8ccf-d30ec2cdcaad@kernel.org>
On 06/06/2024 09:45, Krzysztof Kozlowski wrote:
> On 06/06/2024 09:45, Krzysztof Kozlowski wrote:
>> On 05/06/2024 18:23, Neil Armstrong wrote:
>>> Convert text bindings to dt-schema format for the Amlogic TX HDMI
>>> control glue.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>
>> subject: dt-bindings (missing 's')
>>
>>> ---
>>> .../bindings/sound/amlogic,g12a-tohdmitx.txt | 58 ----------------------
>>> .../bindings/sound/amlogic,g12a-tohdmitx.yaml | 56 +++++++++++++++++++++
>>> 2 files changed, 56 insertions(+), 58 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt b/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt
>>> deleted file mode 100644
>>> index 4e8cd7eb7cec..000000000000
>>> --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt
>>> +++ /dev/null
>>> @@ -1,58 +0,0 @@
>>> -* Amlogic HDMI Tx control glue
>>> -
>>
>>> +
>>> +title: Amlogic G12a HDMI TX Control Glue
>>> +
>>> +maintainers:
>>> + - Jerome Brunet <jbrunet@baylibre.com>
>>> +
>>> +allOf:
>>> + - $ref: dai-common.yaml#
>>> +
>>> +properties:
>>> + $nodename:
>>> + pattern: "^audio-controller@.*"
>>> +
>>> + "#sound-dai-cells":
>>> + const: 1
>>> +
>>> + compatible:
>>> + oneOf:
>>> + - items:
>>> + - const: amlogic,g12a-tohdmitx
>>> + - items:
>>> + - enum:
>>> + - amlogic,sm1-tohdmitx
>>> + - const: amlogic,g12a-tohdmitx
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + resets:
>>> + maxItems: 1
>>> +
>>> + sound-name-prefix: true
>>
>> Drop
>>
>>> +
>>> +required:
>>> + - "#sound-dai-cells"
>>> + - compatible
>>> + - reg
>>> + - resets
>>
>> Please keep the same order as in "properties:" block.
>>
>>> +
>>> +additionalProperties: false
>>
>> and here instead:
>> unevaluatedProperties: false
>>
>
> and with above changes:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Ack,
Thanks,
Neil
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2024-06-06 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 16:23 [PATCH] ASoC: dt-binding: convert amlogic,g12a-tohdmitx to dt-schema Neil Armstrong
2024-06-06 7:45 ` Krzysztof Kozlowski
2024-06-06 7:45 ` Krzysztof Kozlowski
2024-06-06 7:59 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f96ac7-d36b-4c3c-862e-90e939c367a4@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox