* [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
@ 2023-09-26 4:48 Raghavendra Kakarla
2023-09-26 15:53 ` Andrew Halaney
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Raghavendra Kakarla @ 2023-09-26 4:48 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Raghavendra Kakarla
Cc: quic_mkshah, quic_lsrao, linux-arm-msm, linux-kernel, devicetree
Add device node for sleep stats driver which provides various
low power mode stats.
Cc: devicetree@vger.kernel.org
Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 9f4f58e831a4..cee7491de675 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -1912,6 +1912,11 @@
#clock-cells = <0>;
};
+ sram@c3f0000 {
+ compatible = "qcom,rpmh-stats";
+ reg = <0 0x0c3f0000 0 0x400>;
+ };
+
spmi_bus: spmi@c440000 {
compatible = "qcom,spmi-pmic-arb";
reg = <0x0 0x0c440000 0x0 0x1100>,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
2023-09-26 4:48 [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats Raghavendra Kakarla
@ 2023-09-26 15:53 ` Andrew Halaney
2023-09-26 19:06 ` Konrad Dybcio
2023-09-27 7:59 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Halaney @ 2023-09-26 15:53 UTC (permalink / raw)
To: Raghavendra Kakarla
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, quic_mkshah, quic_lsrao, linux-arm-msm,
linux-kernel, devicetree
On Tue, Sep 26, 2023 at 10:18:14AM +0530, Raghavendra Kakarla wrote:
> Add device node for sleep stats driver which provides various
> low power mode stats.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
Tested-by: Andrew Halaney <ahalaney@redhat.com>
I took this for a quick spin when testing -next today, and I see the
qcom_stats directory, can view the file output, etc. Probably good enough
to consider this simple change tested. I also don't see any new issues
when running:
ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CHECK_DTBS=1 qcom/sa8775p-ride.dtb
> ---
Generally you should put a description of what changed since v1
in this section.
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..cee7491de675 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
> #clock-cells = <0>;
> };
>
> + sram@c3f0000 {
> + compatible = "qcom,rpmh-stats";
> + reg = <0 0x0c3f0000 0 0x400>;
> + };
> +
> spmi_bus: spmi@c440000 {
> compatible = "qcom,spmi-pmic-arb";
> reg = <0x0 0x0c440000 0x0 0x1100>,
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
2023-09-26 4:48 [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats Raghavendra Kakarla
2023-09-26 15:53 ` Andrew Halaney
@ 2023-09-26 19:06 ` Konrad Dybcio
2023-09-29 5:28 ` Raghavendra Kakarla
2023-09-27 7:59 ` Krzysztof Kozlowski
2 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-09-26 19:06 UTC (permalink / raw)
To: Raghavendra Kakarla, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: quic_mkshah, quic_lsrao, linux-arm-msm, linux-kernel, devicetree
On 26.09.2023 06:48, Raghavendra Kakarla wrote:
> Add device node for sleep stats driver which provides various
> low power mode stats.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..cee7491de675 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
> #clock-cells = <0>;
> };
>
> + sram@c3f0000 {
> + compatible = "qcom,rpmh-stats";
> + reg = <0 0x0c3f0000 0 0x400>;
Other nodes (such as the one 5 lines below) use 0x0 instead of
0 to fill out bits 63:32. Please make it consistent.
Konrad
> + };
> +
> spmi_bus: spmi@c440000 {
> compatible = "qcom,spmi-pmic-arb";
> reg = <0x0 0x0c440000 0x0 0x1100>,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
2023-09-26 4:48 [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats Raghavendra Kakarla
2023-09-26 15:53 ` Andrew Halaney
2023-09-26 19:06 ` Konrad Dybcio
@ 2023-09-27 7:59 ` Krzysztof Kozlowski
2023-09-29 5:28 ` Raghavendra Kakarla
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-27 7:59 UTC (permalink / raw)
To: Raghavendra Kakarla, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: quic_mkshah, quic_lsrao, linux-arm-msm, linux-kernel, devicetree
On 26/09/2023 06:48, Raghavendra Kakarla wrote:
> Add device node for sleep stats driver which provides various
> low power mode stats.
>
> Cc: devicetree@vger.kernel.org
No need to keep such Cc in commit log.
> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..cee7491de675 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
> #clock-cells = <0>;
> };
>
> + sram@c3f0000 {
> + compatible = "qcom,rpmh-stats";
> + reg = <0 0x0c3f0000 0 0x400>;
Please use consistent format - hex.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
2023-09-26 19:06 ` Konrad Dybcio
@ 2023-09-29 5:28 ` Raghavendra Kakarla
0 siblings, 0 replies; 6+ messages in thread
From: Raghavendra Kakarla @ 2023-09-29 5:28 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: quic_mkshah, quic_lsrao, linux-arm-msm, linux-kernel, devicetree
On 9/27/2023 12:36 AM, Konrad Dybcio wrote:
> On 26.09.2023 06:48, Raghavendra Kakarla wrote:
>> Add device node for sleep stats driver which provides various
>> low power mode stats.
>>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..cee7491de675 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>> #clock-cells = <0>;
>> };
>>
>> + sram@c3f0000 {
>> + compatible = "qcom,rpmh-stats";
>> + reg = <0 0x0c3f0000 0 0x400>;
> Other nodes (such as the one 5 lines below) use 0x0 instead of
> 0 to fill out bits 63:32. Please make it consistent.
Sure, will address this in next patch.
>
> Konrad
>> + };
>> +
>> spmi_bus: spmi@c440000 {
>> compatible = "qcom,spmi-pmic-arb";
>> reg = <0x0 0x0c440000 0x0 0x1100>,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
2023-09-27 7:59 ` Krzysztof Kozlowski
@ 2023-09-29 5:28 ` Raghavendra Kakarla
0 siblings, 0 replies; 6+ messages in thread
From: Raghavendra Kakarla @ 2023-09-29 5:28 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: quic_mkshah, quic_lsrao, linux-arm-msm, linux-kernel, devicetree
On 9/27/2023 1:29 PM, Krzysztof Kozlowski wrote:
> On 26/09/2023 06:48, Raghavendra Kakarla wrote:
>> Add device node for sleep stats driver which provides various
>> low power mode stats.
>>
>> Cc: devicetree@vger.kernel.org
> No need to keep such Cc in commit log.
Sure, will remove this.
>
>> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..cee7491de675 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>> #clock-cells = <0>;
>> };
>>
>> + sram@c3f0000 {
>> + compatible = "qcom,rpmh-stats";
>> + reg = <0 0x0c3f0000 0 0x400>;
> Please use consistent format - hex.
yes, will address this in next patch.
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-29 5:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 4:48 [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats Raghavendra Kakarla
2023-09-26 15:53 ` Andrew Halaney
2023-09-26 19:06 ` Konrad Dybcio
2023-09-29 5:28 ` Raghavendra Kakarla
2023-09-27 7:59 ` Krzysztof Kozlowski
2023-09-29 5:28 ` Raghavendra Kakarla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).