devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus	 <tudor.ambarus@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski	 <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alim Akhtar	 <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche	 <bvanassche@acm.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	 linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-scsi@vger.kernel.org,
	kernel-team@android.com, willmcvicker@google.com,
		stable@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: ufs: dt-bindings: exynos: add dma-coherent property for gs101
Date: Fri, 14 Mar 2025 15:59:43 +0000	[thread overview]
Message-ID: <931e5e0b07d598912712b091d99a636b796fe19f.camel@linaro.org> (raw)
In-Reply-To: <20250314-ufs-dma-coherent-v1-2-bdf9f9be2919@linaro.org>

Hi Pete,

On Fri, 2025-03-14 at 15:38 +0000, Peter Griffin wrote:
> dma-coherent property is required for gs101 as ufs-exynos enables
> sharability.
> 
> Fixes: 438e23b61cd4 ("scsi: ufs: dt-bindings: exynos: Add gs101 compatible")
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-
> ufs.yaml
> index 720879820f6616a30cae2db3d4d2d22e847666c4..5dbb7f6a8c354b82685c521e70655e106f702a8d 100644
> --- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> @@ -96,6 +96,8 @@ allOf:
>          clock-names:
>            minItems: 6
>  
> +        dma-coherent: true
> +

This is allowed globally already in this file. Did you meant to make it 'required'?

Cheers,
Andre'

>      else:
>        properties:
>          clocks:
> 


  reply	other threads:[~2025-03-14 15:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 15:38 [PATCH 0/2] Add dma-coherent for gs101 UFS dt node Peter Griffin
2025-03-14 15:38 ` [PATCH 1/2] arm64: dts: exynos: gs101: ufs: add dma-coherent property Peter Griffin
2025-03-14 15:56   ` André Draszik
2025-03-14 17:14   ` William McVicker
2025-06-27 16:28   ` Peter Griffin
2025-06-30  6:01     ` Krzysztof Kozlowski
2025-06-30  6:56   ` (subset) " Krzysztof Kozlowski
2025-03-14 15:38 ` [PATCH 2/2] scsi: ufs: dt-bindings: exynos: add dma-coherent property for gs101 Peter Griffin
2025-03-14 15:59   ` André Draszik [this message]
2025-03-17 14:55     ` Peter Griffin
2025-03-17 10:51   ` Krzysztof Kozlowski
2025-03-14 16:00 ` [PATCH 0/2] Add dma-coherent for gs101 UFS dt node Bart Van Assche
2025-03-14 17:16   ` William McVicker
2025-03-17  7:57   ` Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=931e5e0b07d598912712b091d99a636b796fe19f.camel@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).