From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>,
agross@kernel.org
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Add sc7180-gelarshie
Date: Wed, 6 Apr 2022 16:38:58 +0200 [thread overview]
Message-ID: <9326aee4-744e-9eeb-a5dd-b86e43b6c4c0@linaro.org> (raw)
In-Reply-To: <20220406094156.3191-1-chenxiangrui@huaqin.corp-partner.google.com>
On 06/04/2022 11:41, Mars Chen wrote:
> Add device tree for Gelarshie, a trogdor variant
>
> Signed-off-by: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>
Hi,
I think I saw this some days ago... Isn't this a v2? If yes, please mark
it in subject and add a changelog describing what you did. See also:
https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst
Did you address all the comments you received before? At mine looks not
addressed... :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-06 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 9:41 [PATCH] arm64: dts: qcom: Add sc7180-gelarshie Mars Chen
2022-04-06 14:38 ` Krzysztof Kozlowski [this message]
2022-04-06 15:43 ` Matthias Kaehlcke
[not found] ` <CA+Bnokw-8023cvifSZtT8WR4TvUi8K3512TmEoXhKezMjbQNUQ@mail.gmail.com>
2022-04-07 11:38 ` Krzysztof Kozlowski
2022-04-07 11:46 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2022-04-06 7:47 Mars Chen
2022-04-06 7:37 Mars Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9326aee4-744e-9eeb-a5dd-b86e43b6c4c0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chenxiangrui@huaqin.corp-partner.google.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).