[PATCH 0/8] Fixing some dtbscheck warnings

[PATCH 0/8] Fixing some dtbscheck warnings

[Heiko Stuebner]

Fixing dtbs-check warnings should be declared addictive, one starts
with one warning, then another one and then it's oh, I'll just fix
this "last" one over and over ;-)

We still have more, if others want to play too :-D .


Heiko Stuebner (8):
  arm64: dts: rockchip: fix i2c2 pinctrl-names property on
    anbernic-rg353p
  arm64: dts: rockchip: fix i2c2 pinctrl-names property on
    anbernic-rg353v
  arm64: dts: rockchip: Drop regulator-init-microvolt from rk3568-roc-pc
  arm64: dts: rockchip: Drop regulator-init-microvolt from
    rk3588-toybrick-x0
  arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo
  arm64: dts: rockchip: Fix bluetooth properties on Rock960 boards
  arm64: dts: rockchip: Remove undocumented emmc property from
    PX30-Ringneck
  arm64: dts: rockchip: Remove #cooling-cells from fan on Theobroma
    boards

 arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi         | 2 --
 arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi           | 1 -
 arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi           | 1 -
 arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi        | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts        | 6 +++---
 arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts          | 3 ---
 arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts     | 1 -
 9 files changed, 6 insertions(+), 14 deletions(-)

-- 
2.43.0

[PATCH 1/8] arm64: dts: rockchip: fix i2c2 pinctrl-names property on anbernic-rg353p

[Heiko Stuebner]

We want to control pins, not beer mugs, so rename pintctrl-names to the
expected inctrl-names.

This was not affecting functionality, because the i2c2 controller
already had a set of pinctrl properties.

Fixes: 523adb553573 ("arm64: dts: rockchip: add Anbernic RG353P and RG503")
Cc: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
index a73cf30801ec..9816a4ed4599 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
@@ -92,7 +92,7 @@ button-r2 {
 };
 
 &i2c2 {
-	pintctrl-names = "default";
+	pinctrl-names = "default";
 	pinctrl-0 = <&i2c2m1_xfer>;
 	status = "okay";
 
-- 
2.43.0

Re: [PATCH 1/8] arm64: dts: rockchip: fix i2c2 pinctrl-names property on anbernic-rg353p

[Chris Morgan]

On Mon, Sep 30, 2024 at 11:01:05PM +0200, Heiko Stuebner wrote:
> We want to control pins, not beer mugs, so rename pintctrl-names to the
> expected inctrl-names.

You may not want to control beer, but me...

Thank you for the catch, not sure how this first happened but
subsequent instances are likely a cut and paste.

Acked-by: Chris Morgan <macromorgan@hotmail.com>

> 
> This was not affecting functionality, because the i2c2 controller
> already had a set of pinctrl properties.
> 
> Fixes: 523adb553573 ("arm64: dts: rockchip: add Anbernic RG353P and RG503")
> Cc: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> index a73cf30801ec..9816a4ed4599 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> @@ -92,7 +92,7 @@ button-r2 {
>  };
>  
>  &i2c2 {
> -	pintctrl-names = "default";
> +	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c2m1_xfer>;
>  	status = "okay";
>  
> -- 
> 2.43.0
> 

[PATCH 2/8] arm64: dts: rockchip: fix i2c2 pinctrl-names property on anbernic-rg353v

[Heiko Stuebner]

We want to control pins, not beer mugs, so rename pintctrl-names to the
expected inctrl-names.

This was not affecting functionality, because the i2c2 controller
already had a set of pinctrl properties.

Fixes: 1e141cf12726 ("arm64: dts: rockchip: add Anbernic RG353V and RG353VS")
Cc: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts
index e9954a33e8cd..a79a5614bcc8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts
@@ -79,7 +79,7 @@ button-r2 {
 };
 
 &i2c2 {
-	pintctrl-names = "default";
+	pinctrl-names = "default";
 	pinctrl-0 = <&i2c2m1_xfer>;
 	status = "okay";
 
-- 
2.43.0

Re: [PATCH 2/8] arm64: dts: rockchip: fix i2c2 pinctrl-names property on anbernic-rg353v

[Chris Morgan]

On Mon, Sep 30, 2024 at 11:01:06PM +0200, Heiko Stuebner wrote:
> We want to control pins, not beer mugs, so rename pintctrl-names to the
> expected inctrl-names.
> 
> This was not affecting functionality, because the i2c2 controller
> already had a set of pinctrl properties.

Acked-by: Chris Morgan <macromorgan@hotmail.com>

> 
> Fixes: 1e141cf12726 ("arm64: dts: rockchip: add Anbernic RG353V and RG353VS")
> Cc: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts
> index e9954a33e8cd..a79a5614bcc8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts
> @@ -79,7 +79,7 @@ button-r2 {
>  };
>  
>  &i2c2 {
> -	pintctrl-names = "default";
> +	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c2m1_xfer>;
>  	status = "okay";
>  
> -- 
> 2.43.0
> 

[PATCH 3/8] arm64: dts: rockchip: Drop regulator-init-microvolt from rk3568-roc-pc

[Heiko Stuebner]

regulator-init-microvolt is not part of any regulator binding and is
only used in the Rockchip vendor kernel. So drop it.

Fixes: 007b4bb47f44 ("arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc")
Cc: Furkan Kardame <f.kardame@manjaro.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
index e333449ead04..2fa89a0eeafc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
@@ -272,7 +272,6 @@ vdd_logic: DCDC_REG1 {
 				regulator-name = "vdd_logic";
 				regulator-always-on;
 				regulator-boot-on;
-				regulator-init-microvolt = <900000>;
 				regulator-initial-mode = <0x2>;
 				regulator-min-microvolt = <500000>;
 				regulator-max-microvolt = <1350000>;
@@ -285,7 +284,6 @@ regulator-state-mem {
 
 			vdd_gpu: DCDC_REG2 {
 				regulator-name = "vdd_gpu";
-				regulator-init-microvolt = <900000>;
 				regulator-initial-mode = <0x2>;
 				regulator-min-microvolt = <500000>;
 				regulator-max-microvolt = <1350000>;
@@ -309,7 +307,6 @@ regulator-state-mem {
 
 			vdd_npu: DCDC_REG4 {
 				regulator-name = "vdd_npu";
-				regulator-init-microvolt = <900000>;
 				regulator-initial-mode = <0x2>;
 				regulator-min-microvolt = <500000>;
 				regulator-max-microvolt = <1350000>;
-- 
2.43.0

Re: [PATCH 3/8] arm64: dts: rockchip: Drop regulator-init-microvolt from rk3568-roc-pc

[Jonas Karlman]

Hi Heiko,

On 2024-09-30 23:01, Heiko Stuebner wrote:
> regulator-init-microvolt is not part of any regulator binding and is
> only used in the Rockchip vendor kernel. So drop it.

Mainline U-Boot is also a user of the regulator-init-microvolt prop,
and use it to help configure an initial voltage on regulators during
boot.

Mostly useful for regulators that has different min / max voltage and
is not enabled by default or set to an unexpected voltage on boot, e.g.
the typical npu regulator on rk356x defaults to 0.5v, yet needs to be
around 0.9v during npu probe.

Maybe a better option would be to try add the init property to the Linux
dt-bindning?

https://source.denx.de/u-boot/u-boot/-/blob/master/doc/device-tree-bindings/regulator/regulator.txt#L40

Regards,
Jonas

> 
> Fixes: 007b4bb47f44 ("arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc")
> Cc: Furkan Kardame <f.kardame@manjaro.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> index e333449ead04..2fa89a0eeafc 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> @@ -272,7 +272,6 @@ vdd_logic: DCDC_REG1 {
>  				regulator-name = "vdd_logic";
>  				regulator-always-on;
>  				regulator-boot-on;
> -				regulator-init-microvolt = <900000>;
>  				regulator-initial-mode = <0x2>;
>  				regulator-min-microvolt = <500000>;
>  				regulator-max-microvolt = <1350000>;
> @@ -285,7 +284,6 @@ regulator-state-mem {
>  
>  			vdd_gpu: DCDC_REG2 {
>  				regulator-name = "vdd_gpu";
> -				regulator-init-microvolt = <900000>;
>  				regulator-initial-mode = <0x2>;
>  				regulator-min-microvolt = <500000>;
>  				regulator-max-microvolt = <1350000>;
> @@ -309,7 +307,6 @@ regulator-state-mem {
>  
>  			vdd_npu: DCDC_REG4 {
>  				regulator-name = "vdd_npu";
> -				regulator-init-microvolt = <900000>;
>  				regulator-initial-mode = <0x2>;
>  				regulator-min-microvolt = <500000>;
>  				regulator-max-microvolt = <1350000>;

Re: [PATCH 3/8] arm64: dts: rockchip: Drop regulator-init-microvolt from rk3568-roc-pc

[Heiko Stübner]

Hi Jonas,

Am Dienstag, 1. Oktober 2024, 00:55:42 CEST schrieb Jonas Karlman:
> Hi Heiko,
> 
> On 2024-09-30 23:01, Heiko Stuebner wrote:
> > regulator-init-microvolt is not part of any regulator binding and is
> > only used in the Rockchip vendor kernel. So drop it.
> 
> Mainline U-Boot is also a user of the regulator-init-microvolt prop,
> and use it to help configure an initial voltage on regulators during
> boot.
> 
> Mostly useful for regulators that has different min / max voltage and
> is not enabled by default or set to an unexpected voltage on boot, e.g.
> the typical npu regulator on rk356x defaults to 0.5v, yet needs to be
> around 0.9v during npu probe.
> 
> Maybe a better option would be to try add the init property to the Linux
> dt-bindning?

Looks like that topic comes up regularly, last time in

https://lore.kernel.org/linux-arm-kernel/4519023.cEBGB3zze1@phil/

and that still is true. DT is not a configuration-space, and if needed those
properties should be in the -uboot.dtsi

Heiko


> https://source.denx.de/u-boot/u-boot/-/blob/master/doc/device-tree-bindings/regulator/regulator.txt#L40
> 
> Regards,
> Jonas
> 
> > 
> > Fixes: 007b4bb47f44 ("arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc")
> > Cc: Furkan Kardame <f.kardame@manjaro.org>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> > index e333449ead04..2fa89a0eeafc 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> > @@ -272,7 +272,6 @@ vdd_logic: DCDC_REG1 {
> >  				regulator-name = "vdd_logic";
> >  				regulator-always-on;
> >  				regulator-boot-on;
> > -				regulator-init-microvolt = <900000>;
> >  				regulator-initial-mode = <0x2>;
> >  				regulator-min-microvolt = <500000>;
> >  				regulator-max-microvolt = <1350000>;
> > @@ -285,7 +284,6 @@ regulator-state-mem {
> >  
> >  			vdd_gpu: DCDC_REG2 {
> >  				regulator-name = "vdd_gpu";
> > -				regulator-init-microvolt = <900000>;
> >  				regulator-initial-mode = <0x2>;
> >  				regulator-min-microvolt = <500000>;
> >  				regulator-max-microvolt = <1350000>;
> > @@ -309,7 +307,6 @@ regulator-state-mem {
> >  
> >  			vdd_npu: DCDC_REG4 {
> >  				regulator-name = "vdd_npu";
> > -				regulator-init-microvolt = <900000>;
> >  				regulator-initial-mode = <0x2>;
> >  				regulator-min-microvolt = <500000>;
> >  				regulator-max-microvolt = <1350000>;
> 
> 

[PATCH 4/8] arm64: dts: rockchip: Drop regulator-init-microvolt from rk3588-toybrick-x0

[Heiko Stuebner]

regulator-init-microvolt is not part of any regulator binding and is
only used in the Rockchip vendor kernel. So drop it.

Fixes: 8ffe365f8dc7 ("arm64: dts: rockchip: Add devicetree support for TB-RK3588X board")
Cc: Elon Zhang <zhangzj@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts b/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts
index d0021524e7f9..328dcb894ccb 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts
@@ -428,7 +428,6 @@ vdd_vdenc_s0: vdd_vdenc_mem_s0: dcdc-reg4 {
 				regulator-boot-on;
 				regulator-min-microvolt = <550000>;
 				regulator-max-microvolt = <950000>;
-				regulator-init-microvolt = <750000>;
 				regulator-ramp-delay = <12500>;
 
 				regulator-state-mem {
-- 
2.43.0

[PATCH 5/8] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo

[Heiko Stuebner]

The expected clock-name is different (ext_clock -> extclk) and the wakeup
gpio properties are named differently when changing from vendor-tree to
mainline. So fix those to match the binding.

Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board")
Cc: Andy Yan <andyshrk@163.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
index 0c18406e4c59..dd6fe964d618 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
@@ -449,9 +449,9 @@ &uart1 {
 	bluetooth {
 		compatible = "brcm,bcm43438-bt";
 		clocks = <&pmucru CLK_RTC_32K>;
-		clock-names = "ext_clock";
-		device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
-		host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
+		clock-names = "extclk";
+		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
+		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
 		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
-- 
2.43.0

Re: [PATCH 5/8] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

On Mon Sep 30, 2024 at 11:01 PM CEST, Heiko Stuebner wrote:
> The expected clock-name is different (ext_clock -> extclk) and the wakeup

According to "brcm,bluetooth.yaml", 'extclk' is deprecated in favor of
'txco', so it seems better to use that?
Same would be true for Rock960 boards (patch 6 of this series).

Cheers,
  Diederik

> gpio properties are named differently when changing from vendor-tree to
> mainline. So fix those to match the binding.
>
> Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board")
> Cc: Andy Yan <andyshrk@163.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> index 0c18406e4c59..dd6fe964d618 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> @@ -449,9 +449,9 @@ &uart1 {
>  	bluetooth {
>  		compatible = "brcm,bcm43438-bt";
>  		clocks = <&pmucru CLK_RTC_32K>;
> -		clock-names = "ext_clock";
> -		device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> -		host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> +		clock-names = "extclk";
> +		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> +		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
>  		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 5/8] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo

[Heiko Stübner]

Hi Diederik,

Am Montag, 7. Oktober 2024, 17:27:12 CEST schrieb Diederik de Haas:
> On Mon Sep 30, 2024 at 11:01 PM CEST, Heiko Stuebner wrote:
> > The expected clock-name is different (ext_clock -> extclk) and the wakeup
> 
> According to "brcm,bluetooth.yaml", 'extclk' is deprecated in favor of
> 'txco', so it seems better to use that?
> Same would be true for Rock960 boards (patch 6 of this series).

thanks for that catch. I mainly stumbled upon the "_" underscore, found the
clockname without but didn't take into account that there was a deprecated
flag set in the binding :-)


> > gpio properties are named differently when changing from vendor-tree to
> > mainline. So fix those to match the binding.
> >
> > Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board")
> > Cc: Andy Yan <andyshrk@163.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > index 0c18406e4c59..dd6fe964d618 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > @@ -449,9 +449,9 @@ &uart1 {
> >  	bluetooth {
> >  		compatible = "brcm,bcm43438-bt";
> >  		clocks = <&pmucru CLK_RTC_32K>;
> > -		clock-names = "ext_clock";
> > -		device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > -		host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > +		clock-names = "extclk";
> > +		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > +		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> >  		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
> 
> 

Re: [PATCH 5/8] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 3008 bytes --]

Hi Heiko,

On Mon Oct 7, 2024 at 6:04 PM CEST, Heiko Stübner wrote:
> Am Montag, 7. Oktober 2024, 17:27:12 CEST schrieb Diederik de Haas:
> > On Mon Sep 30, 2024 at 11:01 PM CEST, Heiko Stuebner wrote:
> > > The expected clock-name is different (ext_clock -> extclk) and the wakeup
> > 
> > According to "brcm,bluetooth.yaml", 'extclk' is deprecated in favor of
> > 'txco', so it seems better to use that?
> > Same would be true for Rock960 boards (patch 6 of this series).
>
> thanks for that catch. I mainly stumbled upon the "_" underscore, found the
> clockname without but didn't take into account that there was a deprecated
> flag set in the binding :-)

Doing research for another improvement, I stumbled upon this commit:

ebceec271e55 ("arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards")

with the following diff:

```
 	sdio_pwrseq: sdio-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		clocks = <&rk808 1>;
-		clock-names = "ext_clock";
+		clock-names = "lpo";
 		pinctrl-names = "default";
 		pinctrl-0 = <&wifi_enable_h>;
 		reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
```

But do read the full git commit message.

The corresponding bluetooth node had 'lpo' as new value for
'clock-names' though ... from "ext_clock", but it also changed
its compatible, so it's not the same. For details, see commit
f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards")

So it's possible the change needs to be more extensive.
And a Tested-by tag from someone with the board is probably a good idea.

Regards,
  Diederik

> > > gpio properties are named differently when changing from vendor-tree to
> > > mainline. So fix those to match the binding.
> > >
> > > Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board")
> > > Cc: Andy Yan <andyshrk@163.com>
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > ---
> > >  arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > index 0c18406e4c59..dd6fe964d618 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > @@ -449,9 +449,9 @@ &uart1 {
> > >  	bluetooth {
> > >  		compatible = "brcm,bcm43438-bt";
> > >  		clocks = <&pmucru CLK_RTC_32K>;
> > > -		clock-names = "ext_clock";
> > > -		device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > > -		host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > > +		clock-names = "extclk";
> > > +		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > > +		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > >  		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
> > >  		pinctrl-names = "default";
> > >  		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
> > 
> > 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 5/8] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo

[Heiko Stübner]

Am Montag, 7. Oktober 2024, 21:33:11 CEST schrieb Diederik de Haas:
> Hi Heiko,
> 
> On Mon Oct 7, 2024 at 6:04 PM CEST, Heiko Stübner wrote:
> > Am Montag, 7. Oktober 2024, 17:27:12 CEST schrieb Diederik de Haas:
> > > On Mon Sep 30, 2024 at 11:01 PM CEST, Heiko Stuebner wrote:
> > > > The expected clock-name is different (ext_clock -> extclk) and the wakeup
> > > 
> > > According to "brcm,bluetooth.yaml", 'extclk' is deprecated in favor of
> > > 'txco', so it seems better to use that?
> > > Same would be true for Rock960 boards (patch 6 of this series).
> >
> > thanks for that catch. I mainly stumbled upon the "_" underscore, found the
> > clockname without but didn't take into account that there was a deprecated
> > flag set in the binding :-)
> 
> Doing research for another improvement, I stumbled upon this commit:
> 
> ebceec271e55 ("arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards")
> 
> with the following diff:
> 
> ```
>  	sdio_pwrseq: sdio-pwrseq {
>  		compatible = "mmc-pwrseq-simple";
>  		clocks = <&rk808 1>;
> -		clock-names = "ext_clock";
> +		clock-names = "lpo";
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&wifi_enable_h>;
>  		reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
> ```
> 

The brcm,bluetooth binding is pretty clear, it's
txco - for an "external reference clock, not a crystal"
lpo - for a low power 32.768 kHz clock.

The rk808 and also the pmucru are both "not crystals", so I'll just go
with the "txco".

The hci_bcm driver also handles txco and extclk the same, so there won't
be a behaviour change with existing code.


Heiko

> But do read the full git commit message.
> 
> The corresponding bluetooth node had 'lpo' as new value for
> 'clock-names' though ... from "ext_clock", but it also changed
> its compatible, so it's not the same. For details, see commit
> f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards")
> 
> So it's possible the change needs to be more extensive.
> And a Tested-by tag from someone with the board is probably a good idea.
> 
> Regards,
>   Diederik
> 
> > > > gpio properties are named differently when changing from vendor-tree to
> > > > mainline. So fix those to match the binding.
> > > >
> > > > Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board")
> > > > Cc: Andy Yan <andyshrk@163.com>
> > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > > ---
> > > >  arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > > index 0c18406e4c59..dd6fe964d618 100644
> > > > --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > > @@ -449,9 +449,9 @@ &uart1 {
> > > >  	bluetooth {
> > > >  		compatible = "brcm,bcm43438-bt";
> > > >  		clocks = <&pmucru CLK_RTC_32K>;
> > > > -		clock-names = "ext_clock";
> > > > -		device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > > > -		host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > > > +		clock-names = "extclk";
> > > > +		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > > > +		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > > >  		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
> > > >  		pinctrl-names = "default";
> > > >  		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
> > > 
> > > 
> 
> 

Re: [PATCH 5/8] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 3868 bytes --]

On Tue Oct 8, 2024 at 10:20 PM CEST, Heiko Stübner wrote:
> Am Montag, 7. Oktober 2024, 21:33:11 CEST schrieb Diederik de Haas:
> > On Mon Oct 7, 2024 at 6:04 PM CEST, Heiko Stübner wrote:
> > > Am Montag, 7. Oktober 2024, 17:27:12 CEST schrieb Diederik de Haas:
> > > > On Mon Sep 30, 2024 at 11:01 PM CEST, Heiko Stuebner wrote:
> > > > > The expected clock-name is different (ext_clock -> extclk) and the wakeup
> > > > 
> > > > According to "brcm,bluetooth.yaml", 'extclk' is deprecated in favor of
> > > > 'txco', so it seems better to use that?
> > > > Same would be true for Rock960 boards (patch 6 of this series).
> > >
> > > thanks for that catch. I mainly stumbled upon the "_" underscore, found the
> > > clockname without but didn't take into account that there was a deprecated
> > > flag set in the binding :-)
> > 
> > Doing research for another improvement, I stumbled upon this commit:
> > 
> > ebceec271e55 ("arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards")
> > 
> > with the following diff:
> > 
> > ```
> >  	sdio_pwrseq: sdio-pwrseq {
> >  		compatible = "mmc-pwrseq-simple";
> >  		clocks = <&rk808 1>;
> > -		clock-names = "ext_clock";
> > +		clock-names = "lpo";
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&wifi_enable_h>;
> >  		reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
> > ```
> > 
>
> The brcm,bluetooth binding is pretty clear, it's
> txco - for an "external reference clock, not a crystal"
> lpo - for a low power 32.768 kHz clock.
>
> The rk808 and also the pmucru are both "not crystals", so I'll just go
> with the "txco".
>
> The hci_bcm driver also handles txco and extclk the same, so there won't
> be a behaviour change with existing code.

Excellent. Thanks for verifying :-)

Cheers,
  Diederik

> > But do read the full git commit message.
> > 
> > The corresponding bluetooth node had 'lpo' as new value for
> > 'clock-names' though ... from "ext_clock", but it also changed
> > its compatible, so it's not the same. For details, see commit
> > f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards")
> > 
> > So it's possible the change needs to be more extensive.
> > And a Tested-by tag from someone with the board is probably a good idea.
> > 
> > Regards,
> >   Diederik
> > 
> > > > > gpio properties are named differently when changing from vendor-tree to
> > > > > mainline. So fix those to match the binding.
> > > > >
> > > > > Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board")
> > > > > Cc: Andy Yan <andyshrk@163.com>
> > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > > > ---
> > > > >  arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++---
> > > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > > > index 0c18406e4c59..dd6fe964d618 100644
> > > > > --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > > > > @@ -449,9 +449,9 @@ &uart1 {
> > > > >  	bluetooth {
> > > > >  		compatible = "brcm,bcm43438-bt";
> > > > >  		clocks = <&pmucru CLK_RTC_32K>;
> > > > > -		clock-names = "ext_clock";
> > > > > -		device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > > > > -		host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > > > > +		clock-names = "extclk";
> > > > > +		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > > > > +		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > > > >  		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
> > > > >  		pinctrl-names = "default";
> > > > >  		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
> > > > 
> > > > 
> > 
> > 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 6/8] arm64: dts: rockchip: Fix bluetooth properties on Rock960 boards

[Heiko Stuebner]

The expected clock-name is different (ext_clock -> extclk), so fix it
to match the binding.

Fixes: c72235c288c8 ("arm64: dts: rockchip: Add on-board WiFi/BT support for Rock960 boards")
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
index 8146f870d2bd..637088ca4c06 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
@@ -576,7 +576,7 @@ &uart0 {
 	bluetooth {
 		compatible = "brcm,bcm43438-bt";
 		clocks = <&rk808 1>;
-		clock-names = "ext_clock";
+		clock-names = "extclk";
 		device-wakeup-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_HIGH>;
 		host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
 		shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;
-- 
2.43.0

[PATCH 7/8] arm64: dts: rockchip: Remove undocumented emmc property from PX30-Ringneck

[Heiko Stuebner]

supports-emmc is an undocumented property that slipped into the mainline
kernel devicetree for the board. Drop it.

Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
index bb1aea82e666..b7163ed74232 100644
--- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
@@ -66,7 +66,6 @@ &emmc {
 	bus-width = <8>;
 	cap-mmc-highspeed;
 	mmc-hs200-1_8v;
-	supports-emmc;
 	mmc-pwrseq = <&emmc_pwrseq>;
 	non-removable;
 	vmmc-supply = <&vcc_3v3>;
-- 
2.43.0

Re: [PATCH 7/8] arm64: dts: rockchip: Remove undocumented emmc property from PX30-Ringneck

[Quentin Schulz]

Hi Heiko,

On 9/30/24 11:01 PM, Heiko Stuebner wrote:
> supports-emmc is an undocumented property that slipped into the mainline
> kernel devicetree for the board. Drop it.
> 
> Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
> Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

FYI:

$ git grep supports-emmc arch/arm64/boot/dts/rockchip
arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi:        supports-emmc;
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts: 
supports-emmc;
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts:        supports-emmc;
arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts:        supports-emmc;

So there's a few more to remove it seems :)

Thanks!
Quentin

Re: [PATCH 7/8] arm64: dts: rockchip: Remove undocumented emmc property from PX30-Ringneck

[Heiko Stübner]

Am Dienstag, 1. Oktober 2024, 12:04:00 CEST schrieb Quentin Schulz:
> Hi Heiko,
> 
> On 9/30/24 11:01 PM, Heiko Stuebner wrote:
> > supports-emmc is an undocumented property that slipped into the mainline
> > kernel devicetree for the board. Drop it.
> > 
> > Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
> > Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> FYI:
> 
> $ git grep supports-emmc arch/arm64/boot/dts/rockchip
> arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi:        supports-emmc;
> arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts: 
> supports-emmc;
> arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts:        supports-emmc;
> arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts:        supports-emmc;
> 
> So there's a few more to remove it seems :)

I've now amended the patch to remove all of them :-)

[PATCH 8/8] arm64: dts: rockchip: Remove #cooling-cells from fan on Theobroma boards

[Heiko Stuebner]

All Theobroma boards use a ti,amc6821 as fan controller.
It normally runs in an automatically controlled way and while it may be
possible to use it as part of a dt-based thermal management, this is
not yet specified in the binding, nor implemented in any kernel.

Newer boards already don't contain that #cooling-cells property, but
older ones do. So remove them for now, they can be re-added if thermal
integration gets implemented in the future.

Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
Fixes: d99a02bcfa81 ("arm64: dts: rockchip: add RK3368-uQ7 (Lion) SoM")
Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: Klaus Goger <klaus.goger@theobroma-systems.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 1 -
 arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi   | 1 -
 arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi   | 1 -
 3 files changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
index b7163ed74232..a6ea9d8c785c 100644
--- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
@@ -293,7 +293,6 @@ &i2c1 {
 	fan: fan@18 {
 		compatible = "ti,amc6821";
 		reg = <0x18>;
-		#cooling-cells = <2>;
 	};
 
 	rtc_twi: rtc@6f {
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
index 8ac8acf4082d..ab3fda69a1fb 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
@@ -61,7 +61,6 @@ i2c_lvds_blc: i2c@0 {
 			fan: fan@18 {
 				compatible = "ti,amc6821";
 				reg = <0x18>;
-				#cooling-cells = <2>;
 			};
 
 			rtc_twi: rtc@6f {
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
index 650b1ba9c192..6de3128556b7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
@@ -395,7 +395,6 @@ &i2c7 {
 	fan: fan@18 {
 		compatible = "ti,amc6821";
 		reg = <0x18>;
-		#cooling-cells = <2>;
 	};
 
 	rtc_twi: rtc@6f {
-- 
2.43.0

Re: [PATCH 8/8] arm64: dts: rockchip: Remove #cooling-cells from fan on Theobroma boards

[Quentin Schulz]

Hi Heiko,

On 9/30/24 11:01 PM, Heiko Stuebner wrote:
> All Theobroma boards use a ti,amc6821 as fan controller.
> It normally runs in an automatically controlled way and while it may be
> possible to use it as part of a dt-based thermal management, this is
> not yet specified in the binding, nor implemented in any kernel.
> 
> Newer boards already don't contain that #cooling-cells property, but
> older ones do. So remove them for now, they can be re-added if thermal
> integration gets implemented in the future.
> 
> Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
> Fixes: d99a02bcfa81 ("arm64: dts: rockchip: add RK3368-uQ7 (Lion) SoM")
> Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")
> Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> Cc: Klaus Goger <klaus.goger@theobroma-systems.com>

This has been tripping the dt-binding check for a while and since we've 
somehow not linked the fan controller to cpufreq for thermal throttling 
just yet, this was essentially not used.

As far as I know, no DT we wrote for customers had that linked either, 
so I think this is the most straightforward way to handle this rather 
than documenting this properly in the dt-binding and making sure the 
kernel driver actually supports it. As said, we can always revisit this 
later on if need be.

Therefore,

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin