From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 242F2C0015E for ; Sun, 9 Jul 2023 17:17:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbjGIRR1 (ORCPT ); Sun, 9 Jul 2023 13:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjGIRR0 (ORCPT ); Sun, 9 Jul 2023 13:17:26 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3FE3128 for ; Sun, 9 Jul 2023 10:17:22 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-51d95aed33aso4351264a12.3 for ; Sun, 09 Jul 2023 10:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688923041; x=1691515041; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7imIfml5dDYKBfen+YuD1TuRXW1lkvNFnc3KUcJLps4=; b=l918Kz85vywpW18YhZfRklEFcOgWqbeh8XXNjxVH6h7aJRFnTM04jwfnuvfsU6Fns9 pQM6rbRbUVMBuI/mYCcJGVbwvuCwBX+ot8M+iXoFHDKebWqcDtOLbD6TMmfWejjMxwz9 iJiSUK3KJvwoU9A6ujfHSJmg8zgUcbUBNJtBDazY7gdmr0Wc9POH9RDAf6tXnCP/fIBq qh7nnWixUjtqhfs9GWIu53NwJThtDttpSGXYb7qGpCw+PTAtZYayMJInXxpZqA9m4taY kDkAr5TV0+olIE3VPdlnOYUEP70ixJf0Rltsp8zP/weIp+mQ+ApFVfBeUYglMtga4WcE kOwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688923041; x=1691515041; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7imIfml5dDYKBfen+YuD1TuRXW1lkvNFnc3KUcJLps4=; b=eiR9Rhd5bURyCvYJKeZNUH4WDKxp1tu5s8aDjiaJoLnbIAH78Z1CRuWqn8t9zMRuxA fTwtFfet1yYATv5gxrxFK+FuWZju2ke2atuRH0nBT7033jA102pUN+8s65BJJ6JchgZS nPsgykkbG1cSEDtXWgQkmR4hwfwoHk2tZaNytAny6rx+3ngW7oOjtUT8Jnt8uIOhP32T 7Ehe83KbrRhBEzR2R3d0oelS8k7WfUyGWJk9o3ixOZ8bPJGwTtjVWF/6WXLzlOSOpH82 EBlbEdV2Ekhkn456p2q9aMTa0nPdwwFVCAzoCWZHDMXP3gXM3i/FM3GSrXZAUMrrvI3W P1XQ== X-Gm-Message-State: ABy/qLbvQI6MVA837bJVX/b1xRrhMBRy8p1UmWMnhhT3MWPGakyqL+x4 UjzAKz085QyyviS76ANJ0ifuWA== X-Google-Smtp-Source: APBJJlFQ0RX8bsto/VZSh3JnW0Z5X8xoCpF2ycuVh7baxg1T7oyywW3hEpAQxiuHj+2Ect/JOmEyNA== X-Received: by 2002:aa7:d287:0:b0:51c:dd99:a211 with SMTP id w7-20020aa7d287000000b0051cdd99a211mr8705245edq.27.1688923041327; Sun, 09 Jul 2023 10:17:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id t21-20020a170906179500b009929ab17be0sm4968222eje.162.2023.07.09.10.17.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jul 2023 10:17:20 -0700 (PDT) Message-ID: <935c14fd-e87f-e89b-f641-7fb529bc7e50@linaro.org> Date: Sun, 9 Jul 2023 19:17:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 01/11] iio: adc: Update bindings for ADC7 name used on QCOM PMICs To: Jishnu Prakash , agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, Jonathan.Cameron@huawei.com, sboyd@kernel.org, dmitry.baryshkov@linaro.org, quic_subbaram@quicinc.com, quic_collinsd@quicinc.com, quic_kamalw@quicinc.com, quic_jestar@quicinc.com, marijn.suijten@somainline.org, andriy.shevchenko@linux.intel.com, Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Luca Weiss , linux-iio@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Cc: linux-arm-msm-owner@vger.kernel.org References: <20230708072835.3035398-1-quic_jprakash@quicinc.com> <20230708072835.3035398-2-quic_jprakash@quicinc.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230708072835.3035398-2-quic_jprakash@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/07/2023 09:28, Jishnu Prakash wrote: > The name used initially for this version of Qualcomm Technologies, Inc. > PMIC ADC was ADC7, following the convention of calling the PMIC generation > PMIC7. However, the names were later amended internally to ADC5 Gen2 and > PMIC5 Gen2. In addition, the latest PMIC generation now is known as > PMIC5 Gen3 with ADC5 Gen3 supported on it. With this addition, it makes more > sense to correct the name for this version of ADCs to ADC5 Gen2 from ADC7. > Since this affects ADC devices across some PMICs, update the names accordingly. > > In order to avoid breaking the existing implementations of ADC7, add > support for ADC5 Gen2 first now and remove the ADC7 support in a later > patch. I don't understand and I do not see it explained, why do you remove ADC7. The patch is also doing way too many things at the same time... > > Signed-off-by: Jishnu Prakash > --- > .../bindings/iio/adc/qcom,spmi-vadc.yaml | 21 +++-- > .../bindings/thermal/qcom-spmi-adc-tm5.yaml | 16 ++-- > .../iio/qcom,spmi-adc5-gen2-pm8350.h | 64 +++++++++++++ > .../iio/qcom,spmi-adc5-gen2-pm8350b.h | 89 +++++++++++++++++++ > .../iio/qcom,spmi-adc5-gen2-pmk8350.h | 47 ++++++++++ > .../iio/qcom,spmi-adc5-gen2-pmr735a.h | 29 ++++++ > .../iio/qcom,spmi-adc5-gen2-pmr735b.h | 28 ++++++ > include/dt-bindings/iio/qcom,spmi-vadc.h | 77 ++++++++++++++++ Bindings are always separate patches. If this is commit for bindings, then: Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof