devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Kiran Gunda <kgunda@codeaurora.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Stephen Boyd <swboyd@chromium.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells
Date: Mon, 12 Dec 2022 14:35:09 +0100	[thread overview]
Message-ID: <93ad9c5d-784e-3cba-a34b-84f2ce4d3964@linaro.org> (raw)
In-Reply-To: <20221212133303.39610-1-krzysztof.kozlowski@linaro.org>



On 12.12.2022 14:32, Krzysztof Kozlowski wrote:
> The SPMI bus uses two address cells and zero size cells (secoond reg
secoond sounds very Dutch ;)

> entry - SPMI_USID - is not the size):
> 
>   spmi@c440000: #address-cells:0:0: 2 was expected
> 
> Fixes: 0f9dc5f09fbd ("arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Interesting that it worked with this wrong..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index eb1e1ea12ff6..906fb9343bcc 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3274,8 +3274,8 @@ spmi_bus: spmi@c440000 {
>  			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
>  			qcom,ee = <0>;
>  			qcom,channel = <0>;
> -			#address-cells = <1>;
> -			#size-cells = <1>;
> +			#address-cells = <2>;
> +			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
>  			cell-index = <0>;

  parent reply	other threads:[~2022-12-12 13:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 13:32 [PATCH 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski
2022-12-12 13:33 ` [PATCH 2/4] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski
2022-12-12 13:35   ` Konrad Dybcio
2022-12-12 19:06   ` Stephen Boyd
2022-12-12 13:33 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski
2022-12-12 13:36   ` Konrad Dybcio
2022-12-12 19:07   ` Stephen Boyd
2022-12-13  8:12   ` Johan Hovold
2022-12-12 13:33 ` [PATCH 4/4] arm64: dts: qcom: rename AOSS QMP node to pmu Krzysztof Kozlowski
2022-12-12 13:38   ` Konrad Dybcio
2022-12-12 13:46     ` Krzysztof Kozlowski
2022-12-12 19:08   ` Stephen Boyd
2022-12-13  7:54     ` Krzysztof Kozlowski
2022-12-12 13:35 ` Konrad Dybcio [this message]
2022-12-12 13:44   ` [PATCH 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski
2022-12-12 19:06 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93ad9c5d-784e-3cba-a34b-84f2ce4d3964@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgunda@codeaurora.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).