From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09D6C4167B for ; Mon, 12 Dec 2022 13:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232557AbiLLNf3 (ORCPT ); Mon, 12 Dec 2022 08:35:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232782AbiLLNfP (ORCPT ); Mon, 12 Dec 2022 08:35:15 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7BB113F16 for ; Mon, 12 Dec 2022 05:35:12 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id p36so18570879lfa.12 for ; Mon, 12 Dec 2022 05:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MGzgsLhNezUD7PNgCBNxbBoD6cziN3f3cTOWGqgJdSs=; b=KFMDsEBLwYUg6jC8sZIlBdFgty/Yg711fDd/ATLdnYGk/ourXjIyNCkr6ePgwAtGFu QAlDtq1V8zqihuMoroMjFluX7+6DcmNQNb1+LFeSY8JbUFnPR3GYxInWMQO5tMTN+0UQ lcihoyw1xt7TyvgpJ3wjhsGJBY6aSVZa0N0MpRHjZw/u6pu4jxL6UZ9Je2vNH8fHmWI4 yR9yaCO8zZLCPW+mw292oZNaVEWD0qWvpMc6OqlA8snwAKTzrUwxkuBX/JQhjX64lLJz JBRAAHhgMCIPYOitZUBJCdeXMgLYBOkggacz7L+NUuybxSKoS5D6VDw1xgbu2IfqHHrg 3U1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MGzgsLhNezUD7PNgCBNxbBoD6cziN3f3cTOWGqgJdSs=; b=Bs4y+iD/tAj0v4aMABsJ2sqnbxx5Ma99HnwLgC05LuDqqHOaaNP35hECAt3LmnXOzK iUbiy09KmzewhMTBOIw+Fq8A1mLkl0s4LTI5Jx8foPhwKwfgVPrPBfmiwHXaqfh6vmyi nqbdLpxLfWPtjWiK62H4YjK9E0/YA0nmsrIrlI5y7skgNBumvt0bcmsfd7oa1UkGaMs1 WJCmEqVFrdRD9HA4yykfxKt4rPrRwtram4QD/sSSJUdKN7KwMFoyb1JcGxA+12IPrNkZ 2UscRFIt+V5w6LBqCS6d00R8YIrJbubYkAJLHLNpJG+6tCPaXVhJxOb97enutDmWWAE0 SBnQ== X-Gm-Message-State: ANoB5plioZIqkuDtRrjgywFAKOIwPETjCkPiL3CQGLTvBCdXitoul4xx wZp64rr4vDpWqEIypHPisQIgjLpswht959a4 X-Google-Smtp-Source: AA0mqf4rjSEkJtJXHr8YIWhnA40c0BZCzmLAnoEl6SLL70B7+Jx+YyG808ghPI68uxGRVxoganIBNQ== X-Received: by 2002:a05:6512:1329:b0:4b5:853c:ed30 with SMTP id x41-20020a056512132900b004b5853ced30mr6929590lfu.23.1670852111129; Mon, 12 Dec 2022 05:35:11 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id y2-20020a196402000000b004b4823f02b0sm1626181lfb.152.2022.12.12.05.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 05:35:10 -0800 (PST) Message-ID: <93ad9c5d-784e-3cba-a34b-84f2ce4d3964@linaro.org> Date: Mon, 12 Dec 2022 14:35:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Kiran Gunda , Rajendra Nayak , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221212133303.39610-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221212133303.39610-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12.12.2022 14:32, Krzysztof Kozlowski wrote: > The SPMI bus uses two address cells and zero size cells (secoond reg secoond sounds very Dutch ;) > entry - SPMI_USID - is not the size): > > spmi@c440000: #address-cells:0:0: 2 was expected > > Fixes: 0f9dc5f09fbd ("arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device") > Signed-off-by: Krzysztof Kozlowski > --- Interesting that it worked with this wrong.. Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index eb1e1ea12ff6..906fb9343bcc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3274,8 +3274,8 @@ spmi_bus: spmi@c440000 { > interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>; > qcom,ee = <0>; > qcom,channel = <0>; > - #address-cells = <1>; > - #size-cells = <1>; > + #address-cells = <2>; > + #size-cells = <0>; > interrupt-controller; > #interrupt-cells = <4>; > cell-index = <0>;