From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D7A16DEDA for ; Wed, 10 Apr 2024 15:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712762813; cv=none; b=Ghmw0BzRYuPdZMCqSNyltTwoazHPAnvb5nho3R3BFsj9mK+Dv5X86VyScK+m9sq0BwYKus3Ya40Z40ZlQtkJpVEEp/aTcfURZmD72hd91q3ZKUnLh3KRHJ8lieugNeq+aWZOYb38xhjSfkeYaly19aI+5MXztfKe9RkqkX1bZ2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712762813; c=relaxed/simple; bh=Tzh3HzuL9qtr+kAU3aaWCI44iJG4sSqVhDvuw8Xj71Q=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=a/ulB7ugmEx8FMb1Q7ji6f7M0lbb5HyHSVtr3/F8juXU6yShxkX9sdW5PTVEjnbP2LTfdxhIcQJa8ewrDzgyPicU7hLXJ1mHg/AeIrCNDp68O1C3JK11KZtqth7erZryCoWJi5/Dy/iXMRUMGK9r3Qb72B6bQ3VqPRGzb1mNumM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=adZAze8U; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="adZAze8U" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-343f1957ffcso3090557f8f.0 for ; Wed, 10 Apr 2024 08:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712762810; x=1713367610; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=x3/WbimiOlydcOJLTLpJ2sk9aiLmvjCy78EJyBg7E8o=; b=adZAze8Ubq1ToiW77FtzzxvKCPLJgMEroNtmqLG0cmGgXQal/GhzHOeIqxHSY683ej OGyNW27xzRi2ei9WjkCDzrJCrmEdla06jwgF97fCfBAJhMN6cToJnq2gE/ec3dpGB0MM fvJMeuDanIJ76Zwy9o9++fJN6sQ3PfdmxY2SQ6P0EKU/Qh8vN9TXjfcev6ysSxIftKrr xh9r09XFgRWopqObx2f6x5kNG6N0fr4HYPAzrIRt95Tt8Wms1o/fxktED2r56zmNsvP6 l6wWDCV7E4njPWPfkXqajo3QqrAInYEhF7nDLA5mvmzrQ6XwmpeKaJ7mnmXvM29J+LJQ Es5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712762810; x=1713367610; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=x3/WbimiOlydcOJLTLpJ2sk9aiLmvjCy78EJyBg7E8o=; b=NRoRQN2vBuuTr6ddQ9C/5vpJdYcX93hFXaBUNCr2YYsNrJgoOvxm15TwEpfQVr+DSj 6FEk00C/G+D9i1Ns9UcuCnGfrd2d9tvKW+H7Kh5ObFzYQq2BH+Gw399aIKfSSG3OD0wJ 3ERTZBGRP/+yCzglyxM0C43mgfbzlEwPuMEb3uvz0+D6LjiVT0R1vG7jMGfN38D7fJ89 edAPUPIC7w6lQ+CGMY1CHl2kEaiwFQyShs3Dq/I06QJrgi1CnykJTKHUFPuR33fA7fcR ma0I1BQIzaa40vFl9pU2Djn+x0wv7doebdEIVNs2CBNCVaybdqJiSTMVW0oBn5RxlJn/ FGRw== X-Forwarded-Encrypted: i=1; AJvYcCVqi20sC+t5+/FmTJckXAL16QAlZMqDdkAp8X//7Fgdcz0pn/PWm+20T726ZJi3yGpt38+GY+EPJYBKr1yNU38E4w+2G5Q5p5UKYA== X-Gm-Message-State: AOJu0Yw/Bz0bO5ePAZNtT2BbbCaGXFajB56YELgj/O09kOSEwecTi6Q4 BqVgAgWJaLoSQeEzNBnIk2fjXeeHzlN4HshlIsz6CKm08nUB+gJWz8L3S8JSXPY= X-Google-Smtp-Source: AGHT+IH8FvGqImnbiE3kXfEgNWroZois6i/4/58Nz1OsQIgTD16pxjAuEAcEJPWAags4HUcbtmxbTQ== X-Received: by 2002:adf:f5ce:0:b0:343:c52a:7fc5 with SMTP id k14-20020adff5ce000000b00343c52a7fc5mr5062807wrp.18.1712762809587; Wed, 10 Apr 2024 08:26:49 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:760d:c2fa:a66b:fed3? ([2a01:e0a:982:cbb0:760d:c2fa:a66b:fed3]) by smtp.gmail.com with ESMTPSA id q18-20020adfcd92000000b00343e5f3a3e2sm13601037wrj.19.2024.04.10.08.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 08:26:49 -0700 (PDT) Message-ID: <93bf3b2e-bf42-42d2-b10a-5586ee9efc6b@linaro.org> Date: Wed, 10 Apr 2024 17:26:48 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] arm64: dts: qcom: sm8650: add description of CCI controllers To: Vladimir Zapolskiy , Bjorn Andersson , Konrad Dybcio , Jagadeesh Kona Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20240410074951.447898-1-vladimir.zapolskiy@linaro.org> <72816a9f-3c25-44d3-8386-9b561a8ae996@linaro.org> <4162174b-df35-4282-859e-84b0579ff91b@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/04/2024 17:19, Vladimir Zapolskiy wrote: > Hi Neil, > > On 4/10/24 16:50, neil.armstrong@linaro.org wrote: >> On 10/04/2024 15:11, Vladimir Zapolskiy wrote: >>> On 4/10/24 10:52, Neil Armstrong wrote: >>>> Hi, >>>> >>>> On 10/04/2024 09:49, Vladimir Zapolskiy wrote: >>>>> Qualcomm SM8650 SoC has three CCI controllers with two I2C busses >>>>> connected to each of them. >>>>> >>>>> The CCI controllers on SM8650 are compatible with the ones found on >>>>> many other older generations of Qualcomm SoCs. >>>>> >>>>> Signed-off-by: Vladimir Zapolskiy >>>>> --- >>>>> The change is based and depends on a patch series from Jagadeesh Kona: >>>>> >>>>>      https://lore.kernel.org/linux-arm-msm/20240321092529.13362-1-quic_jkona@quicinc.com/ >>>>> >>>>> It might be an option to add this change right to the series, >>>>> since it anyway requires a respin. >>>>> >>>>> A new compatible value "qcom,sm8650-cci" is NOT added to >>>>> Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml , because >>>>> the controller IP description and selection is covered by a generic >>>>> compatible value "qcom,msm8996-cci". >>>> >>>> You'll still need to add qcom,sm8650-cci to the "CCI v2" list in qcom,i2c-cci.yaml, >>>> otherwise the DTBS check fail, even if the fallback is already present. >>> >>> I do recognize the problem related to a build time warning, my motivation was >>> to follow the rationale described in commit 3e383dce513f >>> ("Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible""). >>> >>> For a similar sc8280xp-cci case it was asked by Konrad to drop a new >>> compatible, I kindly ask the reviewers and maintainers to stick to one >>> of the two contradicting asks. >> >> This is totally different, this commit added a new compatible that is used in the driver, >> while here, you use a per-soc compatible that is (for now), only used in DT and uses > > I'm confused, please elaborate what do you mean above by "this commit" and "here". > Could you please be more specific to avoid any possible disambiguation? "this" refer to "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible". > If you refer to the driver drivers/i2c/busses/i2c-qcom-cci.c, then there is no > difference between sc8280xp-cci and sm8650-cci. What is the total difference, > which you found? If there's no difference between sc8280xp-cci and sm8650-cci, then the policy says you need to _not_ add a new compatible in the driver, which is what you did here. > >> the generic "qcom,msm8996-cci" as a fallback because it is considered as beeing 99% >> compatible and no software change is needed. >> > > I have no objections to revert a "Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible"" > commit and to update the change for sm8650-cci accordingly, but as I've > already said it would be good to have and follow one common approach for both > cases, since I based my change on the maintainer's decision from the past. The "new" policy is to use a fallback of an already defined compatible if no driver change is needed, this is the case for the last year so far. And updating the yaml bindings for the new per-soc compatible is also a year-old policy, upstreaming of SM8550, SM8650 and X1E80100 have been done following this policy in order to : 1) reduce useless driver changes 2) have a fully verifiable DT against bindings, so we can ensure the DT is 100% valid against the bindings Neil > > -- > Best wishes, > Vladimir