From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Komal Bajaj <quic_kbajaj@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: Add base qcm6490 idp board dts
Date: Sat, 18 Nov 2023 02:11:37 +0100 [thread overview]
Message-ID: <93c5d2ad-02b2-425b-877b-9576318fe51e@linaro.org> (raw)
In-Reply-To: <20231117125056.32503-3-quic_kbajaj@quicinc.com>
On 17.11.2023 13:50, Komal Bajaj wrote:
> Add DTS for Qualcomm IDP platform using QCM6490 SoC.
> This adds debug uart, eMMC and usb support along with
> regulators found on this board.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
[...]
> + gpio-reserved-ranges = <32 2>, <48 4>;
Please describe what these pins are for, so e.g.:
gpio-reserved-ranges = <32 2>, /* spaghetti cooker */
<48 4>; /* fingerprint scanner */
aside from that, LGTM
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-11-18 1:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 12:50 [PATCH v4 0/3] Add support for qcm6490 idp and qcs6490 rb3gen2 board Komal Bajaj
2023-11-17 12:50 ` [PATCH v4 1/3] dt-bindings: arm: qcom: Add QCM6490 IDP and QCS6490 RB3Gen2 board Komal Bajaj
2023-11-17 13:04 ` Krzysztof Kozlowski
2023-11-17 12:50 ` [PATCH v4 2/3] arm64: dts: qcom: Add base qcm6490 idp board dts Komal Bajaj
2023-11-18 1:11 ` Konrad Dybcio [this message]
2023-11-17 12:50 ` [PATCH v4 3/3] arm64: dts: qcom: Add base qcs6490-rb3gen2 " Komal Bajaj
2023-11-18 1:11 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c5d2ad-02b2-425b-877b-9576318fe51e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).