From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB8B7C43334 for ; Tue, 28 Jun 2022 00:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242233AbiF1A6Y (ORCPT ); Mon, 27 Jun 2022 20:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242877AbiF1A6C (ORCPT ); Mon, 27 Jun 2022 20:58:02 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B3A31FCD8; Mon, 27 Jun 2022 17:57:53 -0700 (PDT) X-UUID: 7de6634356564aa38dea52b215b92404-20220628 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.7,REQID:71419e08-ef1a-4490-83b7-ad2d3f64d62d,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:87442a2,CLOUDID:3960ca62-0b3f-4b2c-b3a6-ed5c044366a0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 7de6634356564aa38dea52b215b92404-20220628 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 650197003; Tue, 28 Jun 2022 08:57:47 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Tue, 28 Jun 2022 08:57:46 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 28 Jun 2022 08:57:45 +0800 Message-ID: <93c6b7201533325cf7758637dd194a372f3c00c6.camel@mediatek.com> Subject: Re: [PATCH v2 2/4] dt-bindings: usb: mtk-xhci: Make all clocks required From: Chunfeng Yun To: "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" , Greg Kroah-Hartman , Matthias Brugger CC: AngeloGioacchino Del Regno , , Krzysztof Kozlowski , Rob Herring , , , , , Date: Tue, 28 Jun 2022 08:57:45 +0800 In-Reply-To: <20220623193702.817996-3-nfraprado@collabora.com> References: <20220623193702.817996-1-nfraprado@collabora.com> <20220623193702.817996-3-nfraprado@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Nícolas, On Thu, 2022-06-23 at 15:37 -0400, Nícolas F. R. A. Prado wrote: > All of the clocks listed in the binding are always wired to the XHCI > controller hardware blocks on all SoCs. The reason some clocks were > made > optional in the binding was to account for the fact that depending on > the SoC, some of the clocks might be fixed (ie not controlled by > software). > > Given that the devicetree should represent the hardware, make all > clocks > required in the binding. Subsequent patches will make the DTS changes > to > specify fixed-clocks for the clocks that aren't controllable. > > Signed-off-by: Nícolas F. R. A. Prado > > --- > > Changes in v2: > - Undid clock list changes that allowed middle clocks to be missing > from > v1 and made all clocks required instead > - Rewrote commit message and title > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 + > --- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk- > xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk- > xhci.yaml > index 63cbc2b62d18..1444d18ef9bc 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > @@ -67,7 +67,6 @@ properties: > maxItems: 1 > > clocks: > - minItems: 1 > items: > - description: Controller clock used by normal mode > - description: Reference clock used by low power mode etc > @@ -76,9 +75,8 @@ properties: > - description: controller clock > > clock-names: > - minItems: 1 > items: > - - const: sys_ck # required, the following ones are optional > + - const: sys_ck > - const: ref_ck > - const: mcu_ck > - const: dma_ck This patch causes more check warning, I prefer to leave dt-bindings unchanged, but just fix mt8195's dts warning instead, thanks a lot