From: Marek Vasut <marex@denx.de>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-remoteproc@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
Jacky Bai <ping.bai@nxp.com>, Ye Li <ye.li@nxp.com>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] remoteproc: imx_rproc: add start up delay
Date: Mon, 10 Jul 2023 18:31:00 +0200 [thread overview]
Message-ID: <93c72991-2e7f-0d49-c2be-06fbe5904356@denx.de> (raw)
In-Reply-To: <ZKwpl1ZGJcX2RmJb@p14s>
On 7/10/23 17:53, Mathieu Poirier wrote:
> On Sat, Jul 08, 2023 at 01:24:44AM +0200, Marek Vasut wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> There is case that after remoteproc start remote processor[M4], the M4
>> runs slow and before M4 finish its own rpmsg framework initialization,
>> linux sends out vring kick message, then M4 firmware drops the kick
>> message. Some NXP released Cortex-M[x] images has such limitation that
>> it requires linux sends out vring kick message after M4 firmware finish
>> its rpmsg framework initialization.
>>
>> Reviewed-by: Jacky Bai <ping.bai@nxp.com>
>> Reviewed-by: Ye Li <ye.li@nxp.com>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>> Note: picked from NXP downstream LF-6630-2 remoteproc: imx_rproc: add start up delay
>> https://github.com/nxp-imx/linux-imx.git 0b1b91c95b291a3b60d6224b13f6a95a75896abf
>> ---
>> Note: Literally all of the NXP BSP 2.13.0 firmware builds fail to boot
>> without this being set to something like 50..500 ms , so this is
>> rather useful to have.
>
> My stance on this hasn't changed - hacks such as these do not scale and are a
> nightmare to maintain. The problem should be fixed in the M4's firmware.
If the firmware cannot be updated, how do you propose that would be
fixed in the firmware ?
Frankly, I do not see much of an issue in maintaining driver-specific
mdelay().
next prev parent reply other threads:[~2023-07-10 16:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 23:24 [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Document fsl,startup-delay-ms Marek Vasut
2023-07-07 23:24 ` [PATCH 2/2] remoteproc: imx_rproc: add start up delay Marek Vasut
2023-07-10 15:53 ` Mathieu Poirier
2023-07-10 16:31 ` Marek Vasut [this message]
2023-07-10 1:22 ` [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Document fsl,startup-delay-ms Peng Fan
2023-07-10 9:13 ` Marek Vasut
2023-07-10 8:12 ` Krzysztof Kozlowski
2023-07-10 9:18 ` Marek Vasut
2023-07-10 12:52 ` Krzysztof Kozlowski
2023-07-10 13:46 ` Marek Vasut
2023-07-10 20:00 ` Krzysztof Kozlowski
2023-07-10 21:52 ` Marek Vasut
2023-07-10 22:01 ` Mathieu Poirier
2023-07-10 22:23 ` Marek Vasut
2023-07-11 6:58 ` Frieder Schrempf
2023-07-11 16:21 ` Mathieu Poirier
2023-07-20 12:39 ` Marek Vasut
2023-07-11 6:02 ` Krzysztof Kozlowski
2023-07-11 15:10 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c72991-2e7f-0d49-c2be-06fbe5904356@denx.de \
--to=marex@denx.de \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).