From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hsiao Chien Sung <shawn.sung@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Singo Chang <singo.chang@mediatek.com>,
Nancy Lin <nancy.lin@mediatek.com>,
Jason-JH Lin <jason-jh.lin@mediatek.com>,
Fei Shao <fshao@google.com>
Subject: Re: [PATCH v1 2/6] dt-bindings: reset: mt8188: Add reset control bits for VDOSYS1
Date: Wed, 7 Jun 2023 09:27:42 +0200 [thread overview]
Message-ID: <93eb3e7d-eff5-b040-5290-2de13699ed95@linaro.org> (raw)
In-Reply-To: <20230607061121.6732-3-shawn.sung@mediatek.com>
On 07/06/2023 08:11, Hsiao Chien Sung wrote:
> Add reset control bits for MT8188 VDOSYS1.
Double space -> one space.
>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> ---
> include/dt-bindings/reset/mt8188-resets.h | 12 ++++++++++++
This should be squashed with patch adding compatible.
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/dt-bindings/reset/mt8188-resets.h b/include/dt-bindings/reset/mt8188-resets.h
> index 377cdfda82a9..439a9a25ca19 100644
> --- a/include/dt-bindings/reset/mt8188-resets.h
> +++ b/include/dt-bindings/reset/mt8188-resets.h
> @@ -33,4 +33,16 @@
>
> #define MT8188_TOPRGU_SW_RST_NUM 24
>
> +/* VDOSYS1 */
> +#define MT8188_VDO1_RST_MERGE0_DL_ASYNC 9
Indices start from 0.
> +#define MT8188_VDO1_RST_MERGE1_DL_ASYNC 10
> +#define MT8188_VDO1_RST_MERGE2_DL_ASYNC 11
> +#define MT8188_VDO1_RST_MERGE3_DL_ASYNC 32
... and are continuous.
Commit explains here nothing that it is for existing reset, so you got
such review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-07 7:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 6:11 [PATCH v1 0/6] Add display driver for MT8188 VDOSYS1 Hsiao Chien Sung
2023-06-07 6:11 ` [PATCH v1 1/6] dt-bindings: display/mediatek: mt8188: Add documentations for VDOSYS1 Hsiao Chien Sung
2023-06-07 7:15 ` Rob Herring
2023-06-07 7:26 ` Krzysztof Kozlowski
2023-06-08 3:12 ` Shawn Sung (宋孝謙)
2023-06-09 1:05 ` Chun-Kuang Hu
2023-06-07 6:11 ` [PATCH v1 2/6] dt-bindings: reset: mt8188: Add reset control bits " Hsiao Chien Sung
2023-06-07 7:27 ` Krzysztof Kozlowski [this message]
2023-06-08 3:07 ` Shawn Sung (宋孝謙)
2023-06-07 7:37 ` AngeloGioacchino Del Regno
2023-06-07 7:51 ` AngeloGioacchino Del Regno
2023-06-08 3:01 ` Shawn Sung (宋孝謙)
2023-06-08 6:15 ` Shawn Sung (宋孝謙)
2023-06-08 7:56 ` Krzysztof Kozlowski
2023-06-07 6:11 ` [PATCH v1 3/6] soc: mediatek: mt8188: Support VDOSYS1 in mtk-mmsys Hsiao Chien Sung
2023-06-07 6:11 ` [PATCH v1 4/6] drm/mediatek: mt8188: Modify display driver for VDOSYS1 Hsiao Chien Sung
2023-06-07 7:20 ` AngeloGioacchino Del Regno
2023-06-09 1:26 ` Chun-Kuang Hu
2023-07-06 6:16 ` CK Hu (胡俊光)
2023-06-07 6:11 ` [PATCH v1 5/6] soc: mediatek: mt8188: Support VDOSYS1 PADDING in mtk-mmsys Hsiao Chien Sung
2023-06-07 6:11 ` [PATCH v1 6/6] drm/mediatek: mt8188: Add VDOSYS1 PADDING driver Hsiao Chien Sung
2023-06-07 7:36 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93eb3e7d-eff5-b040-5290-2de13699ed95@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fshao@google.com \
--cc=jason-jh.lin@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=shawn.sung@mediatek.com \
--cc=singo.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).