From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver
Date: Sat, 25 Jul 2026 13:14:02 +0300 [thread overview]
Message-ID: <940d7267-cdfb-4dbd-9b4a-6fcd26c4fd58@linaro.org> (raw)
In-Reply-To: <20260724-sk5jn5-v2-2-871d3b9a2e47@oss.qualcomm.com>
On 7/24/26 12:50, Wenmeng Liu wrote:
> Add a V4L2 sub-device driver for the Samsung S5KJN5, a 50 MP GBRG 10-bit
> RAW MIPI CSI-2 image sensor. The driver supports the 4096x3072 mode and
> exposes the standard controls (exposure, gain, vblank/hblank, test
> pattern).
>
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
<snip>
> +
> +static const struct s5kjn5_init_op s5kjn5_init_ops[] = {
> + { .reg = CCI_REG16(0xfcfc), .val = 0x4000 },
> + { .reg = CCI_REG16(0x0000), .val = 0x000e },
> + { .reg = CCI_REG16(0x0000), .val = 0x38e5 },
One more comment:
.val = S5KJN5_CHIP_ID
> + { .reg = CCI_REG16(0x6018), .val = 0x0001 },
> + { .reg = CCI_REG16(0x7002), .val = 0x0408 },
> + { .reg = CCI_REG16(0x6014), .val = 0x0001 },
> + { .reg = CCI_REG16(0xfcfc), .val = 0x2002 },
> + { .reg = CCI_REG16(0x1e92), .val = 0x8000 },
> + { .reg = CCI_REG8(0x1e84), .val = 0x28 },
> + { .reg = CCI_REG8(0x1e85), .val = 0x2b },
> + { .reg = CCI_REG8(0x1e86), .val = 0x03 },
> + { .reg = CCI_REG8(0x1e87), .val = 0x20 },
> + { .reg = CCI_REG16(0xfcfc), .val = 0x4000 },
> + { .reg = CCI_REG16(0x7002), .val = 0x0008 },
> + { .delay_us = 5000 },
--
Best wishes,
Vladimir
prev parent reply other threads:[~2026-07-25 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 9:50 [PATCH v2 0/2] media: i2c: Add Samsung S5KJN5 image sensor Wenmeng Liu
2026-07-24 9:50 ` [PATCH v2 1/2] dt-bindings: " Wenmeng Liu
2026-07-24 14:12 ` Vladimir Zapolskiy
2026-07-31 8:15 ` Wenmeng Liu
2026-07-24 9:50 ` [PATCH v2 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver Wenmeng Liu
2026-07-24 10:08 ` sashiko-bot
2026-07-25 7:22 ` Vladimir Zapolskiy
2026-07-31 8:24 ` Wenmeng Liu
2026-07-31 17:39 ` Vladimir Zapolskiy
2026-08-03 2:53 ` Wenmeng Liu
2026-07-25 10:14 ` Vladimir Zapolskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=940d7267-cdfb-4dbd-9b4a-6fcd26c4fd58@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox