From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3639FC64EC4 for ; Fri, 10 Mar 2023 09:28:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229550AbjCJJ2U (ORCPT ); Fri, 10 Mar 2023 04:28:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230182AbjCJJ1x (ORCPT ); Fri, 10 Mar 2023 04:27:53 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 887B776178 for ; Fri, 10 Mar 2023 01:25:30 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id h14so4415229wru.4 for ; Fri, 10 Mar 2023 01:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678440329; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d04M76ABv9OzEZj8YysWWEAPcORPfP75jP6XlG4gbJ0=; b=CR0IYjUTqCTanblIpmDaPhqx2DuEqmeYsW6tGNHLFjLe1Sda/h/WbKtLNZCgdAhSNM cMH6zz3NEyxUfAvi1KTPsTf4oO52OYj/6pJsOoSosqd+l2w6diiarlucRPQBrTzBQE7R DxHy+B4XsLFq58GDyTRUjbeYkDnwzH6lTopbg90BNSZrQ2vbC6u1/EkeZZ0OIaBm6oxq USLrYSxGCtV/rN+44qAInTrAJUr36XSkcNq8X+gaCi+os/0QLU2XhUxBDDRgBe9IGdw2 YcAV9G2p8PagBgUAsZGinp548RUEmc60aoYkyup/5UXziy6hKv2DLJ3cmiJLNCs01HjP h15g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678440329; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d04M76ABv9OzEZj8YysWWEAPcORPfP75jP6XlG4gbJ0=; b=cUjQqkT5vfkUErTMXVYI/VPHG5wLGX7AlBQm6Lp5/DKWEbvqz2t/dEavuyUaPWj5R5 hgObEIE74mxWFH58GRzYhm2NhGNmIJyIvtxm3AZDpWXK+hEmtD/AcTy2awwB4Unh8VG3 vDLTGx3yaYPXFflTmTHJim1eBPVTaVs10qhJWaQAShJPc2hJOubAncrt+wXv/ED+egam whzTh/zQjJye7EPLVDI0N1hZiAyVtCkyv1L3o7+iMS4EpmWUbhJdSFSRRp6+4ozBnDsR fSyZLao5uEoVM9hrHabzFnEVJDJmQQXViaGVFYwZamApX8Qx+ldU0D0b3QSORDAYETg5 8UKA== X-Gm-Message-State: AO0yUKUetVy8YfQqj0Rt1BNMRX0QbjXrlwahpdOTYye41tzZb7vIk9u/ wWrO3exf5qDLikOds8gBHbmjYw== X-Google-Smtp-Source: AK7set8Oah0vua0JkPc6VPqYUdh16gWo8Wktcn45jRNHsedDl72mZsYB5cjsWBu30eKo6bplbaEWgA== X-Received: by 2002:a5d:4a47:0:b0:2c7:cdf:e296 with SMTP id v7-20020a5d4a47000000b002c70cdfe296mr16434653wrs.66.1678440329086; Fri, 10 Mar 2023 01:25:29 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id j10-20020a5d564a000000b002c71dd1109fsm1614861wrw.47.2023.03.10.01.25.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 01:25:28 -0800 (PST) Message-ID: <944a5935-689a-2847-dc79-fadba0959a14@linaro.org> Date: Fri, 10 Mar 2023 09:25:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer Content-Language: en-US To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Miquel Raynal , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> <20230309122324.4b012a58@xps-13> From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/03/2023 11:52, Rafał Miłecki wrote: > > Rafał (me): > NVMEM cells should be registered as they are in the raw format. No size > adjustments should happen while registering them. If NVMEM cell requires > some read post-processing then its size should be adjusted *while* > reading. > > > Michael: > .read_post_process() should be realloc the buffer > > > Miquel: > While registering NVMEM cell its size should be already adjusted to > match what .read_post_process() is about to return. This is the behavior that I would expect, this is one time thing and cell sizes should be fixed before adding them. --srini