Re: [PATCH 2/3] dt-bindings: ata: qcom,ipq806x-ahci: use dtschema

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/07/2024 12:46, Rayyan Ansari wrote:
> Remove old text bindings and add ipq806x AHCI compatible to
> ahci-common.yaml, as well as its required properties.
> 

>  
>  allOf:
>    - $ref: ahci-common.yaml#
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,ipq806x-ahci
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 5
> +        clock-names:
> +          items:
> +            - const: slave_iface
> +            - const: iface
> +            - const: core
> +            - const: rxoob
> +            - const: pmalive
> +        assigned-clocks:
> +          minItems: 2
> +          maxItems: 2
> +        assigned-clock-rates:


assigned* should not be needed in the binding. You can drop these.

> +          items:
> +            - const: 100000000
> +            - const: 100000000
> +      required:
> +        - phys
> +        - phy-names
> +        - clocks
> +        - clock-names
> +        - assigned-clocks
> +        - assigned-clock-rates

Also from here.


Best regards,
Krzysztof