From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B052DC77B6F for ; Wed, 12 Apr 2023 15:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231239AbjDLP2R (ORCPT ); Wed, 12 Apr 2023 11:28:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbjDLP2R (ORCPT ); Wed, 12 Apr 2023 11:28:17 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0238511A for ; Wed, 12 Apr 2023 08:28:14 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id sh8so29764046ejc.10 for ; Wed, 12 Apr 2023 08:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681313293; x=1683905293; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w/f8fWx95RPy53FPFSPsxhx2yeOjkbYiJk0FpqalEok=; b=vwS4hlPbleuafP0JkJ+DqcRIjQtLA+RHSlatsgZN0E376IXiO3XOWyduiOswxM5yrG EOYE7gyWI4GRdYBJe2ZGle0t8VTVfYdZr5a4EcY1+d0+NWJEhhbljBOfUFU/j5hs194W yIMPj/UVYbEyoIZZq1p63Zi8hmR5O3+TBYrPQoYhafZu4FQ3Hl02NXQHHOYSImfMDHIU qujYUuPaY6WTqd7i0LMv41bkm4I5GjqJrFoGmjk4aMBBnTenWTLbUCqIjA/1rboQbFoV UaIuhCa1UCxP8/3X7G3EeknkU3uofDWuG9a4/eA0rPrSAeCaoi9t+sGtcEW7GSe6oVf6 eKrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681313293; x=1683905293; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w/f8fWx95RPy53FPFSPsxhx2yeOjkbYiJk0FpqalEok=; b=G67x2hPNl1ZVR0wiHxSqkr3Yb2OOdG8JQP50nQ1Fh06zKygwsRjiF5PNUpJT/6lkof L9Hpu5mQahmvj28yq5ZfDXNs21NWVPxFaLggwuWr+N4R9BsJDlqUt3dYhIXbzFVL3oy+ 0o2uGzw7QdE+6InpNfNDbO9oSD2Z8HCDFL4L7HlP7ygFvaW0bY9JN8UOwNVHKbny4xJX x3CDlqwSFJtcS80cwTOc/LP5kkTiQJOEUEEwRq8f7aAPtKlg/vI3TJe3NrUQcfrLryOC umpcMjHVe3c0xNXVaa08DK5zmxXrv+Qecgr47OOPZj5a/clIvhJDAP9S4Hibys/d5G95 V0LQ== X-Gm-Message-State: AAQBX9eu6VsHl7/f9BjimzrvpmDsJRQy5nDbzGx0+XZ5Dgk1P+SQCuZ7 BjCz1CuDZS8XUJQujyeQAEfxkQ== X-Google-Smtp-Source: AKy350YX5t8yue2OQEKwTNFVa2OOh6bs2nxsXA+6DD5d1N6SAjVTtGtqlOTDFST8C47ZXLf29jFHnw== X-Received: by 2002:a17:906:aac8:b0:94a:6f0d:389d with SMTP id kt8-20020a170906aac800b0094a6f0d389dmr7392883ejb.5.1681313293472; Wed, 12 Apr 2023 08:28:13 -0700 (PDT) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id e14-20020a50d4ce000000b00502b0b0d75csm7027802edj.46.2023.04.12.08.28.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 08:28:12 -0700 (PDT) Message-ID: <94590a79-cae3-7b88-8f02-0c356adf06b7@linaro.org> Date: Wed, 12 Apr 2023 16:28:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 2/7] dt-bindings: soundwire: qcom: add 16-bit sample interval Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Rao Mandadapu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Patrick Lai References: <20230403132503.62090-1-krzysztof.kozlowski@linaro.org> <20230403132503.62090-3-krzysztof.kozlowski@linaro.org> From: Srinivas Kandagatla In-Reply-To: <20230403132503.62090-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/04/2023 14:24, Krzysztof Kozlowski wrote: > The port sample interval was always 16-bit, split into low and high > bytes. This split was unnecessary, although harmless for older devices > because all of them used only lower byte (so values < 0xff). With > support for Soundwire controller on Qualcomm SM8550 and its devices, > both bytes will be used, thus add a new 'qcom,ports-sinterval' property > to allow 16-bit sample intervals. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/soundwire/qcom,soundwire.yaml | 22 +++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml > index c283c594fb5c..883b8be9be1b 100644 > --- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml > +++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml > @@ -86,7 +86,7 @@ properties: > qcom,ports-sinterval-low: > $ref: /schemas/types.yaml#/definitions/uint8-array > description: > - Sample interval low of each data port. > + Sample interval (only lowest byte) of each data port. > Out ports followed by In ports. Used for Sample Interval calculation. > Value of 0xff indicates that this option is not implemented > or applicable for the respective data port. > @@ -94,6 +94,19 @@ properties: > minItems: 3 > maxItems: 16 > > + qcom,ports-sinterval: > + $ref: /schemas/types.yaml#/definitions/uint32-array Should this not be ref: /schemas/types.yaml#/definitions/uint16-array ? --srini > + description: > + Sample interval of each data port. > + Out ports followed by In ports. Used for Sample Interval calculation. > + Value of 0xffff indicates that this option is not implemented > + or applicable for the respective data port. > + More info in MIPI Alliance SoundWire 1.0 Specifications. > + minItems: 3 > + maxItems: 16 > + items: > + maximum: 0xffff > + > qcom,ports-offset1: > $ref: /schemas/types.yaml#/definitions/uint8-array > description: > @@ -219,10 +232,15 @@ required: > - '#size-cells' > - qcom,dout-ports > - qcom,din-ports > - - qcom,ports-sinterval-low > - qcom,ports-offset1 > - qcom,ports-offset2 > > +oneOf: > + - required: > + - qcom,ports-sinterval-low > + - required: > + - qcom,ports-sinterval > + > additionalProperties: false > > examples: