From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marco Felsch <m.felsch@pengutronix.de>, Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Abel Vesa <abelvesa@kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Lucas Stach <l.stach@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
Date: Tue, 28 Feb 2023 09:10:42 +0100 [thread overview]
Message-ID: <947af937-3178-48ad-998f-b048245f3ffe@linaro.org> (raw)
In-Reply-To: <20230227200039.ugmtvpli6gvux3fi@pengutronix.de>
On 27/02/2023 21:00, Marco Felsch wrote:
>>>> + #sound-dai-cells = <0>;
>>>
>>> Please don't add it in front of the compatible and the reg property.
>>
>> The #address-cells and #size-cells are also always on top, why should the
>> #sound-dai-cells be any different ? Where should they be ?
>
> As of now my understanding of specifying a devicetree node was:
>
> node-name@reg-nr {
> compatible = "";
> reg = <>;
> // all pending properties below
> ...
> };
>
> @Rob, @Krzysztof:
> Is this a (unwritten) rule/policy?
>
Each platform has its own coding style around this but I am not aware of
a coding style which puts address and size cells at the top. To me it is
really odd placement. First property is always "compatible", as the most
important. Then for most platforms second is "reg", as the one easiest
to compare with unit address. Some platforms put status as last property.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-28 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 17:45 [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes Marek Vasut
2023-02-27 17:49 ` Fabio Estevam
2023-02-27 18:05 ` Adam Ford
2023-02-27 18:59 ` Marek Vasut
2023-02-27 19:01 ` Marco Felsch
2023-02-27 19:07 ` Marek Vasut
2023-02-27 20:00 ` Marco Felsch
2023-02-27 20:11 ` Marek Vasut
2023-02-28 8:10 ` Krzysztof Kozlowski [this message]
2023-02-28 20:13 ` Marek Vasut
2023-03-01 9:08 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=947af937-3178-48ad-998f-b048245f3ffe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abelvesa@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=luca.ceresoli@bootlin.com \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).