From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: david@ixit.cz, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: Add Samsung Galaxy Express support
Date: Sat, 27 May 2023 01:36:18 +0200 [thread overview]
Message-ID: <947e3212-f6ef-f00d-19c2-4f629af0e791@linaro.org> (raw)
In-Reply-To: <20230524230459.120681-5-guptarud@gmail.com>
On 25.05.2023 01:04, Rudraksha Gupta wrote:
> This adds a very basic device tree file for the Samsung Galaxy Express
> SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and
> USB.
>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/qcom-msm8960-samsung-expressatt.dts | 334 ++++++++++++++++++
> 2 files changed, 335 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 59829fc90315..12c90f263142 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1081,6 +1081,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8916-samsung-grandmax.dtb \
> qcom-msm8916-samsung-serranove.dtb \
> qcom-msm8960-cdp.dtb \
> + qcom-msm8960-samsung-expressatt.dtb \
> qcom-msm8974-lge-nexus5-hammerhead.dtb \
> qcom-msm8974-sony-xperia-rhine-amami.dtb \
> qcom-msm8974-sony-xperia-rhine-honami.dtb \
> diff --git a/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
> new file mode 100644
> index 000000000000..2d6f0def0589
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
> @@ -0,0 +1,334 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <dt-bindings/input/input.h>
> +
> +#include "qcom-msm8960.dtsi"
> +#include <dt-bindings/reset/qcom,gcc-msm8960.h>
> +
> +/ {
> + model = "Samsung Galaxy S3 SGH-I437";
Googling the model name, it seems to be officially sold as
"Samsung Galaxy Express", without any mention of the S3 bit.
Is that on purpose?
> + compatible = "samsung,expressatt", "qcom,msm8960";
> + chassis-type = "handset";
> +
> + aliases {
> + serial0 = &gsbi5_serial;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +&gsbi5 {
> + status = "okay";
> + qcom,mode = <GSBI_PROT_I2C_UART>;
Please ensure status is the last property within each node
> +};
> +
> +&gsbi5_serial {
> + status = "okay";
> +};
> +
> +/* eMMC */
> +&sdcc1 {
You may want to add aliases for mmc hosts (check e.g.
arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts)
> + status = "okay";
> + vmmc-supply = <&pm8921_l5>;
> +};
> +
> +/* External micro SD card */
> +&sdcc3 {
> + status = "okay";
> + vmmc-supply = <&pm8921_l6>;
> + vqmmc-supply = <&pm8921_l7>;
> +};
> +
> +&gsbi1 {
> + status = "okay";
> + qcom,mode = <GSBI_PROT_SPI>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi1_default>;
Please do
pinctrl-n
pinctrl-names
> +};
> +
> +&gsbi1_spi{
Add a space between 'i' and '{'
Konrad
> + status = "okay";
> +};
> +
> +&msmgpio {
> + spi1_default: spi1_default {
> + mux {
> + pins = "gpio6", "gpio7", "gpio9";
> + function = "gsbi1";
> + };
> +
> + mosi {
> + pins = "gpio6";
> + drive-strength = <12>;
> + bias-disable;
> + };
> +
> + miso {
> + pins = "gpio7";
> + drive-strength = <12>;
> + bias-disable;
> + };
> +
> + cs {
> + pins = "gpio8";
> + drive-strength = <12>;
> + bias-disable;
> + output-low;
> + };
> +
> + clk {
> + pins = "gpio9";
> + drive-strength = <12>;
> + bias-disable;
> + };
> + };
> +};
> +
> +
> +&rpm {
> + regulators {
> + compatible = "qcom,rpm-pm8921-regulators";
> + vin_lvs1_3_6-supply = <&pm8921_s4>;
> + vin_lvs2-supply = <&pm8921_s4>;
> + vin_lvs4_5_7-supply = <&pm8921_s4>;
> + vdd_ncp-supply = <&pm8921_l6>;
> + vdd_l1_l2_l12_l18-supply = <&pm8921_s4>;
> + vdd_l21_l23_l29-supply = <&pm8921_s8>;
> + vdd_l24-supply = <&pm8921_s1>;
> + vdd_l25-supply = <&pm8921_s1>;
> + vdd_l27-supply = <&pm8921_s7>;
> + vdd_l28-supply = <&pm8921_s7>;
> +
> + /* Buck SMPS */
> + pm8921_s1: s1 {
> + regulator-always-on;
> + regulator-min-microvolt = <1225000>;
> + regulator-max-microvolt = <1225000>;
> + qcom,switch-mode-frequency = <3200000>;
> + bias-pull-down;
> + };
> +
> + pm8921_s2: s2 {
> + regulator-min-microvolt = <1300000>;
> + regulator-max-microvolt = <1300000>;
> + qcom,switch-mode-frequency = <1600000>;
> + bias-pull-down;
> + };
> +
> + pm8921_s3: s3 {
> + regulator-min-microvolt = <500000>;
> + regulator-max-microvolt = <1150000>;
> + qcom,switch-mode-frequency = <4800000>;
> + bias-pull-down;
> + };
> +
> + pm8921_s4: s4 {
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + qcom,switch-mode-frequency = <1600000>;
> + bias-pull-down;
> + qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>;
> + };
> +
> + pm8921_s7: s7 {
> + regulator-min-microvolt = <1150000>;
> + regulator-max-microvolt = <1150000>;
> + qcom,switch-mode-frequency = <3200000>;
> + bias-pull-down;
> + };
> +
> + pm8921_s8: s8 {
> + regulator-always-on;
> + regulator-min-microvolt = <2050000>;
> + regulator-max-microvolt = <2050000>;
> + qcom,switch-mode-frequency = <1600000>;
> + bias-pull-down;
> + };
> +
> + /* PMOS LDO */
> + pm8921_l1: l1 {
> + regulator-always-on;
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l2: l2 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l3: l3 {
> + regulator-min-microvolt = <3075000>;
> + regulator-max-microvolt = <3300000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l4: l4 {
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l5: l5 {
> + regulator-min-microvolt = <2950000>;
> + regulator-max-microvolt = <2950000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l6: l6 {
> + regulator-min-microvolt = <2950000>;
> + regulator-max-microvolt = <2950000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l7: l7 {
> + regulator-always-on;
> + regulator-min-microvolt = <1850000>;
> + regulator-max-microvolt = <2950000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l8: l8 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3100000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l9: l9 {
> + regulator-min-microvolt = <2850000>;
> + regulator-max-microvolt = <2850000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l10: l10 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l11: l11 {
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <3300000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l12: l12 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l14: l14 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l15: l15 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2950000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l16: l16 {
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <3000000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l17: l17 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l18: l18 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1500000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l21: l21 {
> + regulator-min-microvolt = <1900000>;
> + regulator-max-microvolt = <1900000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l22: l22 {
> + regulator-min-microvolt = <2750000>;
> + regulator-max-microvolt = <2750000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l23: l23 {
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l24: l24 {
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <1150000>;
> + bias-pull-down;
> + };
> +
> + pm8921_l25: l25 {
> + regulator-always-on;
> + regulator-min-microvolt = <1225000>;
> + regulator-max-microvolt = <1225000>;
> + bias-pull-down;
> + };
> +
> + /* Low Voltage Switch */
> + pm8921_lvs1: lvs1 {
> + bias-pull-down;
> + };
> +
> + pm8921_lvs2: lvs2 {
> + bias-pull-down;
> + };
> +
> + pm8921_lvs3: lvs3 {
> + bias-pull-down;
> + };
> +
> + pm8921_lvs4: lvs4 {
> + bias-pull-down;
> + };
> +
> + pm8921_lvs5: lvs5 {
> + bias-pull-down;
> + };
> +
> + pm8921_lvs6: lvs6 {
> + bias-pull-down;
> + };
> +
> + pm8921_lvs7: lvs7 {
> + bias-pull-down;
> + };
> +
> + pm8921_ncp: ncp {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + qcom,switch-mode-frequency = <1600000>;
> + };
> + };
> +};
> +
> +&usb_hs1_phy {
> + v3p3-supply = <&pm8921_l3>;
> + v1p8-supply = <&pm8921_l4>;
> +};
> +
> +&usb1 {
> + status = "okay";
> + dr_mode = "otg";
> +};
> +
next prev parent reply other threads:[~2023-05-26 23:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 23:04 [PATCH 1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi Rudraksha Gupta
2023-05-24 23:04 ` [PATCH 2/5] ARM: Add samsung,expressatt to qcom.yaml Rudraksha Gupta
2023-05-30 13:19 ` Krzysztof Kozlowski
2023-05-24 23:04 ` [PATCH 3/5] ARM: Add qcom,usb-hs-phy-msm8960 to qcom,usb-hs-phy.yaml Rudraksha Gupta
2023-05-30 13:19 ` Krzysztof Kozlowski
2023-05-24 23:04 ` [PATCH 4/5] ARM: Blindly copy the usb node from apq8064.dtsi Rudraksha Gupta
2023-05-26 23:30 ` Konrad Dybcio
2023-05-24 23:04 ` [PATCH 5/5] ARM: Add Samsung Galaxy Express support Rudraksha Gupta
2023-05-26 23:36 ` Konrad Dybcio [this message]
2023-05-30 13:20 ` Krzysztof Kozlowski
2023-05-27 4:09 ` [PATCH 1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi Bjorn Andersson
2023-05-28 0:10 ` [PATCH v2 0/4] Samsung Galaxy Express SGH-I437 Support Rudraksha Gupta
2023-05-30 13:21 ` Krzysztof Kozlowski
2023-05-28 0:10 ` [PATCH v2 1/4] dt-bindings: arm: qcom: Add Samsung Galaxy Express Rudraksha Gupta
[not found] ` <20230528-decode-creasing-f5b3996163e5@spud>
2023-05-28 13:36 ` Rudraksha Gupta
2023-05-29 7:41 ` Konrad Dybcio
2023-05-29 22:28 ` Rudraksha Gupta
[not found] ` <20230529-bonsai-during-37a47a528ff3@spud>
2023-05-29 22:50 ` Rudraksha Gupta
2023-05-30 12:57 ` Krzysztof Kozlowski
2023-05-28 0:10 ` [PATCH v2 2/4] dt-bindings: Add qcom,usb-hs-phy-msm8960 Rudraksha Gupta
2023-05-30 13:22 ` Krzysztof Kozlowski
2023-05-31 2:49 ` Rudraksha Gupta
2023-05-31 2:56 ` Dmitry Baryshkov
2023-05-28 0:10 ` [PATCH v2 3/4] ARM: dts: qcom: msm8960: Add USB node Rudraksha Gupta
2023-05-30 13:22 ` Krzysztof Kozlowski
2023-05-28 0:10 ` [PATCH v2 4/4] ARM: dts: qcom: Add Samsung Galaxy Express support Rudraksha Gupta
2023-05-30 13:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=947e3212-f6ef-f00d-19c2-4f629af0e791@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).