devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joshua Clayton <stillcompiling@gmail.com>
To: Alan Tull <atull@kernel.org>,
	Moritz Fischer <moritz.fischer@ettus.com>,
	Anatolij Gustschin <agust@denx.de>,
	Bastian Stender <bst@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Joshua Clayton <stillcompiling@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 6/6] fpga-manager: altera-ps-spi: use bitrev8x4
Date: Fri,  2 Jun 2017 13:30:52 -0700	[thread overview]
Message-ID: <9486718188ff6ec3d4cb4e196b4caa33c5af48e1.1496434383.git.stillcompiling@gmail.com> (raw)
In-Reply-To: <684ea151ba9aa2c6555a299daf56552ddc11f596.1496434383.git.stillcompiling@gmail.com>
In-Reply-To: <20170525172911.11467-1-stillcompiling@gmail.com>

Speed up bit reversal by using hardware bit reversal
Add extra code to handle less than 4byte remnants, if any

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
 drivers/fpga/altera-ps-spi.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index 0db8def668ed..14f14efdf0d5 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -149,12 +149,23 @@ static int altera_ps_write_init(struct fpga_manager *mgr,
 
 static void rev_buf(char *buf, size_t len)
 {
-	const char *fw_end = (buf + len);
+	u32 *fw32 = (u32 *)buf;
+	size_t extra_bytes = (len & 0x03);
+	const u32 *fw_end = (u32 *)(buf + len - extra_bytes);
 
 	/* set buffer to lsb first */
-	while (buf < fw_end) {
-		*buf = bitrev8(*buf);
-		buf++;
+	while (fw32 < fw_end) {
+		*fw32 = bitrev8x4(*fw32);
+		fw32++;
+	}
+
+	if (extra_bytes) {
+		buf = (char *)fw_end;
+		while (extra_bytes) {
+			*buf = bitrev8(*buf);
+			buf++;
+			extra_bytes--;
+		}
 	}
 }
 
-- 
2.11.0

  parent reply	other threads:[~2017-06-02 20:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 17:29 [PATCH v11 0/6] FPGA Manager support for altera passive serial Joshua Clayton
2017-05-25 17:29 ` [PATCH v11 1/6] fpga: Add flag to indicate SPI bitstream is bit-reversed Joshua Clayton
     [not found] ` <20170525172911.11467-1-stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-25 17:29   ` [PATCH v11 2/6] doc: dt: add altera-ps-spi binding document Joshua Clayton
2017-05-25 17:29   ` [PATCH v11 3/6] fpga manager: Add altera-ps-spi driver for Altera FPGAs Joshua Clayton
2017-05-25 17:29   ` [PATCH v11 5/6] lib: add bitrev8x4() Joshua Clayton
2017-06-02 15:49   ` [PATCH v11 0/6] FPGA Manager support for altera passive serial Anatolij Gustschin
2017-06-02 20:30   ` [PATCH v12 1/6] fpga: Add flag to indicate SPI bitstream is bit-reversed Joshua Clayton
2017-06-05 15:11     ` Alan Tull
     [not found]   ` <684ea151ba9aa2c6555a299daf56552ddc11f596.1496434383.git.stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-02 20:30     ` [PATCH v12 3/6] fpga manager: Add altera-ps-spi driver for Altera FPGAs Joshua Clayton
2017-06-05 15:11       ` Alan Tull
2017-05-25 17:29 ` [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi Joshua Clayton
     [not found]   ` <20170525172911.11467-5-stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-02 16:30     ` Andreas Färber
     [not found]       ` <a4d0815c-593f-57a9-41fc-ab636ca9b9e5-l3A5Bk7waGM@public.gmane.org>
2017-06-02 19:39         ` stillcompiling-Re5JQEeQqe8AvxtiuMwx3w
2017-06-02 19:54           ` Andreas Färber
     [not found]             ` <b944db11-bdd2-5b5f-2aa8-01f4135918be-l3A5Bk7waGM@public.gmane.org>
2017-06-02 21:10               ` stillcompiling-Re5JQEeQqe8AvxtiuMwx3w
2017-06-05 15:10                 ` Alan Tull
2017-05-25 17:29 ` [PATCH v11 6/6] fpga-manager: altera-ps-spi: use bitrev8x4 Joshua Clayton
2017-06-02 20:30 ` [PATCH v12 2/6] doc: dt: document altera-passive-serial binding Joshua Clayton
     [not found]   ` <4945d90535e701e4e0207c08a7543a7623b94aeb.1496434383.git.stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-05 15:11     ` Alan Tull
2017-06-02 20:30 ` [PATCH v12 4/6] ARM: dts: imx6q-evi: support altera-ps-spi Joshua Clayton
     [not found]   ` <8253d3ad7de8ba991de9f23fd68b8f9502c1ffe0.1496434383.git.stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-05 15:12     ` Alan Tull
2017-06-02 20:30 ` [PATCH v12 5/6] lib: add bitrev8x4() Joshua Clayton
2017-06-05 15:12   ` Alan Tull
2017-06-02 20:30 ` Joshua Clayton [this message]
     [not found]   ` <9486718188ff6ec3d4cb4e196b4caa33c5af48e1.1496434383.git.stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-05 15:13     ` [PATCH v12 6/6] fpga-manager: altera-ps-spi: use bitrev8x4 Alan Tull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9486718188ff6ec3d4cb4e196b4caa33c5af48e1.1496434383.git.stillcompiling@gmail.com \
    --to=stillcompiling@gmail.com \
    --cc=agust@denx.de \
    --cc=atull@kernel.org \
    --cc=bst@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=moritz.fischer@ettus.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).