devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v14 0/3] Enable HDMI RX controller on RK3588
@ 2025-03-06  7:28 Dmitry Osipenko
  2025-03-06  7:28 ` [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Dmitry Osipenko
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: Dmitry Osipenko @ 2025-03-06  7:28 UTC (permalink / raw)
  To: Shreeya Patel, Heiko Stuebner, Mauro Carvalho Chehab,
	Hans Verkuil, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	jose.abreu, nelson.costa, shawn.wen, nicolas.dufresne,
	Sebastian Reichel
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

Hello Heiko,

This is a follow up to the v13 of HDMI RX patches [1]. Hans queued the
driver into the media tree. Now the DT patches are left to apply, could
you please take care of this series if it's good to you? Thanks

[1] https://lore.kernel.org/linux-media/20250304085819.108067-1-dmitry.osipenko@collabora.com/

Changelog:

v14: - Re-enabled LOAD_DEFAULT_EDID=y option in the defconfig and
       added ack from Hans Verkuil fot that patch.

Sebastian Reichel (2):
  arm64: dts: rockchip: Enable HDMI receiver on rock-5b
  arm64: defconfig: Enable Synopsys HDMI receiver

Shreeya Patel (1):
  arm64: dts: rockchip: Add device tree support for HDMI RX Controller

 .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
 .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
 .../boot/dts/rockchip/rk3588-rock-5b.dts      | 18 ++++++
 arch/arm64/configs/defconfig                  |  2 +
 4 files changed, 91 insertions(+)

-- 
2.48.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
  2025-03-06  7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
@ 2025-03-06  7:28 ` Dmitry Osipenko
  2025-03-06 13:06   ` Heiko Stübner
  2025-03-06  7:28 ` [PATCH v14 2/3] arm64: dts: rockchip: Enable HDMI receiver on rock-5b Dmitry Osipenko
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Dmitry Osipenko @ 2025-03-06  7:28 UTC (permalink / raw)
  To: Shreeya Patel, Heiko Stuebner, Mauro Carvalho Chehab,
	Hans Verkuil, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	jose.abreu, nelson.costa, shawn.wen, nicolas.dufresne,
	Sebastian Reichel
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

From: Shreeya Patel <shreeya.patel@collabora.com>

Add device tree support for Synopsys DesignWare HDMI RX
Controller.

Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Co-developed-by: Dingxian Wen <shawn.wen@rock-chips.com>
Signed-off-by: Dingxian Wen <shawn.wen@rock-chips.com>
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
 .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
 2 files changed, 71 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
index 7f874c77410c..2d4b9986a177 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
@@ -594,6 +594,20 @@ hdmim0_tx1_hpd: hdmim0-tx1-hpd {
 				/* hdmim0_tx1_hpd */
 				<1 RK_PA6 5 &pcfg_pull_none>;
 		};
+
+		/omit-if-no-ref/
+		hdmim1_rx: hdmim1-rx {
+			rockchip,pins =
+				/* hdmim1_rx_cec */
+				<3 RK_PD1 5 &pcfg_pull_none>,
+				/* hdmim1_rx_scl */
+				<3 RK_PD2 5 &pcfg_pull_none_smt>,
+				/* hdmim1_rx_sda */
+				<3 RK_PD3 5 &pcfg_pull_none_smt>,
+				/* hdmim1_rx_hpdin */
+				<3 RK_PD4 5 &pcfg_pull_none>;
+		};
+
 		/omit-if-no-ref/
 		hdmim1_rx_cec: hdmim1-rx-cec {
 			rockchip,pins =
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
index 4a950907ea6f..b7d06f93c8ce 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
@@ -7,6 +7,30 @@
 #include "rk3588-extra-pinctrl.dtsi"
 
 / {
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		/*
+		 * The 4k HDMI capture controller works only with 32bit
+		 * phys addresses and doesn't support IOMMU. HDMI RX CMA
+		 * must be reserved below 4GB.
+		 * The size of 160MB was determined as follows:
+		 * (3840 * 2160 pixels) * (4 bytes/pixel) * (2 frames/buffer) / 10^6 = 66MB
+		 * To ensure sufficient support for practical use-cases,
+		 * we doubled the 66MB value.
+		 */
+		hdmi_receiver_cma: hdmi-receiver-cma {
+			compatible = "shared-dma-pool";
+			alloc-ranges = <0x0 0x0 0x0 0xffffffff>;
+			size = <0x0 (160 * 0x100000)>; /* 160MiB */
+			alignment = <0x0 0x40000>; /* 64K */
+			no-map;
+			status = "disabled";
+		};
+	};
+
 	usb_host1_xhci: usb@fc400000 {
 		compatible = "rockchip,rk3588-dwc3", "snps,dwc3";
 		reg = <0x0 0xfc400000 0x0 0x400000>;
@@ -135,6 +159,39 @@ i2s10_8ch: i2s@fde00000 {
 		status = "disabled";
 	};
 
+	hdmi_receiver: hdmi_receiver@fdee0000 {
+		compatible = "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx";
+		reg = <0x0 0xfdee0000 0x0 0x6000>;
+		power-domains = <&power RK3588_PD_VO1>;
+		rockchip,grf = <&sys_grf>;
+		rockchip,vo1-grf = <&vo1_grf>;
+		interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH 0>,
+			     <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH 0>,
+			     <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH 0>;
+		interrupt-names = "cec", "hdmi", "dma";
+		clocks = <&cru ACLK_HDMIRX>,
+			 <&cru CLK_HDMIRX_AUD>,
+			 <&cru CLK_CR_PARA>,
+			 <&cru PCLK_HDMIRX>,
+			 <&cru CLK_HDMIRX_REF>,
+			 <&cru PCLK_S_HDMIRX>,
+			 <&cru HCLK_VO1>;
+		clock-names = "aclk",
+			      "audio",
+			      "cr_para",
+			      "pclk",
+			      "ref",
+			      "hclk_s_hdmirx",
+			      "hclk_vo1";
+		resets = <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>,
+			 <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>;
+		reset-names = "axi", "apb", "ref", "biu";
+		memory-region = <&hdmi_receiver_cma>;
+		pinctrl-0 = <&hdmim1_rx>;
+		pinctrl-names = "default";
+		status = "disabled";
+	};
+
 	pcie3x4: pcie@fe150000 {
 		compatible = "rockchip,rk3588-pcie", "rockchip,rk3568-pcie";
 		#address-cells = <3>;
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v14 2/3] arm64: dts: rockchip: Enable HDMI receiver on rock-5b
  2025-03-06  7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
  2025-03-06  7:28 ` [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Dmitry Osipenko
@ 2025-03-06  7:28 ` Dmitry Osipenko
  2025-03-06 13:07   ` Heiko Stübner
  2025-03-06  7:28 ` [PATCH v14 3/3] arm64: defconfig: Enable Synopsys HDMI receiver Dmitry Osipenko
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Dmitry Osipenko @ 2025-03-06  7:28 UTC (permalink / raw)
  To: Shreeya Patel, Heiko Stuebner, Mauro Carvalho Chehab,
	Hans Verkuil, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	jose.abreu, nelson.costa, shawn.wen, nicolas.dufresne,
	Sebastian Reichel
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

From: Sebastian Reichel <sebastian.reichel@collabora.com>

The Rock 5B has a Micro HDMI port, which can be used for receiving
HDMI data. This enables support for it.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 .../arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index d597112f1d5b..377824e69e20 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -220,6 +220,18 @@ hdmi0_out_con: endpoint {
 	};
 };
 
+&hdmi_receiver_cma {
+	status = "okay";
+};
+
+&hdmi_receiver {
+	status = "okay";
+	hpd-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>;
+	pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_hpd>;
+	pinctrl-names = "default";
+	memory-region = <&hdmi_receiver_cma>;
+};
+
 &hdptxphy_hdmi0 {
 	status = "okay";
 };
@@ -377,6 +389,12 @@ &pcie3x4 {
 };
 
 &pinctrl {
+	hdmirx {
+		hdmirx_hpd: hdmirx-5v-detection {
+			rockchip,pins = <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	hym8563 {
 		hym8563_int: hym8563-int {
 			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v14 3/3] arm64: defconfig: Enable Synopsys HDMI receiver
  2025-03-06  7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
  2025-03-06  7:28 ` [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Dmitry Osipenko
  2025-03-06  7:28 ` [PATCH v14 2/3] arm64: dts: rockchip: Enable HDMI receiver on rock-5b Dmitry Osipenko
@ 2025-03-06  7:28 ` Dmitry Osipenko
  2025-03-06  9:26 ` [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Heiko Stübner
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: Dmitry Osipenko @ 2025-03-06  7:28 UTC (permalink / raw)
  To: Shreeya Patel, Heiko Stuebner, Mauro Carvalho Chehab,
	Hans Verkuil, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	jose.abreu, nelson.costa, shawn.wen, nicolas.dufresne,
	Sebastian Reichel
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

From: Sebastian Reichel <sebastian.reichel@collabora.com>

The Rockchip RK3588 has a built-in HDMI receiver block from
Synopsys. Let's enable the driver for it.

Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index cb7da4415599..3dccc9e1c4aa 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -859,6 +859,8 @@ CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC=m
 CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
 CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
 CONFIG_VIDEO_SUN6I_CSI=m
+CONFIG_VIDEO_SYNOPSYS_HDMIRX=m
+CONFIG_VIDEO_SYNOPSYS_HDMIRX_LOAD_DEFAULT_EDID=y
 CONFIG_VIDEO_TI_J721E_CSI2RX=m
 CONFIG_VIDEO_HANTRO=m
 CONFIG_VIDEO_IMX219=m
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 0/3] Enable HDMI RX controller on RK3588
  2025-03-06  7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
                   ` (2 preceding siblings ...)
  2025-03-06  7:28 ` [PATCH v14 3/3] arm64: defconfig: Enable Synopsys HDMI receiver Dmitry Osipenko
@ 2025-03-06  9:26 ` Heiko Stübner
  2025-03-06  9:41   ` Hans Verkuil
  2025-03-06 13:09 ` (subset) " Heiko Stuebner
  2025-03-06 17:47 ` Rob Herring (Arm)
  5 siblings, 1 reply; 14+ messages in thread
From: Heiko Stübner @ 2025-03-06  9:26 UTC (permalink / raw)
  To: Shreeya Patel, Mauro Carvalho Chehab, Hans Verkuil, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, jose.abreu, nelson.costa,
	shawn.wen, nicolas.dufresne, Sebastian Reichel, Dmitry Osipenko
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

Hi Dmitry,

Am Donnerstag, 6. März 2025, 08:28:39 MEZ schrieb Dmitry Osipenko:
> This is a follow up to the v13 of HDMI RX patches [1]. Hans queued the
> driver into the media tree. Now the DT patches are left to apply, could
> you please take care of this series if it's good to you? Thanks
> 
> [1] https://lore.kernel.org/linux-media/20250304085819.108067-1-dmitry.osipenko@collabora.com/

Linux-Media, has this strange "applied" reporting thing going, so neither
the thread reports that nor does https://git.linuxtv.org/ show the commits
yet.

If you see the driver patches appear on https://git.linuxtv.org/ before I do,
please ping this thread :-)


Thanks a lot
Heiko


> 
> Changelog:
> 
> v14: - Re-enabled LOAD_DEFAULT_EDID=y option in the defconfig and
>        added ack from Hans Verkuil fot that patch.
> 
> Sebastian Reichel (2):
>   arm64: dts: rockchip: Enable HDMI receiver on rock-5b
>   arm64: defconfig: Enable Synopsys HDMI receiver
> 
> Shreeya Patel (1):
>   arm64: dts: rockchip: Add device tree support for HDMI RX Controller
> 
>  .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
>  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 18 ++++++
>  arch/arm64/configs/defconfig                  |  2 +
>  4 files changed, 91 insertions(+)
> 
> 





^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 0/3] Enable HDMI RX controller on RK3588
  2025-03-06  9:26 ` [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Heiko Stübner
@ 2025-03-06  9:41   ` Hans Verkuil
  2025-03-06  9:44     ` Heiko Stübner
  0 siblings, 1 reply; 14+ messages in thread
From: Hans Verkuil @ 2025-03-06  9:41 UTC (permalink / raw)
  To: Heiko Stübner, Shreeya Patel, Mauro Carvalho Chehab,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, jose.abreu,
	nelson.costa, shawn.wen, nicolas.dufresne, Sebastian Reichel,
	Dmitry Osipenko
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

On 06/03/2025 10:26, Heiko Stübner wrote:
> Hi Dmitry,
> 
> Am Donnerstag, 6. März 2025, 08:28:39 MEZ schrieb Dmitry Osipenko:
>> This is a follow up to the v13 of HDMI RX patches [1]. Hans queued the
>> driver into the media tree. Now the DT patches are left to apply, could
>> you please take care of this series if it's good to you? Thanks
>>
>> [1] https://lore.kernel.org/linux-media/20250304085819.108067-1-dmitry.osipenko@collabora.com/
> 
> Linux-Media, has this strange "applied" reporting thing going, so neither
> the thread reports that nor does https://git.linuxtv.org/ show the commits
> yet.
> 
> If you see the driver patches appear on https://git.linuxtv.org/ before I do,
> please ping this thread :-)

Patches are merged here first:

https://gitlab.freedesktop.org/linux-media/media-committers

That's where all the new code lands.

With a two day delay (if I am not mistaken) they will arrive on the
https://git.linuxtv.org/media.git/ tree.

If it is in the media-committers tree, then it is OK to take dts etc.
patches.

Regards,

	Hans

> 
> 
> Thanks a lot
> Heiko
> 
> 
>>
>> Changelog:
>>
>> v14: - Re-enabled LOAD_DEFAULT_EDID=y option in the defconfig and
>>        added ack from Hans Verkuil fot that patch.
>>
>> Sebastian Reichel (2):
>>   arm64: dts: rockchip: Enable HDMI receiver on rock-5b
>>   arm64: defconfig: Enable Synopsys HDMI receiver
>>
>> Shreeya Patel (1):
>>   arm64: dts: rockchip: Add device tree support for HDMI RX Controller
>>
>>  .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
>>  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
>>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 18 ++++++
>>  arch/arm64/configs/defconfig                  |  2 +
>>  4 files changed, 91 insertions(+)
>>
>>
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 0/3] Enable HDMI RX controller on RK3588
  2025-03-06  9:41   ` Hans Verkuil
@ 2025-03-06  9:44     ` Heiko Stübner
  0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2025-03-06  9:44 UTC (permalink / raw)
  To: Shreeya Patel, Mauro Carvalho Chehab, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, jose.abreu, nelson.costa,
	shawn.wen, nicolas.dufresne, Sebastian Reichel, Dmitry Osipenko,
	Hans Verkuil
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

Hi Hans,

Am Donnerstag, 6. März 2025, 10:41:46 MEZ schrieb Hans Verkuil:
> On 06/03/2025 10:26, Heiko Stübner wrote:
> > Hi Dmitry,
> > 
> > Am Donnerstag, 6. März 2025, 08:28:39 MEZ schrieb Dmitry Osipenko:
> >> This is a follow up to the v13 of HDMI RX patches [1]. Hans queued the
> >> driver into the media tree. Now the DT patches are left to apply, could
> >> you please take care of this series if it's good to you? Thanks
> >>
> >> [1] https://lore.kernel.org/linux-media/20250304085819.108067-1-dmitry.osipenko@collabora.com/
> > 
> > Linux-Media, has this strange "applied" reporting thing going, so neither
> > the thread reports that nor does https://git.linuxtv.org/ show the commits
> > yet.
> > 
> > If you see the driver patches appear on https://git.linuxtv.org/ before I do,
> > please ping this thread :-)
> 
> Patches are merged here first:
> 
> https://gitlab.freedesktop.org/linux-media/media-committers

aaaah, that was the missing piece of the puzzle.

I remember reading that media also switched to a multi-comitter model,
but didn't realize that this might entail a different host.

So thanks for the pointer.

Heiko


> 
> That's where all the new code lands.
> 
> With a two day delay (if I am not mistaken) they will arrive on the
> https://git.linuxtv.org/media.git/ tree.
> 
> If it is in the media-committers tree, then it is OK to take dts etc.
> patches.
> 
> Regards,
> 
> 	Hans
> 
> > 
> > 
> > Thanks a lot
> > Heiko
> > 
> > 
> >>
> >> Changelog:
> >>
> >> v14: - Re-enabled LOAD_DEFAULT_EDID=y option in the defconfig and
> >>        added ack from Hans Verkuil fot that patch.
> >>
> >> Sebastian Reichel (2):
> >>   arm64: dts: rockchip: Enable HDMI receiver on rock-5b
> >>   arm64: defconfig: Enable Synopsys HDMI receiver
> >>
> >> Shreeya Patel (1):
> >>   arm64: dts: rockchip: Add device tree support for HDMI RX Controller
> >>
> >>  .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
> >>  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
> >>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 18 ++++++
> >>  arch/arm64/configs/defconfig                  |  2 +
> >>  4 files changed, 91 insertions(+)
> >>
> >>
> > 
> > 
> > 
> > 
> 
> 





^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
  2025-03-06  7:28 ` [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Dmitry Osipenko
@ 2025-03-06 13:06   ` Heiko Stübner
  2025-03-06 15:53     ` Dmitry Osipenko
  0 siblings, 1 reply; 14+ messages in thread
From: Heiko Stübner @ 2025-03-06 13:06 UTC (permalink / raw)
  To: Shreeya Patel, Mauro Carvalho Chehab, Hans Verkuil, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, jose.abreu, nelson.costa,
	shawn.wen, nicolas.dufresne, Sebastian Reichel, Dmitry Osipenko
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

Hi Dmitry,

Am Donnerstag, 6. März 2025, 08:28:40 MEZ schrieb Dmitry Osipenko:
> From: Shreeya Patel <shreeya.patel@collabora.com>
> 
> Add device tree support for Synopsys DesignWare HDMI RX
> Controller.
> 
> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Co-developed-by: Dingxian Wen <shawn.wen@rock-chips.com>
> Signed-off-by: Dingxian Wen <shawn.wen@rock-chips.com>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
>  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
>  2 files changed, 71 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
> index 7f874c77410c..2d4b9986a177 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
> @@ -594,6 +594,20 @@ hdmim0_tx1_hpd: hdmim0-tx1-hpd {
>  				/* hdmim0_tx1_hpd */
>  				<1 RK_PA6 5 &pcfg_pull_none>;
>  		};
> +
> +		/omit-if-no-ref/
> +		hdmim1_rx: hdmim1-rx {
> +			rockchip,pins =
> +				/* hdmim1_rx_cec */
> +				<3 RK_PD1 5 &pcfg_pull_none>,
> +				/* hdmim1_rx_scl */
> +				<3 RK_PD2 5 &pcfg_pull_none_smt>,
> +				/* hdmim1_rx_sda */
> +				<3 RK_PD3 5 &pcfg_pull_none_smt>,
> +				/* hdmim1_rx_hpdin */
> +				<3 RK_PD4 5 &pcfg_pull_none>;
> +		};
> +

what's the reason for duplicating these pinctrl entries?

The base-pinctrl already contains a separate set of pins (and also a
variant for the m0 set of pins), so why not check and use the already
existing ones:

                hdmim1_rx_cec: hdmim1-rx-cec {
                        rockchip,pins =
                                /* hdmim1_rx_cec */
                                <3 RK_PD1 5 &pcfg_pull_none>;
                };

                hdmim1_rx_hpdin: hdmim1-rx-hpdin {
                        rockchip,pins =
                                /* hdmim1_rx_hpdin */
                                <3 RK_PD4 5 &pcfg_pull_none>;
                };

                hdmim1_rx_scl: hdmim1-rx-scl {
                        rockchip,pins =
                                /* hdmim1_rx_scl */
                                <3 RK_PD2 5 &pcfg_pull_none>;
                };

                hdmim1_rx_sda: hdmim1-rx-sda {
                        rockchip,pins =
                                /* hdmim1_rx_sda */
                                <3 RK_PD3 5 &pcfg_pull_none>;
                };


Having multiple sets (even with differeing settings) will cause confusion
later on.


>  		/omit-if-no-ref/
>  		hdmim1_rx_cec: hdmim1-rx-cec {
>  			rockchip,pins =
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> index 4a950907ea6f..b7d06f93c8ce 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> @@ -135,6 +159,39 @@ i2s10_8ch: i2s@fde00000 {
>  		status = "disabled";
>  	};
>  
> +	hdmi_receiver: hdmi_receiver@fdee0000 {
> +		compatible = "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx";
> +		reg = <0x0 0xfdee0000 0x0 0x6000>;
> +		power-domains = <&power RK3588_PD_VO1>;
> +		rockchip,grf = <&sys_grf>;
> +		rockchip,vo1-grf = <&vo1_grf>;
> +		interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH 0>,
> +			     <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH 0>,
> +			     <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH 0>;
> +		interrupt-names = "cec", "hdmi", "dma";
> +		clocks = <&cru ACLK_HDMIRX>,
> +			 <&cru CLK_HDMIRX_AUD>,
> +			 <&cru CLK_CR_PARA>,
> +			 <&cru PCLK_HDMIRX>,
> +			 <&cru CLK_HDMIRX_REF>,
> +			 <&cru PCLK_S_HDMIRX>,
> +			 <&cru HCLK_VO1>;
> +		clock-names = "aclk",
> +			      "audio",
> +			      "cr_para",
> +			      "pclk",
> +			      "ref",
> +			      "hclk_s_hdmirx",
> +			      "hclk_vo1";
> +		resets = <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>,
> +			 <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>;
> +		reset-names = "axi", "apb", "ref", "biu";
> +		memory-region = <&hdmi_receiver_cma>;
> +		pinctrl-0 = <&hdmim1_rx>;
> +		pinctrl-names = "default";

hmm, this might be better living in the board dts?

Heiko



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 2/3] arm64: dts: rockchip: Enable HDMI receiver on rock-5b
  2025-03-06  7:28 ` [PATCH v14 2/3] arm64: dts: rockchip: Enable HDMI receiver on rock-5b Dmitry Osipenko
@ 2025-03-06 13:07   ` Heiko Stübner
  0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2025-03-06 13:07 UTC (permalink / raw)
  To: Shreeya Patel, Mauro Carvalho Chehab, Hans Verkuil, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, jose.abreu, nelson.costa,
	shawn.wen, nicolas.dufresne, Sebastian Reichel, Dmitry Osipenko
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

Am Donnerstag, 6. März 2025, 08:28:41 MEZ schrieb Dmitry Osipenko:
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> The Rock 5B has a Micro HDMI port, which can be used for receiving
> HDMI data. This enables support for it.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  .../arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index d597112f1d5b..377824e69e20 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -220,6 +220,18 @@ hdmi0_out_con: endpoint {
>  	};
>  };
>  
> +&hdmi_receiver_cma {
> +	status = "okay";
> +};
> +
> +&hdmi_receiver {
> +	status = "okay";
> +	hpd-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>;
> +	pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_hpd>;
> +	pinctrl-names = "default";
> +	memory-region = <&hdmi_receiver_cma>;

nit: property sorting, alphabetical ... but with status at the end

Heiko



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: (subset) [PATCH v14 0/3] Enable HDMI RX controller on RK3588
  2025-03-06  7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
                   ` (3 preceding siblings ...)
  2025-03-06  9:26 ` [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Heiko Stübner
@ 2025-03-06 13:09 ` Heiko Stuebner
  2025-03-06 17:47 ` Rob Herring (Arm)
  5 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2025-03-06 13:09 UTC (permalink / raw)
  To: Shreeya Patel, Mauro Carvalho Chehab, Hans Verkuil, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, jose.abreu, nelson.costa,
	shawn.wen, nicolas.dufresne, Sebastian Reichel, Dmitry Osipenko
  Cc: Heiko Stuebner, kernel, linux-media, devicetree, linux-kernel,
	linux-rockchip, Tim Surber, Christophe JAILLET, Diederik de Haas


On Thu, 06 Mar 2025 10:28:39 +0300, Dmitry Osipenko wrote:
> This is a follow up to the v13 of HDMI RX patches [1]. Hans queued the
> driver into the media tree. Now the DT patches are left to apply, could
> you please take care of this series if it's good to you? Thanks
> 
> [1] https://lore.kernel.org/linux-media/20250304085819.108067-1-dmitry.osipenko@collabora.com/
> 
> Changelog:
> 
> [...]

Applied, thanks!

[3/3] arm64: defconfig: Enable Synopsys HDMI receiver
      commit: 97d8fe4b7722104b9abdb9cbeb0e884f864c6477

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
  2025-03-06 13:06   ` Heiko Stübner
@ 2025-03-06 15:53     ` Dmitry Osipenko
  2025-03-06 16:16       ` Heiko Stübner
  0 siblings, 1 reply; 14+ messages in thread
From: Dmitry Osipenko @ 2025-03-06 15:53 UTC (permalink / raw)
  To: Heiko Stübner, Shreeya Patel, Mauro Carvalho Chehab,
	Hans Verkuil, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	jose.abreu, nelson.costa, shawn.wen, nicolas.dufresne,
	Sebastian Reichel
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

On 3/6/25 16:06, Heiko Stübner wrote:
> Hi Dmitry,
> 
> Am Donnerstag, 6. März 2025, 08:28:40 MEZ schrieb Dmitry Osipenko:
>> From: Shreeya Patel <shreeya.patel@collabora.com>
>>
>> Add device tree support for Synopsys DesignWare HDMI RX
>> Controller.
>>
>> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Co-developed-by: Dingxian Wen <shawn.wen@rock-chips.com>
>> Signed-off-by: Dingxian Wen <shawn.wen@rock-chips.com>
>> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
>>  .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
>>  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
>>  2 files changed, 71 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
>> index 7f874c77410c..2d4b9986a177 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
>> @@ -594,6 +594,20 @@ hdmim0_tx1_hpd: hdmim0-tx1-hpd {
>>  				/* hdmim0_tx1_hpd */
>>  				<1 RK_PA6 5 &pcfg_pull_none>;
>>  		};
>> +
>> +		/omit-if-no-ref/
>> +		hdmim1_rx: hdmim1-rx {
>> +			rockchip,pins =
>> +				/* hdmim1_rx_cec */
>> +				<3 RK_PD1 5 &pcfg_pull_none>,
>> +				/* hdmim1_rx_scl */
>> +				<3 RK_PD2 5 &pcfg_pull_none_smt>,
>> +				/* hdmim1_rx_sda */
>> +				<3 RK_PD3 5 &pcfg_pull_none_smt>,
>> +				/* hdmim1_rx_hpdin */
>> +				<3 RK_PD4 5 &pcfg_pull_none>;
>> +		};
>> +
> 
> what's the reason for duplicating these pinctrl entries?
> 
> The base-pinctrl already contains a separate set of pins (and also a
> variant for the m0 set of pins), so why not check and use the already
> existing ones:
> 
>                 hdmim1_rx_cec: hdmim1-rx-cec {
>                         rockchip,pins =
>                                 /* hdmim1_rx_cec */
>                                 <3 RK_PD1 5 &pcfg_pull_none>;
>                 };
> 
>                 hdmim1_rx_hpdin: hdmim1-rx-hpdin {
>                         rockchip,pins =
>                                 /* hdmim1_rx_hpdin */
>                                 <3 RK_PD4 5 &pcfg_pull_none>;
>                 };
> 
>                 hdmim1_rx_scl: hdmim1-rx-scl {
>                         rockchip,pins =
>                                 /* hdmim1_rx_scl */
>                                 <3 RK_PD2 5 &pcfg_pull_none>;
>                 };
> 
>                 hdmim1_rx_sda: hdmim1-rx-sda {
>                         rockchip,pins =
>                                 /* hdmim1_rx_sda */
>                                 <3 RK_PD3 5 &pcfg_pull_none>;
>                 };
> 
> 
> Having multiple sets (even with differeing settings) will cause confusion
> later on.

Will try this variant, thanks!

>>  		/omit-if-no-ref/
>>  		hdmim1_rx_cec: hdmim1-rx-cec {
>>  			rockchip,pins =
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
>> index 4a950907ea6f..b7d06f93c8ce 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
>> @@ -135,6 +159,39 @@ i2s10_8ch: i2s@fde00000 {
>>  		status = "disabled";
>>  	};
>>  
>> +	hdmi_receiver: hdmi_receiver@fdee0000 {
>> +		compatible = "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx";
>> +		reg = <0x0 0xfdee0000 0x0 0x6000>;
>> +		power-domains = <&power RK3588_PD_VO1>;
>> +		rockchip,grf = <&sys_grf>;
>> +		rockchip,vo1-grf = <&vo1_grf>;
>> +		interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH 0>,
>> +			     <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH 0>,
>> +			     <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH 0>;
>> +		interrupt-names = "cec", "hdmi", "dma";
>> +		clocks = <&cru ACLK_HDMIRX>,
>> +			 <&cru CLK_HDMIRX_AUD>,
>> +			 <&cru CLK_CR_PARA>,
>> +			 <&cru PCLK_HDMIRX>,
>> +			 <&cru CLK_HDMIRX_REF>,
>> +			 <&cru PCLK_S_HDMIRX>,
>> +			 <&cru HCLK_VO1>;
>> +		clock-names = "aclk",
>> +			      "audio",
>> +			      "cr_para",
>> +			      "pclk",
>> +			      "ref",
>> +			      "hclk_s_hdmirx",
>> +			      "hclk_vo1";
>> +		resets = <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>,
>> +			 <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>;
>> +		reset-names = "axi", "apb", "ref", "biu";
>> +		memory-region = <&hdmi_receiver_cma>;
>> +		pinctrl-0 = <&hdmim1_rx>;
>> +		pinctrl-names = "default";
> 
> hmm, this might be better living in the board dts?

HDMI RX controller is a part of the SoC, it's not specific to a
particular board. If you meaning move it into rock5b.dts, then we
definitely shouldn't do it. It's like moving PCIe controller node into a
board DT :)

-- 
Best regards,
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
  2025-03-06 15:53     ` Dmitry Osipenko
@ 2025-03-06 16:16       ` Heiko Stübner
  2025-03-06 16:24         ` Dmitry Osipenko
  0 siblings, 1 reply; 14+ messages in thread
From: Heiko Stübner @ 2025-03-06 16:16 UTC (permalink / raw)
  To: Shreeya Patel, Mauro Carvalho Chehab, Hans Verkuil, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, jose.abreu, nelson.costa,
	shawn.wen, nicolas.dufresne, Sebastian Reichel, Dmitry Osipenko
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

Am Donnerstag, 6. März 2025, 16:53:48 MEZ schrieb Dmitry Osipenko:
> On 3/6/25 16:06, Heiko Stübner wrote:
> > Hi Dmitry,
> > 
> > Am Donnerstag, 6. März 2025, 08:28:40 MEZ schrieb Dmitry Osipenko:
> >> From: Shreeya Patel <shreeya.patel@collabora.com>
> >>
> >> Add device tree support for Synopsys DesignWare HDMI RX
> >> Controller.
> >>
> >> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> Co-developed-by: Dingxian Wen <shawn.wen@rock-chips.com>
> >> Signed-off-by: Dingxian Wen <shawn.wen@rock-chips.com>
> >> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> ---

> >> +	hdmi_receiver: hdmi_receiver@fdee0000 {
> >> +		compatible = "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx";
> >> +		reg = <0x0 0xfdee0000 0x0 0x6000>;
> >> +		power-domains = <&power RK3588_PD_VO1>;
> >> +		rockchip,grf = <&sys_grf>;
> >> +		rockchip,vo1-grf = <&vo1_grf>;
> >> +		interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH 0>,
> >> +			     <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH 0>,
> >> +			     <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH 0>;
> >> +		interrupt-names = "cec", "hdmi", "dma";
> >> +		clocks = <&cru ACLK_HDMIRX>,
> >> +			 <&cru CLK_HDMIRX_AUD>,
> >> +			 <&cru CLK_CR_PARA>,
> >> +			 <&cru PCLK_HDMIRX>,
> >> +			 <&cru CLK_HDMIRX_REF>,
> >> +			 <&cru PCLK_S_HDMIRX>,
> >> +			 <&cru HCLK_VO1>;
> >> +		clock-names = "aclk",
> >> +			      "audio",
> >> +			      "cr_para",
> >> +			      "pclk",
> >> +			      "ref",
> >> +			      "hclk_s_hdmirx",
> >> +			      "hclk_vo1";
> >> +		resets = <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>,
> >> +			 <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>;
> >> +		reset-names = "axi", "apb", "ref", "biu";
> >> +		memory-region = <&hdmi_receiver_cma>;
> >> +		pinctrl-0 = <&hdmim1_rx>;
> >> +		pinctrl-names = "default";
> > 
> > hmm, this might be better living in the board dts?
> 
> HDMI RX controller is a part of the SoC, it's not specific to a
> particular board. If you meaning move it into rock5b.dts, then we
> definitely shouldn't do it. It's like moving PCIe controller node into a
> board DT :)

sorry, should've been clearer. I meant the pinctrl.
There are two sets of pins hdmim0-rx and hdmim1-rx which one is used is
board specific.

Can you check if "most" boards use the M1 variant?

Rationale being, that if we know that most boards use the same set of
pins, it's likely ok to just have the minority boards override it.

Heiko




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
  2025-03-06 16:16       ` Heiko Stübner
@ 2025-03-06 16:24         ` Dmitry Osipenko
  0 siblings, 0 replies; 14+ messages in thread
From: Dmitry Osipenko @ 2025-03-06 16:24 UTC (permalink / raw)
  To: Heiko Stübner, Shreeya Patel, Mauro Carvalho Chehab,
	Hans Verkuil, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	jose.abreu, nelson.costa, shawn.wen, nicolas.dufresne,
	Sebastian Reichel
  Cc: kernel, linux-media, devicetree, linux-kernel, linux-rockchip,
	Tim Surber, Christophe JAILLET, Diederik de Haas

On 3/6/25 19:16, Heiko Stübner wrote:
>>>> +		pinctrl-0 = <&hdmim1_rx>;
>>>> +		pinctrl-names = "default";
>>> hmm, this might be better living in the board dts?
>> HDMI RX controller is a part of the SoC, it's not specific to a
>> particular board. If you meaning move it into rock5b.dts, then we
>> definitely shouldn't do it. It's like moving PCIe controller node into a
>> board DT 🙂
> sorry, should've been clearer. I meant the pinctrl.
> There are two sets of pins hdmim0-rx and hdmim1-rx which one is used is
> board specific.
> 
> Can you check if "most" boards use the M1 variant?
> 
> Rationale being, that if we know that most boards use the same set of
> pins, it's likely ok to just have the minority boards override it.

Will check, thanks for the clarification!

-- 
Best regards,
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v14 0/3] Enable HDMI RX controller on RK3588
  2025-03-06  7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
                   ` (4 preceding siblings ...)
  2025-03-06 13:09 ` (subset) " Heiko Stuebner
@ 2025-03-06 17:47 ` Rob Herring (Arm)
  5 siblings, 0 replies; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-03-06 17:47 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: Sebastian Reichel, linux-rockchip, devicetree,
	Mauro Carvalho Chehab, Diederik de Haas, Krzysztof Kozlowski,
	Tim Surber, kernel, nicolas.dufresne, Christophe JAILLET,
	Heiko Stuebner, linux-kernel, Shreeya Patel, Conor Dooley,
	linux-media, Hans Verkuil, nelson.costa, shawn.wen, jose.abreu


On Thu, 06 Mar 2025 10:28:39 +0300, Dmitry Osipenko wrote:
> Hello Heiko,
> 
> This is a follow up to the v13 of HDMI RX patches [1]. Hans queued the
> driver into the media tree. Now the DT patches are left to apply, could
> you please take care of this series if it's good to you? Thanks
> 
> [1] https://lore.kernel.org/linux-media/20250304085819.108067-1-dmitry.osipenko@collabora.com/
> 
> Changelog:
> 
> v14: - Re-enabled LOAD_DEFAULT_EDID=y option in the defconfig and
>        added ack from Hans Verkuil fot that patch.
> 
> Sebastian Reichel (2):
>   arm64: dts: rockchip: Enable HDMI receiver on rock-5b
>   arm64: defconfig: Enable Synopsys HDMI receiver
> 
> Shreeya Patel (1):
>   arm64: dts: rockchip: Add device tree support for HDMI RX Controller
> 
>  .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
>  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 18 ++++++
>  arch/arm64/configs/defconfig                  |  2 +
>  4 files changed, 91 insertions(+)
> 
> --
> 2.48.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250306072842.287142-1-dmitry.osipenko@collabora.com:

arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-ok3588-c.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-ok3588-c.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-armsom-w3.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-armsom-w3.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6a-io.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6a-io.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-firefly-itx-3588j.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-firefly-itx-3588j.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']






^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-03-06 17:47 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06  7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
2025-03-06  7:28 ` [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Dmitry Osipenko
2025-03-06 13:06   ` Heiko Stübner
2025-03-06 15:53     ` Dmitry Osipenko
2025-03-06 16:16       ` Heiko Stübner
2025-03-06 16:24         ` Dmitry Osipenko
2025-03-06  7:28 ` [PATCH v14 2/3] arm64: dts: rockchip: Enable HDMI receiver on rock-5b Dmitry Osipenko
2025-03-06 13:07   ` Heiko Stübner
2025-03-06  7:28 ` [PATCH v14 3/3] arm64: defconfig: Enable Synopsys HDMI receiver Dmitry Osipenko
2025-03-06  9:26 ` [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Heiko Stübner
2025-03-06  9:41   ` Hans Verkuil
2025-03-06  9:44     ` Heiko Stübner
2025-03-06 13:09 ` (subset) " Heiko Stuebner
2025-03-06 17:47 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).