From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B076DC7EE2C for ; Mon, 29 May 2023 09:54:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbjE2Jy4 (ORCPT ); Mon, 29 May 2023 05:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231901AbjE2Jyy (ORCPT ); Mon, 29 May 2023 05:54:54 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F2FB5; Mon, 29 May 2023 02:54:52 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B384A84735; Mon, 29 May 2023 11:54:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1685354090; bh=db2/0jhEQ1Ay6cgSGxPYGzJJhbyarHWQB1FeiHON+yU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=stg3lphYIBiYglR9o8zo1bU1Q7StF5VBbmN8WKFt79S6EQGJuTazU/lu3n/aJYRvS PKIGEsGb9mfeEX9x2Pc2KCL3jqpFCHAVappvtfshIXB0EstlL+LJXjeNvb0HqPmqlt h/MaLgb04lJi2sa2MHFfkutZFTY5u8lxUFRiBkOOJDL3oPdttnYlzQn3RN+p/9TxyY XYpoyVF8Nrywlul9WwR13w2bFIGuCgZ0mbIHHR17PbOy/vT62PY9Xi/KlXxWi5Az7g 53uYhc+ILRQ6ZJ8vkorUAVPvN265xyqt0tjRzBY8iNQxK6guq+UFOQjT7RM13Nd+cN UbQELe2JZdplQ== Message-ID: <948ad9a2-f346-c42f-7b1f-47edda19a823@denx.de> Date: Mon, 29 May 2023 11:49:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15 Content-Language: en-US To: Raphael Gallais-Pou , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Philippe Cornu , Yannick Fertre Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@dh-electronics.com References: <20230517143542.284029-1-raphael.gallais-pou@foss.st.com> <20230517143542.284029-4-raphael.gallais-pou@foss.st.com> <5f201903-17cb-5054-763c-f03b1066db1d@denx.de> <32fafa74-8964-c9cf-f95b-f2cd084f46c6@foss.st.com> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5/29/23 10:07, Raphael Gallais-Pou wrote: Hi, >>>> I think if you retain the stm32mp151.dtsi <dc { port { #address-cells = <1>; >>>> #size-cells = <0>; }; }; part, then you wouldn't be getting any warnings >>>> regarding LTDC , and you wouldn't have to remove the unit-address from >>>> endpoint@0 . >>>> >>>> btw. I do use both endpoint@0/endpoint@1 in Avenger96 DTOs, but those are not >>>> submitted yet, I have to clean them up a bit more first. >>>> >>>>> One way to do it would be to make the endpoint@0 go down in the device-tree >>>>> with >>>>> its dependencies, so that both endpoints are the same level without generating >>>>> noise. >>>> >>>> I'm afraid I really don't quite understand which warning you're referring to. >>>> Can you please share that warning and ideally how to trigger it (the >>>> command-line incantation) ? >>> >>> Using '$ make dtbs W=1', you can observe several of the followings: >>> >>> arch/arm/boot/dts/stm32mp151.dtsi:1533.9-1536.6: Warning >>> (avoid_unnecessary_addr_size): /soc/display-controller@5a001000/port: >>> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property >>> arch/arm/boot/dts/stm32mp151.dtsi:1533.9-1536.6: Warning (graph_child_address): >>> /soc/display-controller@5a001000/port: graph node has single child node >>> 'endpoint@0', #address-cells/#size-cells are not necessary >>> >>> This <dc { port { #address-cells = <1>; #size-cells = <0>; }; }; part is >>> actually annoying. This is because there is several device-trees that only got >>> one endpoint, and some other that includes two. >>> >>> For instance: stm32mp15xx-dhcor-avenger96.dtsi vs stm32mp157c-dk2.dts. >>> >>> I would like to remove to root part of address/size field and let only the lower >>> device-trees with with multiple endpoints handle their own fields. I hope this >>> explains a bit better my process. >> >> After thinking about this some more, and digging through LTDC driver, and >> testing on EV1, I think dropping the LTDC node endpoint@N and reg= >> altogether and just using port/endpoint (singular) is fine. >> >> You might want to split the DSI node specific changes and the LTDC node >> specific changes into separate patches (LTDC specific change like you did in >> 1/3). > > Yes, I prepared a new serie with that split, to that it is better to read and > review. Thank you !