From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform Date: Fri, 27 May 2016 10:31:55 +0200 Message-ID: <9495361.v6aft1QR0M@wuerfel> References: <20160527063301.GB1554@Sanchayan-Arch.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20160527063301.GB1554@Sanchayan-Arch.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: maitysanchayan@gmail.com Cc: Rob Herring , Shawn Guo , Stefan Agner , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Friday, May 27, 2016 12:03:01 PM CEST maitysanchayan@gmail.com wrote: > > So if I understand correctly, the binding at the SoC level is fine. > Keeping that but removing the additional made-up properties, viz. below > > rom-revision: phandle to the on-chip ROM node > mscm: phandle to the MSCM CPU configuration node > nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1 > nvmem-cell-names: should contain string names "cfg0" and "cfg1" > > would be fine? > > We would have something similar to here > http://www.spinics.net/lists/devicetree/msg80655.html > > but now with the DT binding under SoC bus. > You look up the OTP device as a syscon here, which seems odd since there is already an nvmem driver for it. Shouldn't you use the nvmem API for that? Arnd