devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sven Peter" <sven@svenpeter.dev>
To: "Jassi Brar" <jassisinghbrar@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Mark Kettenis" <mark.kettenis@xs4all.nl>,
	"Hector Martin" <marcan@marcan.st>,
	"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
	"Mohamed Mediouni" <mohamed.mediouni@caramail.com>,
	"Stan Skowronek" <stan@corellium.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Apple Mailbox Controller support
Date: Sat, 16 Oct 2021 11:21:16 +0200	[thread overview]
Message-ID: <94e07975-f63e-4568-986f-71a278777e9d@www.fastmail.com> (raw)
In-Reply-To: <20210916154911.3168-1-sven@svenpeter.dev>

On Thu, Sep 16, 2021, at 17:49, Sven Peter wrote:
> Hi,
>
> This is the second version of my series which adds support for the mailbox
> controllers found on the Apple M1.
>
> v1: https://lore.kernel.org/lkml/20210907145501.69161-1-sven@svenpeter.dev/
>
> Thanks to Jassi, Mark and Alyssa for the initial review. I've addressed
> your comments with the following changes:
>
>  - switched to txdone_irq instead of introducing a new mode
>  - switched to a threaded interrupt handler for receiving messages
>  - added co-processor examples to the device tree binding 
>  - reformatted the register defines and clarified multiple comments
>
> Best,
>
> Sven
>
> Sven Peter (2):
>   dt-bindings: mailbox: Add Apple mailbox bindings
>   mailbox: apple: Add driver for Apple mailboxes
>
>  .../bindings/mailbox/apple,mailbox.yaml       |  84 ++++
>  MAINTAINERS                                   |   3 +
>  drivers/mailbox/Kconfig                       |  12 +
>  drivers/mailbox/Makefile                      |   2 +
>  drivers/mailbox/apple-mailbox.c               | 431 ++++++++++++++++++
>  include/linux/apple-mailbox.h                 |  18 +
>  6 files changed, 550 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>  create mode 100644 drivers/mailbox/apple-mailbox.c
>  create mode 100644 include/linux/apple-mailbox.h
>
> -- 
> 2.25.1

Hi Jassi,

Have you had a chance to look at this series yet?


Thanks,


Sven

      parent reply	other threads:[~2021-10-16  9:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 15:49 [PATCH v2 0/2] Apple Mailbox Controller support Sven Peter
2021-09-16 15:49 ` [PATCH v2 1/2] dt-bindings: mailbox: Add Apple mailbox bindings Sven Peter
2021-09-21 22:08   ` Rob Herring
2021-09-16 15:49 ` [PATCH v2 2/2] mailbox: apple: Add driver for Apple mailboxes Sven Peter
2021-09-19 11:51   ` Alyssa Rosenzweig
2021-10-16 19:04   ` Jassi Brar
2021-10-16 19:16     ` Alyssa Rosenzweig
2021-10-16 19:17     ` Sven Peter
2021-10-17 11:25   ` Mark Kettenis
2021-10-17 11:27     ` Sven Peter
2021-09-19 11:47 ` [PATCH v2 0/2] Apple Mailbox Controller support Alyssa Rosenzweig
2021-10-16  9:21 ` Sven Peter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94e07975-f63e-4568-986f-71a278777e9d@www.fastmail.com \
    --to=sven@svenpeter.dev \
    --cc=alyssa@rosenzweig.io \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=mark.kettenis@xs4all.nl \
    --cc=mohamed.mediouni@caramail.com \
    --cc=robh+dt@kernel.org \
    --cc=stan@corellium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).